Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp830171imu; Tue, 11 Dec 2018 08:12:50 -0800 (PST) X-Google-Smtp-Source: AFSGD/XsSHvhdE3Tl48fmY6xM4zt27JxlQ2jr2Sazpuj5UM91P/OrBGBtv7LiNEBimSEd+QLcRjG X-Received: by 2002:a17:902:8346:: with SMTP id z6mr16458489pln.340.1544544770850; Tue, 11 Dec 2018 08:12:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544544770; cv=none; d=google.com; s=arc-20160816; b=QI24AeWTEmo1cP7FKR5GcfYoZ2223lRntjk9mhQfmgwZmoytbfuIAn46GiIjbj50Bh iAsffOBnLlOjBtGuxgMA+J5ryJXv5XNUrJG5+d+E3wNInaSZ5g9xS6HJxkERY3dEvpOI Scu4ucIdIoBbsyUPX9RlT0CguNewAh796i/TDwNM1JYLy+d0jgVbN02INrq/oKxhcKn5 8GQkmNmArcFtKDZLPuxMEvKGGGSjCcVBgmCUO6w5pi5pw64mblbyJnHoJquXqFolx5Wm 2aDfaBMI26VK6jTCRV0WB+QWqRT8JaKlf+5zDKqMi4ULe3ZHsXCBLXEH832g87B8LR3f P3LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=SRMGnlPxN4b96+5gfiZBnBPrAX+a3KibD0k+wi5rbU0=; b=P/6KQHJAqHwhZPX7B3BRx+aylHsWKoDZWgA2146ApmmxJpqGiaaQyMg00zygWZflu4 7zeMhVBKbEEORegp4kO9PVG1xcSbJz+M7GiT87rtuclq1KKwu5LG0eC05w3mGeiI8Rgy YhCzkmsDrr7QEGMO+jsSAaK2Mk20xm47Kv5Y0TCMX4vxE+AqN6GLECAfaanjIgWQaAWe xIqr46XQ+HgZ8AsWzYLY6qafhRS+wyHwDLKAEH/h7MlOSxaF5Z+E/XeWO99GUQUjZZ1S QPx3w7FoFuJAsL7KuemcOVhAj3K40QqtisbvInCcncVik80lX5b5fsUAdRuLfD+QVKk7 LrWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="KIB/zYuU"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c9si12690653pll.439.2018.12.11.08.12.36; Tue, 11 Dec 2018 08:12:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="KIB/zYuU"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730131AbeLKQJs (ORCPT + 99 others); Tue, 11 Dec 2018 11:09:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:40742 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729641AbeLKPwD (ORCPT ); Tue, 11 Dec 2018 10:52:03 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9A0A520855; Tue, 11 Dec 2018 15:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544543523; bh=eIERhGfJsswgvS4s5qiIFpY+fcK/sJgD3J+Bb9PLy3w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KIB/zYuUbe1PEZbQj+8T1jGYFUG0dzO2de0q7yq7sEXX8PyS45+0kd73CVdlGGqzb t9hnCp60lRnsvZAPu6bCycf6SUxDLS+NfNXxsU7mwZZtdDq3zVp0aEPdrIAfXeqL61 o+33d1FzMU1KYdul30+VM7oxi3gO1H3Z9Rvz6ZfU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Kalle Valo , Sasha Levin Subject: [PATCH 4.14 03/67] brcmutil: really fix decoding channel info for 160 MHz bandwidth Date: Tue, 11 Dec 2018 16:41:03 +0100 Message-Id: <20181211151630.539205550@linuxfoundation.org> X-Mailer: git-send-email 2.20.0 In-Reply-To: <20181211151630.378216233@linuxfoundation.org> References: <20181211151630.378216233@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 3401d42c7ea2d064d15c66698ff8eb96553179ce ] Previous commit /adding/ support for 160 MHz chanspecs was incomplete. It didn't set bandwidth info and didn't extract control channel info. As the result it was also using uninitialized "sb" var. This change has been tested for two chanspecs found to be reported by some devices/firmwares: 1) 60/160 (0xee32) Before: chnum:50 control_ch_num:36 After: chnum:50 control_ch_num:60 2) 120/160 (0xed72) Before: chnum:114 control_ch_num:100 After: chnum:114 control_ch_num:120 Fixes: 330994e8e8ec ("brcmfmac: fix for proper support of 160MHz bandwidth") Signed-off-by: Rafał Miłecki Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/broadcom/brcm80211/brcmutil/d11.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmutil/d11.c b/drivers/net/wireless/broadcom/brcm80211/brcmutil/d11.c index e7584b842dce..eb5db94f5745 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmutil/d11.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmutil/d11.c @@ -193,6 +193,9 @@ static void brcmu_d11ac_decchspec(struct brcmu_chan *ch) } break; case BRCMU_CHSPEC_D11AC_BW_160: + ch->bw = BRCMU_CHAN_BW_160; + ch->sb = brcmu_maskget16(ch->chspec, BRCMU_CHSPEC_D11AC_SB_MASK, + BRCMU_CHSPEC_D11AC_SB_SHIFT); switch (ch->sb) { case BRCMU_CHAN_SB_LLL: ch->control_ch_num -= CH_70MHZ_APART; -- 2.19.1