Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp901530imu; Tue, 11 Dec 2018 09:17:09 -0800 (PST) X-Google-Smtp-Source: AFSGD/W8AQRWBvk89gISo9jhxfTiYk3N5kbkimyqVA9ss6XzTxEzOUThre1f1mOyI7knYtHeCFgF X-Received: by 2002:a17:902:264:: with SMTP id 91mr16906924plc.108.1544548629442; Tue, 11 Dec 2018 09:17:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544548629; cv=none; d=google.com; s=arc-20160816; b=y2drQ0iyIw3jN3ue763GHw0W55cPxyBlkA8yGlP+QmKq5JcMJe6rJCvgUb2Miqmy0Q Ypc3CMoSD9dQ2phpRTDAhj6wAX6A19JaKX/xKV6SnSOW4BjvcFDbcSj/QoIAOcai0gPa yBOr5J+9ztNBgveMWDkFM3by+Ip0CS/PL6KQtz1PupF8Xta1Ybmpa2XrKlp+FAxcjVEb C95lcnbjYhJI7556Wwz8njtPupp8uxLbrNoTlkJc+Lg86KPmv+gBCxnjScADBSJFkhkH oM6Z3GxD/4hV4VA6Z0wK0FMsQcGNbyQge0ABznsjEK12K0LSIjjKfMGdajcoGOxlfmOB empA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=uYNiHuv1pMIn/UKF6j30MAmIaYbKkpZTKegb819Sc+M=; b=ZRHgdiLkjbI6CCecpLh2wxLajyC/GdQaIWU+D2Sf7wtvty71IlklVSmwLvjTRx4NI/ DMOCtm7BjQ8Ny2SUKxgO3LHzUJLOPfjdOTMjlKsxpFahNlh7yNPOW3BbyuWRfNdGF1tT o59IrerE5UmIQI2qg+0xEBdnHVmBacysW58Habh1zmBb219e/3flEop79HoudAy4SkuX xb0ZeH/rU7LMMfXMcQTfjx84izBQWzpa63LLnXgCaNRY8REbSVKfywhXRL+V54Ei8nRu wQkz29RUFGATsUjzM9k4kSQ7w7WCaIZL1kGJa/it3AOhIKKzCr7p7Fz3UIeYH1RB3zXt HKqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=d1V0gH0V; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h10si12578305pgi.562.2018.12.11.09.16.54; Tue, 11 Dec 2018 09:17:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=d1V0gH0V; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730233AbeLKPyp (ORCPT + 99 others); Tue, 11 Dec 2018 10:54:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:43306 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729738AbeLKPyl (ORCPT ); Tue, 11 Dec 2018 10:54:41 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 779CA20855; Tue, 11 Dec 2018 15:54:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544543680; bh=4jgAfCUNjKEpfgooFoVg5UA2/5saZFnAS5xSD9WzsqU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d1V0gH0VZhWaVSLfhAEcHjZ4v7VayV8ef4b1rIXe/c+0Fb0P5JUFmbDX55cVgQZHP 2oezn/0uD2ZSondbfuQ9KHHqMl6qxHPo3caGgKyPslhgkzFo9O7lIP/+iHwknmjhhJ yhxCRDfOcjWxcEGtBDWWA3o0vAfqeGeintbH074o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Minas Harutyunyan , Dan Carpenter , Felipe Balbi , Sasha Levin Subject: [PATCH 4.19 022/118] usb: dwc2: pci: Fix an error code in probe Date: Tue, 11 Dec 2018 16:40:41 +0100 Message-Id: <20181211151645.137169734@linuxfoundation.org> X-Mailer: git-send-email 2.20.0 In-Reply-To: <20181211151644.216668863@linuxfoundation.org> References: <20181211151644.216668863@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 3c135e8900199e3b9375c1eff808cceba2ee37de ] We added some error handling to this function but forgot to set the error code on this path. Fixes: ecd29dabb2ba ("usb: dwc2: pci: Handle error cleanup in probe") Acked-by: Minas Harutyunyan Signed-off-by: Dan Carpenter Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin --- drivers/usb/dwc2/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc2/pci.c b/drivers/usb/dwc2/pci.c index d257c541e51b..7afc10872f1f 100644 --- a/drivers/usb/dwc2/pci.c +++ b/drivers/usb/dwc2/pci.c @@ -120,6 +120,7 @@ static int dwc2_pci_probe(struct pci_dev *pci, dwc2 = platform_device_alloc("dwc2", PLATFORM_DEVID_AUTO); if (!dwc2) { dev_err(dev, "couldn't allocate dwc2 device\n"); + ret = -ENOMEM; goto err; } -- 2.19.1