Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp905267imu; Tue, 11 Dec 2018 09:20:26 -0800 (PST) X-Google-Smtp-Source: AFSGD/W/lJlPnmYgXhdt+CxCi56nGk+85H58ZuuwoKax3o8uOsbe0GNiDRQ4V4FpT6AZv7+yYa/2 X-Received: by 2002:a62:3c1:: with SMTP id 184mr17274727pfd.56.1544548825995; Tue, 11 Dec 2018 09:20:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544548825; cv=none; d=google.com; s=arc-20160816; b=d1oUbCOkQAZo5voFQJoZ+uic5Cf8chMsIiiME/3wclrphlweVED/IYhIU3CZV7rJY9 vZeVG6gO4FPUE7u22UUEzWeWwQEc2bqyx7BktaI+mh/OSArCRFGQORyK+C0Aex9PVMyb 2xkQ1d+kDycTzXiwHtG9rtaGVOfjCVkmiHeS7O1vDj/ejxfq1OY7EvNNsnUwAvy06XDE MGE9n5lXMcKPqfkFmjW1g+HjjwBaxgTU+dIOPbpguNdc1XJaitrfdemui7zRt6xaRW5h 2ggO2zyp4wRwP4kRn5GdOAtwCfjn3urRSM10JmU62DgJeNr/pgx3JNGzmIyIUs9pDkQ1 Vexg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=z/o0IR32zoIBFFHbeymJ25AsExqxACTkwltUZG9bqx8=; b=JzxqS3azQI5CDi8kBXWGwE/41U3dy+6Y5qY0eBTD3OH8ZHxTYZrNmEH4vC4M7sstSp WqaP6O2zzEsPBd+i+hKtEqxf0Ml3WZT77IyfwugT14cIeJgkMWGgONQc/r0ZbxKs/8+k Q/q7NZi2sjPW3aMI5/rzSVirq9lUn3EF1H1S0Iu/v7JSTmAbB9gS+hBkHWncUnz/CWty qMvMzyEkq/BtYC2SQKGGVyJle/g9R8YWFHtS13/2Ha3Z+ehc92JFnd/+4w2gI8+NVhwC QKfhvPdzfKcUPROnJ3X4nEkqTyVUHQCl5jfVy+dQcFD74MlX5kIcSmFw/xo9bixpPYlj DKuQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h16si12758291pgh.283.2018.12.11.09.20.11; Tue, 11 Dec 2018 09:20:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727830AbeLKQk1 (ORCPT + 99 others); Tue, 11 Dec 2018 11:40:27 -0500 Received: from mga01.intel.com ([192.55.52.88]:60044 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726628AbeLKQk0 (ORCPT ); Tue, 11 Dec 2018 11:40:26 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2018 08:40:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,342,1539673200"; d="scan'208";a="129012135" Received: from wpong-mobl1.amr.corp.intel.com ([10.252.193.64]) by fmsmga001.fm.intel.com with ESMTP; 11 Dec 2018 08:40:21 -0800 Message-ID: <1913c8d0be777a59d59135c067abf270b0594c63.camel@linux.intel.com> Subject: Re: [PATCH 0/2] tracing: Fix a couple of memory leaks in the event trigger code From: Tom Zanussi To: Steven Rostedt , linux-kernel@vger.kernel.org Cc: Ingo Molnar , Andrew Morton Date: Tue, 11 Dec 2018 10:40:19 -0600 In-Reply-To: <20181210204126.603121253@goodmis.org> References: <20181210204126.603121253@goodmis.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-1.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steve, On Mon, 2018-12-10 at 15:41 -0500, Steven Rostedt wrote: > Tom, > > While testing other changes, kmemleak pointed out a few leaks in the > trigger code. Can you take a look at them and give me a Reviewed-by > or Ack. > > Thanks! > > -- Steve > > > Steven Rostedt (VMware) (2): > tracing: Fix memory leak in create_filter() > tracing: Fix memory leak in set_trigger_filter() > Sure, these look fine to me. Reviewed-by: Tom Zanussi Thanks, Tom > ---- > kernel/trace/trace_events_filter.c | 5 ++++- > kernel/trace/trace_events_trigger.c | 6 ++++-- > 2 files changed, 8 insertions(+), 3 deletions(-)