Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1066893imu; Tue, 11 Dec 2018 12:08:05 -0800 (PST) X-Google-Smtp-Source: AFSGD/X23WJv1nzIowyztMZH9ufaSGNW3MwWcKBamFs6Iyq/ZWdUGLeApW8tQLx4vNXqUt/y9Nk+ X-Received: by 2002:a17:902:2b84:: with SMTP id l4mr17362033plb.191.1544558885362; Tue, 11 Dec 2018 12:08:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544558885; cv=none; d=google.com; s=arc-20160816; b=nUG1xoPr9vL6nDft4O4cUVx9FamiAR9/+mbBDA265QtsD9GySsPLnpXks7VG5qePVU +8Bw3T50d/eaKKkJbFjUhxCR8eSOAZbF4ie0y9LicUFlnZm6gH+vR50PedC66IR0owWR KnyC6QAUBsTUPiMZDqjLsXhPb1jhy/8+7n5+XFafQeJdcWWjjxarmYAesT8+pzi8rduK OXrfYImbpHMIqSCyfyjo/3/aWJLz6Qqt+L3nYHREIgwlxqC7iT64rf2zLp31O1vtwywA eTlb7VpKjuznDZzTYPw1ei1QtgAMvbA0mkio7TRwoKIApEDStJGWpf8JAit1RlBSkRfE k86w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=kZXSNL6S58Ywbr10rHO428KxSyDbsF3iVW1wQYKzqOo=; b=Vn4XwRG2ZN991cIJmiVRAab/LggNImMpKq/ZNUv4WgrA1cKfBFOjLwxR001MMjP+ou RVvKvt+i5dHEnO59D/pT3PbRvIDapVEBxhVGNCWOI6/9drPX+pm6VBAlM0yX5IItccfz 3MByu1Y6d9A7nXraFHD5xt8JuLY5Qk/RgytzJWgKL+m6weWr5RDp35TvqHa3pL0oYqEG Ot1vBZqiofsMpJmuIB6VLiLOldAt+ALmO84zUZUSVXKHEx8VRVXYD5Rf3d9VtZVQ7lR3 XJQTmputx1YT2itjwO1T34P2Z4OIb2YmsMYNJDReo84Xf9S+JCs+aLqodfv5zYh/FjvJ +C+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j11si13607167plb.253.2018.12.11.12.07.50; Tue, 11 Dec 2018 12:08:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726295AbeLKUFa (ORCPT + 99 others); Tue, 11 Dec 2018 15:05:30 -0500 Received: from sauhun.de ([88.99.104.3]:45364 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726125AbeLKUF3 (ORCPT ); Tue, 11 Dec 2018 15:05:29 -0500 Received: from localhost (p54B334A7.dip0.t-ipconnect.de [84.179.52.167]) by pokefinder.org (Postfix) with ESMTPSA id BC5284C0E90; Tue, 11 Dec 2018 21:05:27 +0100 (CET) Date: Tue, 11 Dec 2018 21:05:27 +0100 From: Wolfram Sang To: "Adamski, Krzysztof (Nokia - PL/Wroclaw)" Cc: "Sverdlin, Alexander (Nokia - DE/Ulm)" , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linus Walleij , Guenter Roeck , Tobias Jordan , Peter Rosin Subject: Re: [PATCH 2/3] i2c-axxia: check for error conditions first Message-ID: <20181211200527.t42yj5xcv4ijuoaj@ninjato> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="v2trzgsti2cxbi6h" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --v2trzgsti2cxbi6h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 10, 2018 at 03:01:27PM +0000, Adamski, Krzysztof (Nokia - PL/Wr= oclaw) wrote: > It was observed that when using seqentional mode contrary to the > documentation, the SS bit (which is supposed to only be set if > automatic/sequence command completed normally), is sometimes set > together with NA (NAK in address phase) causing transfer to falsely be > considered successful. >=20 > My assumption is that this does not happen during manual mode since the > controller is stopping its work the moment it sets NA/ND bit in status > register. This is not the case in Automatic/Sequentional mode where it > is still working to send STOP condition and the actual status we get > depends on the time when the ISR is run. >=20 > This patch changes the order of checking status bits in ISR - error > conditions are checked first and only if none of them occurred, the > transfer may be considered successful. This is required to introduce > using of sequentional mode in next patch. >=20 > Signed-off-by: Krzysztof Adamski Applied to for-next, thanks! --v2trzgsti2cxbi6h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlwQGIYACgkQFA3kzBSg KbYrpA//cyXc4G0XUB9HpGQS645etLcUQTo3h0wf9DojLPegTXn2EiCm8SZ1eOvT voMrmQ9mlkB46ewdn6u2UYZB/QZvVE/IZRP0Wwv5vARxpjcCpMYHK6gdomSwe1YH Y6NyfW6JAopk+WOkB3zEWAjwo5Kaf329vbIWOLImBpIJGwrg36V8gD0qJRGTfz4E Dmws4jAeAz0tH/2PhSHualquiObcHO4XWnmEgp9nf7Z4mhfpN7/LQ4R1u7P6wtuk xiQS5w+jl1iBtBTsIirnNBxi8QlezuqUHqN8/XDM2tmBAFz2OC1wsKMTyWDtIhnZ SB0Z58uj2zOCZF6fbv6A9C6rJw/umoV0qx41IqngGdCQS8mdICycLWIELz90nwZo 7JyT0Ec1yMvobHoOrrJaDbylyI33Bl4YPjdiEdoRxFHa/zUHIfWK5VmqdiWC/V+K yJEbumyQc5OaV/T3J4HtCwFEjSZKDMguKmYdmJpIVKgK+Rx/13qiSBVjHdmdGqbj PAA1OBEH0+VCZBX53WPRMaW/RBJuvN77uTgfuVLD2b2ET/WU0J0vee3yitvF+eTw 6gFDxfCoMyaPSdx2na6gFc5v/DOvi0bnjXiSQnj2wcDiSH5WwQYz+Kt6A84rIuZx UUD/pj+G2gciiGYINS9UNibnpCmdQ2mK6Rz/QFbs5qpUTp9dVEg= =jTOb -----END PGP SIGNATURE----- --v2trzgsti2cxbi6h--