Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1101891imu; Tue, 11 Dec 2018 12:44:27 -0800 (PST) X-Google-Smtp-Source: AFSGD/UBj3RW0ZEAyuebw9RORagzOnYqeJekNueCzUF/SIbn6mAUahPphs6EZwn+sSMS5ydWcmJq X-Received: by 2002:a63:5122:: with SMTP id f34mr15332915pgb.218.1544561067629; Tue, 11 Dec 2018 12:44:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544561067; cv=none; d=google.com; s=arc-20160816; b=j3YBCSmz1LJahiJSj2qiYX9o2aVJBx6ilO5QKkzME6io3UlmjcVq/8Kxu9nZTBdiz8 4nmgZkuHWtOTT/u1UDn1y7aXHZ23VagHDR0CAJ5iGDQoOhZtfBlMAg9aOnKnHdtbJJob qJsm11xwzRvlWiICLsfiEq8bdsHkBFhUK33c5jtXjMTOM2uVEL3k5WQRzzscG8K5ym/J 5kFJ6zloLhm1PO9YQCOKZPzRqUEtn7X7AGYTFrSYLcpQEJNLWprE5Dj0mGiqd4LHEoM6 qCrTLXkn17d4qQwdufTOpatyKb2bXYz+KluWOy2VZZRj7or0albSteGGdQVx7ICH65nN CTSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=P44mgAMGgp3wj1POzEQZ98DJ1h8tqjLNtZ1yeU5l3ik=; b=xXyvT0payV3NheC8dFlqrKVbl5DOzGSAob7uSARm98JkKWSUkAfrXS51G+oBKjmN/x jX1PgmSlLqroak1cIOtC0CmWmbseA1ht/wvbe3H+wU1lQFextJsj1QStI668hFKL3q9M kehfzuS0Z0SaadpXnTTqoBXm56O0Qt5eI/Lp8JpM+C5zkb6iUtl9YegUZuO9mgbzQP6R hmA6FoGeSoEaLRY0mosmL5t/f0oaAXsO//5IqiPlv9wYf5tqYuGLSClv0pilkcNVxU8S bYFVx2eDLJdsEvstG/prBixVrF4nSIzFmsZCn2CnU1SvgZ2S3o0HiAdPyaqeSrTMR5s3 EERw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=q8Oomeaq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e16si12597830pge.364.2018.12.11.12.44.12; Tue, 11 Dec 2018 12:44:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=q8Oomeaq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726219AbeLKUnU (ORCPT + 99 others); Tue, 11 Dec 2018 15:43:20 -0500 Received: from mail.skyhub.de ([5.9.137.197]:57690 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726134AbeLKUnU (ORCPT ); Tue, 11 Dec 2018 15:43:20 -0500 Received: from zn.tnic (p200300EC2BCD2B0010F6E1EC68D6BA6C.dip0.t-ipconnect.de [IPv6:2003:ec:2bcd:2b00:10f6:e1ec:68d6:ba6c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 630DD1EC0BFC; Tue, 11 Dec 2018 21:43:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1544560998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=P44mgAMGgp3wj1POzEQZ98DJ1h8tqjLNtZ1yeU5l3ik=; b=q8OomeaqbcTq9hqdnwwTo79RmpzJXSOAsU0/CduhB3KSN5CJlezjIVWiA5mtbBAAPlT5wJ WV83Q76hZ8IVNULr4sg89SjD7iJBrZaGFl2zGqeDR7USIsxWWfvskShcc8+jg3Jz8Uijzn sXiLmrXoNgXlimAnxLsLYqjMJ/SF9CI= Date: Tue, 11 Dec 2018 21:43:10 +0100 From: Borislav Petkov To: Reinette Chatre Cc: tglx@linutronix.de, fenghua.yu@intel.com, tony.luck@intel.com, gavin.hindman@intel.com, jithu.joseph@intel.com, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH V2] x86/intel_rdt: Ensure usage of CPUs are locked while needed Message-ID: <20181211204310.GQ27375@zn.tnic> References: <20181211123404.GC27375@zn.tnic> <20181211185059.GP27375@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 11, 2018 at 11:02:08AM -0800, Reinette Chatre wrote: > I just wanted to emphasize that it is not the schemata writing that > needs to be protected, but instead the pseudo-locking code that runs > after schemata programming that needs to run on a particular CPU. The > new patch subject could be interpreted to mean the former ... but that > is starting to sound like nitpicking by me. Nah, that's not nitpicking - it is important that we sort out stuff fully before committing. Now, I'm trying to understand what you're telling me and I believe you mean what update_domains() does, yes? And I guess a more fitting subject in that case could be: x86/intel_rdt: Ensure a CPU remains online for the region's pseudo-locking sequence or so, and then the commit message explains in more detail what that title actually means. :) Hmmm. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.