Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265783AbUATUBc (ORCPT ); Tue, 20 Jan 2004 15:01:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265784AbUATUBc (ORCPT ); Tue, 20 Jan 2004 15:01:32 -0500 Received: from mailhost.tue.nl ([131.155.2.7]:15365 "EHLO mailhost.tue.nl") by vger.kernel.org with ESMTP id S265783AbUATUBa (ORCPT ); Tue, 20 Jan 2004 15:01:30 -0500 Date: Tue, 20 Jan 2004 21:01:23 +0100 From: Andries Brouwer To: Pascal Schmidt Cc: Jens Axboe , linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix for ide-scsi crash Message-ID: <20040120210123.A1528@pclin040.win.tue.nl> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from der.eremit@email.de on Tue, Jan 20, 2004 at 06:08:44PM +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 826 Lines: 22 On Tue, Jan 20, 2004 at 06:08:44PM +0100, Pascal Schmidt wrote: > I have a question about cdrom_start_read_continuation: > > Variables called nframes and frames are computed but never used. Only > nskip actually gets factored into the request: > > rq->current_nr_sectors += nskip; > > The others are local vars and never get assigned to anything more > global. So I conclude they are meaningless? I ask because this > is one of the places that uses SECTORS_PER_FRAME and it doesn't make > sense to me. Yes, they are meaningless. The code that used them was removed in 2.5.1. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/