Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To:     Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Felipe Balbi <felipe.balbi@linux.intel.com>,
        Simon Horman <horms+renesas@verge.net.au>,
        Chris Brandt <Chris.Brandt@renesas.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: renesas_usbhs: mark PM functions as __maybe_unused
Thread-Topic: [PATCH] usb: renesas_usbhs: mark PM functions as __maybe_unused
Thread-Index: AQHUkTlBqDCbIxtrnEiimwSiV/xiBKV6W3lQ
Date:   Wed, 12 Dec 2018 02:11:40 +0000
Message-ID: <OSBPR01MB22931F20DD3B4EA1BC1C01F4D8A70@OSBPR01MB2293.jpnprd01.prod.outlook.com>
References: <20181211100645.650975-1-arnd@arndb.de>
In-Reply-To: <20181211100645.650975-1-arnd@arndb.de>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
received-spf: None (protection.outlook.com: renesas.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 177a15a9-084c-4c7c-8577-08d65fd72792
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2018 02:11:40.3853
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSBPR01MB4152
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Arnd,

Thank you for the patch!

> From: Arnd Bergmann, Sent: Tuesday, December 11, 2018 7:06 PM
> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Arnd Bergmann <arnd@arndb.de>; Yoshihiro Shimoda <yoshihiro.shimoda.u=
h@renesas.com>; Felipe Balbi
> <felipe.balbi@linux.intel.com>; Simon Horman <horms+renesas@verge.net.au>=
; Chris Brandt <Chris.Brandt@renesas.com>;
> linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] usb: renesas_usbhs: mark PM functions as __maybe_unused
>=20
> Without CONFIG_PM, we get a new build warning here:
>=20
> drivers/usb/renesas_usbhs/common.c:860:12: error: 'usbhsc_resume' defined=
 but not used [-Werror=3Dunused-function]
>  static int usbhsc_resume(struct device *dev)
>             ^~~~~~~~~~~~~
> drivers/usb/renesas_usbhs/common.c:844:12: error: 'usbhsc_suspend' define=
d but not used [-Werror=3Dunused-function]
>  static int usbhsc_suspend(struct device *dev)
>             ^~~~~~~~~~~~~~
>=20
> No idea why this never happened before, but it's trivial to work
> around by marking the functions as __maybe_unused so the compiler
> can silently discard them.

This build warning cause the commit d54d334e75b9 ("usb: renesas_usbhs:
Use SIMPLE_DEV_PM_OPS macro").

So, I'd like to add the following tag on this commit log.

Fixes: d54d334e75b9 ("usb: renesas_usbhs: Use SIMPLE_DEV_PM_OPS macro")

Also, we can remove "No idea why this never happened before, but"
from the commit log.

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

After revised the commit log a little:

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda

> ---
>  drivers/usb/renesas_usbhs/common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usb=
hs/common.c
> index 02c1d2bf4f86..2ff7991f4517 100644
> --- a/drivers/usb/renesas_usbhs/common.c
> +++ b/drivers/usb/renesas_usbhs/common.c
> @@ -841,7 +841,7 @@ static int usbhs_remove(struct platform_device *pdev)
>  	return 0;
>  }
>=20
> -static int usbhsc_suspend(struct device *dev)
> +static __maybe_unused int usbhsc_suspend(struct device *dev)
>  {
>  	struct usbhs_priv *priv =3D dev_get_drvdata(dev);
>  	struct usbhs_mod *mod =3D usbhs_mod_get_current(priv);
> @@ -857,7 +857,7 @@ static int usbhsc_suspend(struct device *dev)
>  	return 0;
>  }
>=20
> -static int usbhsc_resume(struct device *dev)
> +static __maybe_unused int usbhsc_resume(struct device *dev)
>  {
>  	struct usbhs_priv *priv =3D dev_get_drvdata(dev);
>  	struct platform_device *pdev =3D usbhs_priv_to_pdev(priv);
> --
> 2.20.0