Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1592693imu; Wed, 12 Dec 2018 00:25:09 -0800 (PST) X-Google-Smtp-Source: AFSGD/VFozzswF5zu2/hXimWnZo8t9t2UIdlRNzQLzdr9SbcZNRBsM/BjP3SaQKM3GoJG1yJ0v4z X-Received: by 2002:a63:e615:: with SMTP id g21mr17755810pgh.290.1544603109438; Wed, 12 Dec 2018 00:25:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544603109; cv=none; d=google.com; s=arc-20160816; b=y/l+E0VP9oXhzHHtGO/ZZPMTfODfYDv9CTC63DOxEL9NzXIkODQDSQbLKUJfI4twEp uAngAuThJTJGPBW8eMRVuiESqnIGFGeOo0nc3+M70JcB5M2VwKOmxnDQAOu3BVNXkLjm MzDcmHieUe2njqbkU6ZkhJOc2iG2rWwDaG6I1HCt53BKFG8h891bbkSMIyx5iPBDKrIx zNChDI28J6zD7lFaFTU1eHC8jSDv37fl9y+10ReW0tbad4XtFCZmpZ3h8J5cLoa79b9u CyOduL6fCz+zDOc8A9vEHyC2I873XacMm/ym6qGzv7CJmpj0CDmlAH4lk4u/FJbuzYDj hGYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=EVauG/4yYiU14o01eHgkFQHILvaYWkMARZraDchJbmM=; b=klGIH9+dMqVITMOHI4DizE3fOqRcNZDtby49LqqgFDJ/efIEN/Snh9rfZowW+tuwds tQMkbxfCPBW8YwPtM/5QIw3BOPV8Pb8jqAW7vrryVGpRo4D+Dntu8qB99zCTYpmHGmLV JalCNgbmaezaR0HlV7hE/9lHIu90yxtiaZSjjLaP3Edg+VQqESHurpXOX7/JMUoTDON2 X+NkvcTMyEYUfXCWfdOcUdHKqfpMp1iv6iRUkTDSnz90Ua7lfwSoTACqaE3lwPE6Czys /6Z+UcZnPJNUgR+u0XeCZuw/reDj03blwquG9lBgTCdoNB9HFwEpHXTSyvLjj2P8wDht xGPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=O2xdfgiH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x15si14645003pgq.378.2018.12.12.00.24.54; Wed, 12 Dec 2018 00:25:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=O2xdfgiH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726774AbeLLIX4 (ORCPT + 99 others); Wed, 12 Dec 2018 03:23:56 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:55770 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726478AbeLLIX4 (ORCPT ); Wed, 12 Dec 2018 03:23:56 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wBC8ItJT022607; Wed, 12 Dec 2018 08:23:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=EVauG/4yYiU14o01eHgkFQHILvaYWkMARZraDchJbmM=; b=O2xdfgiHmtjX+Y6Ys1+2XHPROESHpRF/4L3Dli9Ec1mlhpLCNsONPo7PRDA0vQsjsXj5 hj2Z7IXIAAybxf/36Awr54KWGurdvlihmdoZ0GtoInlumeKgDAozyC2SRXvxWAmrQ8cy U05USUQHouG6pBLrK8y15Sk8BAqOMbpMbSAJKoXckDtLa3a4f6PYfZEGsVylFjtpU4za +7/vH7i2NhzvpyuWl81lDwDWlu47ubGogUhU210I3XvdlqO3kj4plymmOS3u7y3KAKiT DbvQi+yvJK4fuqXVKqahjyT71dZsMJGasJxqmqJ3z5OSb6TLi8b1kQtfUvQlE4BwIkhf Xg== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp2130.oracle.com with ESMTP id 2pawwp079h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Dec 2018 08:23:27 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wBC8NQav032462 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Dec 2018 08:23:26 GMT Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wBC8NPwa021475; Wed, 12 Dec 2018 08:23:25 GMT Received: from kadam (/197.157.0.38) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 12 Dec 2018 00:23:24 -0800 Date: Wed, 12 Dec 2018 11:23:16 +0300 From: Dan Carpenter To: Jeremy Fertic Cc: Jonathan Cameron , devel@driverdev.osuosl.org, Lars-Peter Clausen , Michael Hennerich , linux-iio@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Peter Meerwald-Stadler , Hartmut Knaack Subject: Re: [PATCH 04/11] staging: iio: adt7316: fix handling of dac high resolution option Message-ID: <20181212082315.GI3116@kadam> References: <20181212005503.28054-1-jeremyfertic@gmail.com> <20181212005503.28054-5-jeremyfertic@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181212005503.28054-5-jeremyfertic@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9104 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=884 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812120074 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 11, 2018 at 05:54:56PM -0700, Jeremy Fertic wrote: > @@ -651,10 +649,12 @@ static ssize_t adt7316_store_da_high_resolution(struct device *dev, > u8 config3; > int ret; > > + if (chip->id == ID_ADT7318 || chip->id == ID_ADT7519) > + return -EPERM; return -EINVAL is more appropriate than -EPERM. regards, dan carpenter