Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1664181imu; Wed, 12 Dec 2018 02:03:33 -0800 (PST) X-Google-Smtp-Source: AFSGD/WjT1M3k121JIUGUQaUG4bsu/9kxHqeXuCo87bkO4zFnXz2APCB72l4fnwJm2OYIVfFWw3x X-Received: by 2002:a62:c3:: with SMTP id 186mr19444650pfa.24.1544609012984; Wed, 12 Dec 2018 02:03:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544609012; cv=none; d=google.com; s=arc-20160816; b=lqSeWlUc7HNpqUWznC2BcP0iXXA8xWloiQf571JULjBe5dmg0qpcNz2fniU8AE3U6u pPbia3c3Z3PnryTqi/MQPZpDptn6F6OAiNJfXjimh59OmU6dG6R12z2sqfEzULhPpYUP gie2xVJzdccHJ011uLiNEb9G73s549m9IKlLjlgws0f812ctJXgOF/jjCmCIfzK8bnax ynB9+SoKpDKJJ+qxBLsGDN4gpKZu97j9hVWWe/oRNNkSA3OMgpOKrETPzuuriYCIAF0u 2Ah6rUQT4WHjTgtexZnV9V4CIJkbFvTvmTfKVHicg36rBjHbAEiF22MbqlM4AxMwRpTV r4/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=PCMMGWyvPYrev9RR1m66VHnWBNlCo9exbcjAzzQ0GsY=; b=mTRIYYU2hwdh9PYEcDpSmVAeZ8rgDMT6opJQ0hB2DtrzjyxJaKGDHozMO1jyUaR7ol EA/ZiigqvcQPwTm9UK52PXeCkB562bYLMH3ddLVeK1YOhYiFrt00Y1mUnW2nRVzDvn1O Jf/KUKZhTZ33N87fPHfmTBEZ1n4sW9r6j36xjYLRu0aGfqGXgvD95gpKs3/j4ubhj7sE W6wVtdaqQ+CRJSsxotKNQ1kKfPZ9RAD5ALg+knglHBAxyiGmnRHviSJFjb2eWZyR+KVg 755yFDq5yywCRMV6VKMWcf/Xe/qkFEexIEI+EBrDXgrF2umdZDXojPYklkGVOiQDj3N7 iJWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=nmtX3NCI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 189si15251592pfd.142.2018.12.12.02.03.15; Wed, 12 Dec 2018 02:03:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=nmtX3NCI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726914AbeLLKAV (ORCPT + 99 others); Wed, 12 Dec 2018 05:00:21 -0500 Received: from mail-it1-f195.google.com ([209.85.166.195]:40306 "EHLO mail-it1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726598AbeLLKAV (ORCPT ); Wed, 12 Dec 2018 05:00:21 -0500 Received: by mail-it1-f195.google.com with SMTP id h193so8833373ita.5 for ; Wed, 12 Dec 2018 02:00:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=PCMMGWyvPYrev9RR1m66VHnWBNlCo9exbcjAzzQ0GsY=; b=nmtX3NCIJkrEYG3XiirWVUn3UXjltP3qD6QYKNVajpYBMBXqcQ70lUE/mkTTzSTjIs E3o2Vi/o0SKo/0xK66EVgDm1/FD8e3UGUc++D0y7pxgDG6LdxYBXxXi0WH2dHOD5X4By sExGCkwPqNW8qijjBlk4qFH3s8AH0E+AdYu6sSD6bqnudNZs82KWfvZnL88jo4tfYImw 4qXCruH0j3F7zg1BrLhbsjV6E0y9iNW4wJ0XYzAo2JrBytBqwhgdC9chcghQWHaUhyqp swF+Dr/MegyIiVL/JBuVh1eVQDFQ0G7U4/DYumw6I27cnwsjcQJbrv+YTMGt/SwHnPJV xKog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=PCMMGWyvPYrev9RR1m66VHnWBNlCo9exbcjAzzQ0GsY=; b=nxWPJyuYOQSPoGl3dDktypWwd8d2vYIbwRKMeQJahyp3pbPy2z1kXyePoW4rhIR07z 2ULTcUdURQZe2WaYtxSO20Q53LY5JBJAYkTV2XV4x/WiwiV3QBQWIks+LxKhz6syfrzz VaQnO4ON3m/eMYpnM8lsxA1P+xQJ+jaeCoP/QXAmajF7gt4chPKEjJD5oHmcusDJUWRr UaV6XKjrbVvQul+jtRwfIooBkKNn6HW4JlLEoBBBDXBzYura9EChrOO3VvE1Ti81TF9h JwkIcD7pQ52H1iuLHw+4Oz5Mjp1oJk2Kn+5zrQasdKVHts0pvnIjmuE0hE6VnD2XXGzo ouhg== X-Gm-Message-State: AA+aEWa/qJlZvR44GK7k9y0xutsRUL08d25pJRWqrh/c8F2e1PvX24Wz zIdqYyiKf9pX9xREKrYzBKqcXZuFqNQP4MHsdDnwlQ== X-Received: by 2002:a24:f14d:: with SMTP id q13mr4887004iti.166.1544608819792; Wed, 12 Dec 2018 02:00:19 -0800 (PST) MIME-Version: 1.0 References: <20181211133453.2835077-1-arnd@arndb.de> In-Reply-To: From: Dmitry Vyukov Date: Wed, 12 Dec 2018 11:00:08 +0100 Message-ID: Subject: Re: [PATCH] kasan: fix kasan_check_read/write definitions To: Alexander Potapenko Cc: Arnd Bergmann , Andrew Morton , Andrey Ryabinin , anders.roxell@linaro.org, Ard Biesheuvel , Will Deacon , Mark Rutland , Andrey Konovalov , Stephen Rothwell , kasan-dev , LKML , Linux-MM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 11, 2018 at 11:25 PM Alexander Potapenko wr= ote: > > > Building little-endian allmodconfig kernels on arm64 started failing > > > with the generated atomic.h implementation, since we now try to call > > > kasan helpers from the EFI stub: > > > > > > aarch64-linux-gnu-ld: drivers/firmware/efi/libstub/arm-stub.stub.o: i= n function `atomic_set': > > > include/generated/atomic-instrumented.h:44: undefined reference to `_= _efistub_kasan_check_write' > > > > > > I suspect that we get similar problems in other files that explicitly > > > disable KASAN for some reason but call atomic_t based helper function= s. > > > > > > We can fix this by checking the predefined __SANITIZE_ADDRESS__ macro > > > that the compiler sets instead of checking CONFIG_KASAN, but this in = turn > > > requires a small hack in mm/kasan/common.c so we do see the extern > > > declaration there instead of the inline function. > > > > > > Alexander, I think you are doing a similar thing for similar reasons > > in KMSAN patch (see KMSAN_CHECK_ATOMIC_PARAMS): > > https://github.com/google/kmsan/commit/17ebbfe19624c84adf79b0e5a74fd258= c49ff12b > > Namely, non-KMSAN-instrumented files must not get KMSAN callbacks from > > atomics too. > I'll need to double-check, but it occurs to me that we won't need > additional hooks for atomics in KMSAN - the compiler instrumentation > should suffice. Compiler asm instrumentation will only insert conservative initialization, but not checks of arguments, right? I mean these checks are optional in the sense that it's only false negatives, but since we already have them and they don't seem to lead to false positives, why do we want to remove them? > > Arnd patch does it the other way around: non-instrumented files need > > to opt-in instead of opt-out. > Shouldn't we put __SANITIZE_ADDRESS__ somewhere into mm/kasan/kasan.h the= n? > > Let's settle on a common way to do this, so that we can use it > > consistently across all tools. > > > > > > > > > Fixes: b1864b828644 ("locking/atomics: build atomic headers as requir= ed") > > > Reported-by: Anders Roxell > > > Signed-off-by: Arnd Bergmann > > > --- > > > include/linux/kasan-checks.h | 2 +- > > > mm/kasan/common.c | 2 ++ > > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/include/linux/kasan-checks.h b/include/linux/kasan-check= s.h > > > index d314150658a4..a61dc075e2ce 100644 > > > --- a/include/linux/kasan-checks.h > > > +++ b/include/linux/kasan-checks.h > > > @@ -2,7 +2,7 @@ > > > #ifndef _LINUX_KASAN_CHECKS_H > > > #define _LINUX_KASAN_CHECKS_H > > > > > > -#ifdef CONFIG_KASAN > > > +#if defined(__SANITIZE_ADDRESS__) || defined(__KASAN_INTERNAL) > > > void kasan_check_read(const volatile void *p, unsigned int size); > > > void kasan_check_write(const volatile void *p, unsigned int size); > > > #else > > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > > > index 03d5d1374ca7..51a7932c33a3 100644 > > > --- a/mm/kasan/common.c > > > +++ b/mm/kasan/common.c > > > @@ -14,6 +14,8 @@ > > > * > > > */ > > > > > > +#define __KASAN_INTERNAL > > > + > > > #include > > > #include > > > #include > > > -- > > > 2.20.0 > > > > > > > -- > Alexander Potapenko > Software Engineer > > Google Germany GmbH > Erika-Mann-Stra=C3=9Fe, 33 > 80636 M=C3=BCnchen > > Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg