Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1675233imu; Wed, 12 Dec 2018 02:16:11 -0800 (PST) X-Google-Smtp-Source: AFSGD/X6yYsRPXHNncWPPVU9zgS+P8dkCQQqLpcQYMpxFdn8HrbQXHXZOPC8iuQ6u3OVa4ZnWSFL X-Received: by 2002:a17:902:9a41:: with SMTP id x1mr19156162plv.126.1544609771587; Wed, 12 Dec 2018 02:16:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544609771; cv=none; d=google.com; s=arc-20160816; b=Vn943SS0wJbNbwEXnzmkark8kIVEFfcRldqM+mMvs5XzcuWqX5bFmIuS4Vmk+PUrDH UGZ9tGmlZkhZGCZF+KKRO4qcAFqDMsVxzhTJ7u4fYoxbDVVE1dZDcEivpKU3gG49qanh pKNsQX3Ly4zjPopeWO+kaRDhgT6CiL7T0RGvUDjBAg8hTzMvzRwgrFCRVdfqZbpEfyV3 Ov3V9IMmyn2bzdSQVbYDAkJ6rSaE0TTwhj+12PpfjXYPQ3qRGY2Q5iMWTLy4bJvwWAKc +q4rur7k1BnpgYcLWmqC90CviZ7MVebyel3yXJdymkXRXuV5a1gf3YyCVnKZak64Ts10 ILtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=VJm/Y1hnNh1M9jMLJdPmW6EIKjp/TYee0rwHCpIaCfs=; b=AWu38F7GozWgWqoj8+4PznNm/prnCPwYF3GyQLVgdwdiKLS8c6w2fczJBqn+q8h/OA plcCFRMQChsLCihxGz7lZONFi7ej45h1dhn0xdoMo9Yqf/R3SHhy10mYIWPAOQuvJzYe OZPR4/E2Kp0QS9YBjtDfPkqSVebyOnbSRbas2EPU71aZ2CkUjyKx3CMnBP7DOrjw7qt8 sEduL2h5reA01dyqHChpy1P076fqSCR9QoaDKq9VdBxDlzRnioAbLGBrMEj/r8h4lfAU COzPC/4GmXqp0XoT4PmYmLKH9CidFbmsGf7i/uN7BwTFwV18RP8rZT6L0XZlCe+egd2q mndg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d77si15537620pfj.124.2018.12.12.02.15.54; Wed, 12 Dec 2018 02:16:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727029AbeLLKOy (ORCPT + 99 others); Wed, 12 Dec 2018 05:14:54 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:37324 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726681AbeLLKOx (ORCPT ); Wed, 12 Dec 2018 05:14:53 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6E020EBD; Wed, 12 Dec 2018 02:14:53 -0800 (PST) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.113]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A13263F575; Wed, 12 Dec 2018 02:14:51 -0800 (PST) Date: Wed, 12 Dec 2018 10:14:49 +0000 From: Catalin Marinas To: Prateek Patel Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-tegra@vger.kernel.org, snikam@nvidia.com, vdumpa@nvidia.com, talho@nvidia.com, swarren@nvidia.com, treding@nvidia.com Subject: Re: [PATCH V2] kmemleak: Add config to select auto scan Message-ID: <20181212101448.GA65138@arrakis.emea.arm.com> References: <1540231723-7087-1-git-send-email-prpatel@nvidia.com> <20181029104320.GC168424@arrakis.emea.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 12, 2018 at 12:14:29PM +0530, Prateek Patel wrote: > On 10/29/2018 4:13 PM, Catalin Marinas wrote: > > On Mon, Oct 22, 2018 at 11:38:43PM +0530, Prateek Patel wrote: > > > From: Sri Krishna chowdary > > > > > > Kmemleak scan can be cpu intensive and can stall user tasks at times. > > > To prevent this, add config DEBUG_KMEMLEAK_AUTO_SCAN to enable/disable > > > auto scan on boot up. > > > Also protect first_run with DEBUG_KMEMLEAK_AUTO_SCAN as this is meant > > > for only first automatic scan. > > > > > > Signed-off-by: Sri Krishna chowdary > > > Signed-off-by: Sachin Nikam > > > Signed-off-by: Prateek > > Looks fine to me. > > > > Reviewed-by: Catalin Marinas > > Can you mark this patch as acknowledged so that it can be picked up by the > maintainer. I thought Reviewed-by was sufficient. Anyway: Acked-by: Catalin Marinas