Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1682891imu; Wed, 12 Dec 2018 02:25:54 -0800 (PST) X-Google-Smtp-Source: AFSGD/WblSxUFJJ21gRg9Tfn/k2yjLBsT29bUiybuJpOcLKXYraDraZlWvu6Gt7qk6BXO5+7Sjq7 X-Received: by 2002:a17:902:b592:: with SMTP id a18mr19316350pls.293.1544610354591; Wed, 12 Dec 2018 02:25:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544610354; cv=none; d=google.com; s=arc-20160816; b=PlugDpAbuSZqrddX/svSKzaYPZZT/H2cEcJ+KLInj19bBXE8DoYIGzGbYkS5QEz+MF ThwSmMrkAVEmgkUxlJ8t+l8E3du2cP0kHuiZNyBpeJTG3MtMREyLO8fhnP2Va0ZwmHki 3wMXNNBRfhZ1Qz0aFFCDxTppxR5QV10olrwQQo8VohBJ+hv5K7qKruYt6M/Q+tG8zCTT QmfqV5GVmed7nysx9Z5fPp5cl6ccgBbyWhOhdCVeGgdKLJmNbKjCiTS1NuNXwdaeGR1l +t3vfKrt1wZ/oP3fjHx7ICvbX6DPCIGuIiDEuuke4MKzbYH5Ks740U+BR97OwZdgZKWA LPcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=qVM1gE/tR9Jlka2AiuoPYJdY3YJ0y0JEW165R1Cr6DE=; b=en8c3qjvbtpKk/KnjukTS9NEvrGg3nJHCO6zb3qeUMGfRU5icTkEI2IqFsYomzWWRU As2TjRk3uHSxhANvDlG9CXTIjHAmFzaF/gbI1CP6o0QOOjM/3fR0yZjQB6XR5kSa3y04 Z+sn51THJErc9gFWPXoKd4PEqmeeFB1imkgwP6pP/palM+wAVoJGmn/y1kMH9d+siBWe YkxZQl9FYYc9XGM2KmkyMhCJprCo4LFsu5EcKWC6ttTtaE1Vl9ONl+F/WWxZtL3neyNY n8yTBYKssYfTu6ajebSOJnstBPewHRhtWzj8OzE6XTqhTbVlxXfSJ/YReqi0GuFXuKOY ysDQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c3si14637237pls.73.2018.12.12.02.25.39; Wed, 12 Dec 2018 02:25:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727091AbeLLKV5 (ORCPT + 99 others); Wed, 12 Dec 2018 05:21:57 -0500 Received: from mail.bootlin.com ([62.4.15.54]:57438 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726727AbeLLKV4 (ORCPT ); Wed, 12 Dec 2018 05:21:56 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 921D720DBC; Wed, 12 Dec 2018 11:21:53 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.2 Received: from localhost.localdomain (aaubervilliers-681-1-89-7.w90-88.abo.wanadoo.fr [90.88.30.7]) by mail.bootlin.com (Postfix) with ESMTPSA id 2517620733; Wed, 12 Dec 2018 11:21:43 +0100 (CET) From: Miquel Raynal To: Gregory Clement , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , Bjorn Helgaas Cc: , Rob Herring , Mark Rutland , Lorenzo Pieralisi , linux-pci@vger.kernel.org, , , Antoine Tenart , Maxime Chevallier , Nadav Haklai , Miquel Raynal Subject: [PATCH v2 00/12] Bring suspend to RAM support to PCIe Aardvark driver Date: Wed, 12 Dec 2018 11:21:30 +0100 Message-Id: <20181212102142.16053-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, As part of an effort to bring suspend to RAM support to Armada 3700 SoCs (main target: ESPRESSObin), this series handles the work around the PCIe IP. First, more configuration is done in the 'setup' helper as inspired from the U-Boot driver. This is needed to entirely initialize the IP during future resume operation (patch 1). Then, reset GPIO, PHY and clock support are introduced (patch 2-4). As current device trees do not provide the corresponding properties, not finding one of these properties is not an error and just produces a warning. However, if the property is present, an error during PHY initialization will fail the probe of the driver. Note: To be sure the clock will be resumed before this driver, a first series adding links between clocks and consumers has been submitted, see [1]. Anyway, having the clock series applied first is not needed. Patch 5 adds suspend/resume hooks, re-using all the above. Finally, bindings and device trees are updated to reflect the hardware (patch 6-12). While the clock depends on the SoC, the reset GPIO and the PHY depends on the board so the clock is added in the armada-37xx.dtsi file while the two other properties are added in armada-3720-espressobin.dts. [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-November/614527.html Thanks, Miquèl Changes since v1: ================= * Change the capitalization in commit titles to follow the PCI subsystem rules. * Added Suggested-by tag to the patch adding PHY support and to the patch adding the PHY property in the DT. * Added Rob's Reviewed-by tags on bindings. * I am following the discussion about calling functions that might sleep in a NOIRQ context. As there is no real problem yet (as per my understanding), I did not change anything on this regard. Miquel Raynal (12): PCI: aardvark: Configure more registers in the configuration helper PCI: aardvark: Add reset GPIO support PCI: aardvark: Add PHY support PCI: aardvark: Add clock support PCI: aardvark: Add suspend to RAM support dt-bindings: PCI: aardvark: Describe the reset-gpios property dt-bindings: PCI: aardvark: Describe the clocks property dt-bindings: PCI: aardvark: Describe the PHY property ARM64: dts: marvell: armada-37xx: declare PCIe reset pin ARM64: dts: marvell: armada-3720-espressobin: declare PCIe reset GPIO ARM64: dts: marvell: armada-37xx: declare PCIe clock ARM64: dts: marvell: armada-3720-espressobin: declare PCIe PHY .../devicetree/bindings/pci/aardvark-pci.txt | 9 + .../dts/marvell/armada-3720-espressobin.dts | 4 + arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 5 + drivers/pci/controller/pci-aardvark.c | 214 ++++++++++++++++++ 4 files changed, 232 insertions(+) -- 2.19.1