Message-ID: <400DB46D.67E852D9@us.ibm.com>
Date: Tue, 20 Jan 2004 15:06:21 -0800
From: Jim Keniston <jkenisto@us.ibm.com>
MIME-Version: 1.0
To: Rask Ingemann Lambertsen <rask@sygehus.dk>
CC: LKML <linux-kernel@vger.kernel.org>, netdev <netdev@oss.sgi.com>,
       Jeff Garzik <jgarzik@pobox.com>, Andrew Morton <akpm@osdl.org>,
       "Feldman, Scott" <scott.feldman@intel.com>,
       Larry Kessler <kessler@us.ibm.com>
Subject: Re: [PATCH 2.6.1] Net device error logging
References: <400C3D3E.BFCC25CE@us.ibm.com> <20040120195122.A1087@sygehus.dk>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1222
Lines: 31

Rask Ingemann Lambertsen wrote:
> 
> On Mon, Jan 19, 2004 at 12:25:34PM -0800, Jim Keniston wrote:
> > The enclosed patch implements the netdev_* error-logging macros for
> > network drivers.  These macros have been discussed at length on the
> > linux-kernel and linux-netdev lists.  All issues that reviewers have
> > raised were addressed previously.  This is just an update for v2.6.1.
> 
> How about a message rate limit?
> 
> --
> Regards,
> Rask Ingemann Lambertsen

Thanks.  We considered adding a ratelimit flag to the netdev_printk arg
list.  It was pointed out that
(1) rate-limiting is necessary for a relatively small subset of messages;
and
(2) the NETIF_MSG_* flags are already designed to be used in order of
increasing verbosity.  If the user selects the more verbose class of
messages, then rate-limiting may not be appropriate.

I concluded that ratelimit() should continue to be used on a case-by-case
basis, and not folded into netdev_printk.

Jim Keniston
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/