Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1715025imu; Wed, 12 Dec 2018 03:05:57 -0800 (PST) X-Google-Smtp-Source: AFSGD/WMVUC1waXqYyICfz0LB9BXXeOTlswqX4s3WudcOJ0Tqbp8kTFwe2DzHzpbHFZ9AJoKoU8m X-Received: by 2002:a17:902:887:: with SMTP id 7mr19303545pll.164.1544612757727; Wed, 12 Dec 2018 03:05:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544612757; cv=none; d=google.com; s=arc-20160816; b=hfyJm0OUmzbhk5UPMrhskhZHEpcYinyrTxP9bViDQqSOoEjQN/X2X6375IZXQokCjj XcXpG5MkgRXpRURa2MuGjsljNHiwftWagP4ADX3YlfMNALWxdUC5iTOYvOzz6D8sd16K IIpnSe62R3g7ECzDQD2lwPEXmRU41jSkb2oKHgDmb/aXB6ZPnHLCKLYbv60oUtaBMZQU v9egDRbBPyLBO3CuaCvvxJfgq+WK5heEWVitMuO4GD8FBTWt+u7HFibPEatg6Xgsxq6A ce8z6Y0CTpCAWSwtqr2XQZhFBjKicRJ1Em/cVCrQqQazi0MtlKKHf1SDnQ1HdETUJhqr PKiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5puUIqv68BpjaXAYQRT+asUv3L5BdypDkUfrXMFeT4I=; b=qpsEW5HhvJw9nEtS/9METZX/1Gw6OyYtx/2Bys0hRwMzm7Kx6Al0rqNofX7GakmqpK e7Mouysm9lRuHyT5liNYpqVHjyTgxhalpraWXuiXrVL4FR+6uAByOierlrgn6qqcibaa 8yOAdfFxbi3ws9Sl/TSXlHXToguFRjOZLhqF88utM1raIICBjFsh28GyJ8GCgEeAZKMP 796zfytYWOdQ3xmpPeyYlmxJ6Yzd0necikj2QBqQlyebsbt1UaDXKmhOrPKlkip4w+aH W0Mdh3yJKYQ4q1Ebpj1em2Eqk2bw4LP9ylXhYr5/WFNkpxHPV+YUD103tzuRseLbhHn1 Pasw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0D7xqUgt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y188si15527710pfb.59.2018.12.12.03.05.43; Wed, 12 Dec 2018 03:05:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0D7xqUgt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727344AbeLLLEj (ORCPT + 99 others); Wed, 12 Dec 2018 06:04:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:40906 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727310AbeLLLEi (ORCPT ); Wed, 12 Dec 2018 06:04:38 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC2062086D; Wed, 12 Dec 2018 11:04:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544612677; bh=NKajZ9vE+sC+5xLK302X1D51k7iZ5DvyIXoormARi64=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0D7xqUgtHSFzxDbqnoUbWU+/3WTc+JYaKeQJTHbL0IIvY/hSQGdzQ9I6+vfMycaWT jDnxa/RryGqmI0HfI/WwgvAa6SdvSNVnBmJm6wq805O90WCOejwkhKhxOMQPB3qdi9 Jk58aH1WgmQloekfCLQ1Yvxk2S70hu++LXeMnqEQ= Date: Wed, 12 Dec 2018 12:04:35 +0100 From: Greg Kroah-Hartman To: Joerg Roedel Cc: iommu@lists.linux-foundation.org, Russell Currey , Sam Bobroff , oohall@gmail.com, Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Dan Williams , Vinod Koul , jroedel@suse.de, Mathias Nyman , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, dmaengine@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 1/6] driver core: Introduce device_iommu_mapped() function Message-ID: <20181212110435.GC1990@kroah.com> References: <20181211134343.10664-1-joro@8bytes.org> <20181211134343.10664-2-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181211134343.10664-2-joro@8bytes.org> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 11, 2018 at 02:43:38PM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > Some places in the kernel check the iommu_group pointer in > 'struct device' in order to find ot whether a device is > mapped by an IOMMU. > > This is not good way to make this check, as the pointer will > be moved to 'struct dev_iommu_data'. This way to make the > check is also not very readable. > > Introduce an explicit function to perform this check. > > Cc: Greg Kroah-Hartman > Acked-by: Greg Kroah-Hartman No need to have a cc: line if I have already acked it :) thanks, greg k-h