Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1744947imu; Wed, 12 Dec 2018 03:39:14 -0800 (PST) X-Google-Smtp-Source: AFSGD/WW+HnNUdm+476Xj4wjw470AcbQdTaGD+3lScxTih7ryHW7F0J7ass4S/hru8aUUhl7yOFF X-Received: by 2002:a63:2109:: with SMTP id h9mr17896111pgh.277.1544614754905; Wed, 12 Dec 2018 03:39:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544614754; cv=none; d=google.com; s=arc-20160816; b=Sas9h1n0AMv5NuBGnl17ZjW8rdNbcV1IMg6S6Inz/I7T6+LRd4jJBo04/ociREPOxU BS7MJdLOaZYBIt7/ZfciaXzarQh5WqPY2EXq5gBP6+IJOib9RJKR1ZKQAHYIXMxriZC9 8fv83mc/r75PEFyyW/2BmeosYpuzTGmrSKrXjRdIxRonDj9Wu0yZtY8aVUxYx+c3IqNw TJSupIdq1sb2weGOwv3lVsNSFNTFc9cQWj1YXJL2176LXleHhVGurpXVX6Lnid8g9C6h fpWgyI77kBE56Sy1fzxlJPcCAAhOG97c2AIRQySNzuaykKXsMJ9s+Gu6I0caql7CQFT6 /jAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=FdZ6qedKQQ3HTzMU9RdDcAWPVjtVX8DUMJj9Fsv2TM8=; b=C5RRIQAswQeaG5p9cEEqeGhnKLC6CvyzbcCaN45a9kaedanQofErn1vn3znhf+EWPW cI9USlsqjgtpNO6oyWcAUYY0O2R6dNazdboUgwWM3tZw3EhDfsZdvLXPR10jvoMMddLw k0jMLhkwbgKwx9Vb2BtPiYwk9DqQ50ocKqCf5ydme26FT/5q4w/CtX/5E9V5yYzCnLLP ZNRkKhm/WwjwKKdaURDIU9GiWeH7KY2mvM/oLcvCZskXNDR2lV6JDpsFIIWPSK0Aj5L4 qAh4BmHeomFnc2YSLKNPJFy3fgUHkzMD7fttrQtpnKq+T57GlKuBZrtBpeocUvZg0Td1 jm4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YDDqDFw0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 32si15158638plg.29.2018.12.12.03.38.34; Wed, 12 Dec 2018 03:39:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YDDqDFw0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727161AbeLLLhM (ORCPT + 99 others); Wed, 12 Dec 2018 06:37:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:51140 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726869AbeLLLhM (ORCPT ); Wed, 12 Dec 2018 06:37:12 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 33A2A2086D; Wed, 12 Dec 2018 11:37:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544614631; bh=6FUgvVDCpisbOfkkhZSv0C5+WSRbMvWrDVg+/rvkl+E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YDDqDFw0GWa/ZyEkdqSMdmBFNFj+0UYVMWEB9OWFuEh9Pc3sNms+8/biE1oPmarsr JPlYMemnNRZmInSHKnsH8ep3QNGKlBZngVwSG0i59Z2IcQ/wvLH83g8nJr+1z7OmJf 58lhi7NHXY4E5z+23NXlc+qmOL4KUxu6O/FuYzp0= Date: Wed, 12 Dec 2018 12:37:09 +0100 From: Greg Kroah-Hartman To: Kyle Williams Cc: linux-kernel@vger.kernel.org, Alan Stern , Mathias Nyman , Nicolas Boichat , Jon Flatley , Felipe Balbi , linux-usb@vger.kernel.org Subject: Re: [PATCH v3 1/2] USB: quirks: Check device interface LPM capability Message-ID: <20181212113709.GA20058@kroah.com> References: <20181205093902.GA18633@kroah.com> <20181208014724.951-1-kdgwill@google.com> <20181208014724.951-2-kdgwill@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181208014724.951-2-kdgwill@google.com> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 07, 2018 at 08:47:21PM -0500, Kyle Williams wrote: > From: Kyle Williams > > Description: enable the ability to disable LPM for all devices matched > by interface information Why have "Description:" in here? Of course this is the description :) And the subject doesn't make much sense, what does this have to do with quirks? Also, you need more information here in the description about why you are doing all of this, as it is, I have no idea why this patch is needed at all. thanks, greg k-h