Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1906020imu; Wed, 12 Dec 2018 06:24:07 -0800 (PST) X-Google-Smtp-Source: AFSGD/W8YmXikq6zwj1yduitPRzmL3Y9MS2GnAnsZUt+B4R/6rfYy1tHndDZaI8w5nsNKoOJIPzl X-Received: by 2002:a63:dc0c:: with SMTP id s12mr18662199pgg.398.1544624647062; Wed, 12 Dec 2018 06:24:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544624647; cv=none; d=google.com; s=arc-20160816; b=c0zxje+wII90paiEegy6p8d3gqbWB7fMSmPb/FiD5rAcoTQyu1XbTBfsyuz7Yu5ebB QkqLwBUkB2ZELIVoEn7M9uMG88RIoeFD+Xu4pJsgwmtDEWK3pYhjopOcaFwB+AWTpccF 4UsFB4IwJNl2EzDlBDYx0nu4TTQwP/m+ADANNiIzpqG3vI0Ju+zQ0RGx4BkuDHxmEIT4 MQ4zzjlrM75oBnuUkHCZuAsCuFRZ4QuF5KrqI7xyX5UgeKO9G3gLcExzdWjZjpyXowbL 7oDCivY0lqqpiAIC3WAaCNbyKtHHyO9NuXCFKnuEd0Kh2e08XjsWJFrbt8rcXzF7hnbo NsuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=yE9wiRmjv1uHPZ2K9oRp4y3eWG/OAmunmWp1XeRZ/qI=; b=kd3D9XVbLe+Lw60ztmXV74Y/hp1S8yTloHjh48JtQLn6XPO1UYd5aaCLV5c5igwpEA Y5loP4KBSrh14ffAvTUuiRQ/V4ThFL3Rl8WR8aTHtmecMYvtKEPREMAwaxserG5PGdMs 2mGnpOGkPnoO5m/SNrendpVNMtEnUMOXmW0asskRy6lodrPxI1Iuy2nsIyxYZu5BSLJz O3QBYtNQSfSnWt5IgGIfoLPKpXIgeDmtlx4slRmW2AJMWp150FUgjYcmXkKklJghRZRk lDvzLtn0iCurpOK7WHofWoIEl9aX3N00O5mdr7A46k57JhILYkAfNDPHEkFmHsTbI25x 4oKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cirrus.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p4si15927577pli.432.2018.12.12.06.23.50; Wed, 12 Dec 2018 06:24:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726989AbeLLOWk (ORCPT + 99 others); Wed, 12 Dec 2018 09:22:40 -0500 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:51342 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726245AbeLLOWj (ORCPT ); Wed, 12 Dec 2018 09:22:39 -0500 Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id wBCEF1gl010042; Wed, 12 Dec 2018 08:22:35 -0600 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from mail4.cirrus.com ([87.246.98.35]) by mx0a-001ae601.pphosted.com with ESMTP id 2p8c86pppj-1; Wed, 12 Dec 2018 08:22:35 -0600 Received: from EX17.ad.cirrus.com (unknown [172.20.9.81]) by mail4.cirrus.com (Postfix) with ESMTP id C19C0611C8B5; Wed, 12 Dec 2018 08:26:18 -0600 (CST) Received: from imbe.wolfsonmicro.main (198.61.95.81) by EX17.ad.cirrus.com (172.20.9.81) with Microsoft SMTP Server id 14.3.408.0; Wed, 12 Dec 2018 14:22:34 +0000 Received: from imbe.wolfsonmicro.main (imbe.wolfsonmicro.main [198.61.95.81]) by imbe.wolfsonmicro.main (8.14.4/8.14.4) with ESMTP id wBCEMYH2008561; Wed, 12 Dec 2018 14:22:34 GMT Date: Wed, 12 Dec 2018 14:22:34 +0000 From: Charles Keepax To: Linus Walleij CC: Liam Girdwood , Mark Brown , , Bartosz Golaszewski Subject: Re: [PATCH 1/2] regulator: wm8994: Rely on core to handle GPIO descriptor Message-ID: <20181212142234.GP16508@imbe.wolfsonmicro.main> References: <20181211095319.11393-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20181211095319.11393-1-linus.walleij@linaro.org> User-Agent: Mutt/1.5.20 (2009-12-10) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=602 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812120125 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 11, 2018 at 10:53:18AM +0100, Linus Walleij wrote: > After making sure that the regulator core always take over > handling of the GPIO descriptors, the gpiod_put() > on the errorpath of the wm8994 driver becomes redundant. > > Reported-by: Charles Keepax > Signed-off-by: Linus Walleij > --- Acked-by: Charles Keepax Thanks, Charles