Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1906617imu; Wed, 12 Dec 2018 06:24:44 -0800 (PST) X-Google-Smtp-Source: AFSGD/VwmM+ZsoKNU7XugNrpRSXJJ14y1RT9skIAb6IEPd+2Y8g5/jT9IAMBOaIJ38bGGJXf3bkx X-Received: by 2002:a62:8e19:: with SMTP id k25mr20393373pfe.185.1544624684268; Wed, 12 Dec 2018 06:24:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544624684; cv=none; d=google.com; s=arc-20160816; b=l8uQgBhJmgMvBn2/uvfCSfSEilYDsVo0Gw4oS4APfDdLvFUxWFxI97zFiyTI07gy1r P1DO9PLfyf6vl9L6QmJyD3arTYq4DpOPFqUAiqedOcOX3yqQUMVhx9RZbozIUjGN+0/F 0uaxefgLTSfQHKwlkz4bnxhuZjK9nLpyw9BGShW8Vh4Rn3ZjzNQoXwwpqvX3OwxPh/wO Jx6Ej0jTnZigCPFrE8YzA7CCaoIo5XN5VJ75nnLZt78gt5MGHkzkvz3zLhenQR+F5t5u XAwtSJvhYsL6iV+rX4jF55pNjD4gTLy80s6FHdjQ7Nw75T6CHrJCsSMgZMHsYXjvwJae n75w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=RzHQ0f3GcdxAy+S43Sh65JdXz7jkPefQiffXyRcstYQ=; b=WuLyWCYYtCg04kOkqzITW9OC6ArA4EWrkwajjiXdGgmV4AXx8YbNZLrAr9ScKtZ1Pk pIjvQb+FVHj+1bcqpovWGjJOqgWK70Fdp43uwPso37JQnx4ecgDUTXvO9beZRE6Qt/ms qYkpcubGibVk1isiqQfbwGqwIL3Dxmn2pPHd28lqD68AVFc7U6pftnnKLhyMMIf5x6v7 3lW48CIhfoCC1w7AWeWs6BgkVKN614NEu6iTag/ZlRQeLJwosgvAbihp/D/sbx668R6d jhQI1OP1Txoam4IAHYESTQ8mJ/KLkpSJOVdeukvdXRsXudUS8Q8mhbEbcbWXZ5oWNXFJ IuNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cirrus.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t1si14397257pgj.542.2018.12.12.06.24.29; Wed, 12 Dec 2018 06:24:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727279AbeLLOXK (ORCPT + 99 others); Wed, 12 Dec 2018 09:23:10 -0500 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:43900 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726232AbeLLOXJ (ORCPT ); Wed, 12 Dec 2018 09:23:09 -0500 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id wBCEETqa022943; Wed, 12 Dec 2018 08:23:03 -0600 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from mail1.cirrus.com (mail1.cirrus.com [141.131.3.20]) by mx0b-001ae601.pphosted.com with ESMTP id 2p8b8vxnq8-1; Wed, 12 Dec 2018 08:23:03 -0600 Received: from EX17.ad.cirrus.com (unknown [172.20.9.81]) by mail1.cirrus.com (Postfix) with ESMTP id D779E611C8AB; Wed, 12 Dec 2018 08:23:02 -0600 (CST) Received: from imbe.wolfsonmicro.main (198.61.95.81) by EX17.ad.cirrus.com (172.20.9.81) with Microsoft SMTP Server id 14.3.408.0; Wed, 12 Dec 2018 14:23:02 +0000 Received: from imbe.wolfsonmicro.main (imbe.wolfsonmicro.main [198.61.95.81]) by imbe.wolfsonmicro.main (8.14.4/8.14.4) with ESMTP id wBCEN2hV008597; Wed, 12 Dec 2018 14:23:02 GMT Date: Wed, 12 Dec 2018 14:23:02 +0000 From: Charles Keepax To: Linus Walleij CC: Liam Girdwood , Mark Brown , , Bartosz Golaszewski Subject: Re: [PATCH 2/2] regulator: arizona-ldo1: Rely on core to handle GPIO descriptor Message-ID: <20181212142302.GQ16508@imbe.wolfsonmicro.main> References: <20181211095319.11393-1-linus.walleij@linaro.org> <20181211095319.11393-2-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20181211095319.11393-2-linus.walleij@linaro.org> User-Agent: Mutt/1.5.20 (2009-12-10) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=521 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812120125 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 11, 2018 at 10:53:19AM +0100, Linus Walleij wrote: > After making sure that the regulator core always take over > handling of the GPIO descriptors, the gpiod_put() > on the errorpath of the Arizona LDO1 driver becomes > redundant. > > Reported-by: Charles Keepax > Signed-off-by: Linus Walleij > --- Acked-by: Charles Keepax Thanks, Charles