Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1978763imu; Wed, 12 Dec 2018 07:33:30 -0800 (PST) X-Google-Smtp-Source: AFSGD/VATSezBFsXnr19qP2VYWgUNm3hGN5XpoKPK8YSQdbmMNrCMVC/UhaVe8sGFR8FvLifSX85 X-Received: by 2002:a63:a611:: with SMTP id t17mr18373008pge.338.1544628810190; Wed, 12 Dec 2018 07:33:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544628810; cv=none; d=google.com; s=arc-20160816; b=MwClw71DDeCzjDzNYCXwxWPOgJUlE1XFU+9gJsGvEvKVE9NoTcigInaggtxG9+ToPI C5+tvxpTcgMQChPdfnFXtUisPqp6rrPtHI0UkRcWV1hOfdr14DF5eusHVUVTlw64QVUf 5DsMTdQa264RYmPEEpYDiQy09T/59UhsDxLu5n41d+BBXQudRAhbEKU1HSOutnaKjKE3 CFYJyKycwj5gSLTi9/V0un3O5Vj3aKl9lDtMw91RsVXoMGFFz4kzZEL/WSKDT6STiTSo 9qftfTWrgLVyKxOYsnjjd2DKH/dtwuHByXGfWziWW9Uvxrics/HdUKIZ6gnxt0D5wCeV fvZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:organization:subject:cc:to:from:date :content-transfer-encoding:mime-version; bh=JHuIi4OXuWbPmQfwuP3S0vGQm2drN1rvW70jGN6qDqI=; b=VLhBJ3x/9wXJTU19LXmhUZ/9dISrYcde+IJmAssRdJJRdyucrVtywcHDbE9g/Xama0 gkOnQNGxodmeRLFU3ADxDENm0H+S+UP147f0cH65/6pfp/lDovlaC/Kq3PyvBBkuWU1t L5a88kjV6fQ+WwDhbppyWkqyuYatKEP2WMttkmKIx4EISCYly1zlPpRd2nTFAfEZIj7S siauHWZgIbm/BdG/EkO79Q1Nu6KgxZADkfJke8pEzQNCNGGpuxhoeoPDLgga0NNi7stE oFIYH2Ca5glgl+82YOs7hBDNbdLfDM3V1byrQ1UZH8C+DlVlra9UZ0tln3xD79PaLC35 bMyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d36si15552454pla.216.2018.12.12.07.33.14; Wed, 12 Dec 2018 07:33:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727756AbeLLPcA (ORCPT + 99 others); Wed, 12 Dec 2018 10:32:00 -0500 Received: from mx2.suse.de ([195.135.220.15]:38998 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726281AbeLLPcA (ORCPT ); Wed, 12 Dec 2018 10:32:00 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 85BA5AF97; Wed, 12 Dec 2018 15:31:58 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 12 Dec 2018 07:31:55 -0800 From: Davidlohr Bueso To: Prateek Sood Cc: peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org, sramana@codeaurora.org Subject: Re: [PATCH] percpu_rwsem: fix missed wakeup due to reordering of load Organization: SUSE Labs In-Reply-To: References: <1543590656-7157-1-git-send-email-prsood@codeaurora.org> <734eb2ec2c3aeba1c4d054c1fceacef1@suse.de> <7803e498-5fc8-9b72-3e1b-76005f7673a3@codeaurora.org> Message-ID: X-Sender: dbueso@suse.de User-Agent: Roundcube Webmail Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-12-12 06:26, Prateek Sood wrote: > Please confirm if the suspicion of smp_rmb is correct. > IMO, it should be smp_mb() translating to dmb ish. Feel free to add my ack. This should also be Cc to stable as of v4.11. Fixes: 8f95c90ceb54 (sched/wait, RCU: Introduce rcuwait machinery) Thanks, Davidlohr