Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2067656imu; Wed, 12 Dec 2018 09:00:17 -0800 (PST) X-Google-Smtp-Source: AFSGD/WLIvfp1UwefjXo6c6bQQWy5DpluJHu6uHQ7KzlhZeeFp5cPa7yStPyzH5D6sTyvvePNS0m X-Received: by 2002:a63:f615:: with SMTP id m21mr19303433pgh.428.1544634017509; Wed, 12 Dec 2018 09:00:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544634017; cv=none; d=google.com; s=arc-20160816; b=fZJFTJ24iiP7qWYPOBRM0cTZsJ3Wb6V1tqlAIExFXdo9sTI5/utcm8cp5fxG4fDLwK q2MVZz3Eha5FL62E3nKZRToWgSySQW1yfzYrGa3HMBbVHQ259VwCsXrxUPuMwYzDD8DC Q02vQZotnompUEGvBHK3ro7D4GVjA8ZDIXMRApz1V5HMjkkRoMFttuWBP/s8uOM1Mj26 sGp5RgWGK7tSekk9csonO7aW/dyiAsGttAIMm17KUb1JZSSom/bewKu8s4qM22p0BFUn CdTpv76pndf/62CCGpJVw4KkE8Q1LytxLTu+EEBFT0jSDFrGIOC256AFEJxuqoVTWjXB gdyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=8P8VE9vAtRnt72SgseIrehb47PTE7fSqgrgUMnHmQh0=; b=PCCnuYjs3saFiEKTsdo5IXNxWJ4NJV4A3EPHODNGnFVoautwTHn618Nne0O/p/D6uO SiH+hcIkzD0/LdgXAGbQ702HqLL+Dq3Rg+tkyeoUask1CKY4fobF5M8ViIEFFQfbyQnr bPfYZg/XTvfdNnhwcKvE8VG9UxRsahZ2bT9fyEQPSwp0wxqWUZQs3mdWl2yVWrrZNZX5 cjq5hqDoSmLv3mro9qT77ZkFv8XD/aU8to24y0s0db13Nu+nUh8l5ysYTWlE9FVRsiO2 iIVFLps07LRzKerNNbWNdr55eRK6P8+3toN5oFfA2QYwJmamvCjiPbKmJ9eaYBd0Kunf Q7PQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t10si14477842pgn.551.2018.12.12.09.00.01; Wed, 12 Dec 2018 09:00:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727938AbeLLQ7J (ORCPT + 99 others); Wed, 12 Dec 2018 11:59:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47360 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727845AbeLLQ7J (ORCPT ); Wed, 12 Dec 2018 11:59:09 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 331CE89AD3; Wed, 12 Dec 2018 16:59:09 +0000 (UTC) Received: from jtoppins.rdu.csb (ovpn-122-101.rdu2.redhat.com [10.10.122.101]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9C61160C44; Wed, 12 Dec 2018 16:59:08 +0000 (UTC) From: Jonathan Toppins To: netdev@vger.kernel.org Cc: michael.chan@broadcom.com, "David S. Miller" , linux-kernel@vger.kernel.org Subject: [PATCH net-next] bnxt: remove printing of hwrm message Date: Wed, 12 Dec 2018 11:58:51 -0500 Message-Id: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 12 Dec 2018 16:59:09 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org bnxt_en 0000:19:00.0 (unregistered net_device) (uninitialized): hwrm req_type 0x190 seq id 0x6 error 0xffff The message above is commonly seen when a newer driver is used on hardware with older firmware. The issue is this message means nothing to anyone except Broadcom. Remove the message to not confuse users as this message is really not very informative. Signed-off-by: Jonathan Toppins --- Notes: v2: include changes recommended by Michael Chan drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 5d21c14853ac..f4f29939ba72 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -6190,7 +6190,8 @@ int bnxt_hwrm_func_resc_qcaps(struct bnxt *bp, bool all) req.fid = cpu_to_le16(0xffff); mutex_lock(&bp->hwrm_cmd_lock); - rc = _hwrm_send_message(bp, &req, sizeof(req), HWRM_CMD_TIMEOUT); + rc = _hwrm_send_message_silent(bp, &req, sizeof(req), + HWRM_CMD_TIMEOUT); if (rc) { rc = -EIO; goto hwrm_func_resc_qcaps_exit; -- 2.16.4