Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     "Matwey V. Kornilov" <matwey@sai.msu.ru>
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        matwey.kornilov@gmail.com, tfiga@chromium.org,
        stern@rowland.harvard.edu, ezequiel@collabora.com,
        hdegoede@redhat.com, hverkuil@xs4all.nl, mchehab@kernel.org,
        rostedt@goodmis.org, mingo@redhat.com, isely@pobox.com,
        bhumirks@gmail.com, colin.king@canonical.com,
        kieran.bingham@ideasonboard.com, keiichiw@chromium.org
Subject: Re: [PATCH v6 0/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer
Date:   Wed, 12 Dec 2018 19:28:27 +0200
Message-ID: <3390244.qRE0ngbmrs@avalon>
Organization: Ideas on Board Oy
In-Reply-To: <20181109190327.23606-1-matwey@sai.msu.ru>
References: <20181109190327.23606-1-matwey@sai.msu.ru>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Matwey,

Thank you for the patches.

For the whole series,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

On Friday, 9 November 2018 21:03:25 EET Matwey V. Kornilov wrote:
> DMA cocherency slows the transfer down on systems without hardware coherent
> DMA. In order to demontrate this we introduce performance measurement
> facilities in patch 1 and fix the performance issue in patch 2 in order to
> obtain 3.3 times speedup.
> 
> Changes since v5:
>  * add dma_sync_single_for_device() as required by Laurent Pinchart
> 
> Changes since v4:
>  * fix fields order in trace events
>  * minor style fixes
> 
> Changes since v3:
>  * fix scripts/checkpatch.pl errors
>  * use __string to store name in trace events
> 
> Changes since v2:
>  * use dma_sync_single_for_cpu() to achive better performance
>  * remeasured performance
> 
> Changes since v1:
>  * trace_pwc_handler_exit() call moved to proper place
>  * detailed description added for commit 1
>  * additional output added to trace to track separate frames
> 
> Matwey V. Kornilov (2):
>   media: usb: pwc: Introduce TRACE_EVENTs for pwc_isoc_handler()
>   media: usb: pwc: Don't use coherent DMA buffers for ISO transfer
> 
>  drivers/media/usb/pwc/pwc-if.c | 69 +++++++++++++++++++++++++++++++--------
>  include/trace/events/pwc.h     | 65 +++++++++++++++++++++++++++++++++++++++
>  2 files changed, 121 insertions(+), 13 deletions(-)
>  create mode 100644 include/trace/events/pwc.h

-- 
Regards,

Laurent Pinchart