Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 12 Dec 2018 20:32:04 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To:     Roberto Sassu <roberto.sassu@huawei.com>
Cc:     zohar@linux.ibm.com, david.safford@ge.com, monty.wiseman@ge.com,
        linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org, silviu.vlasceanu@huawei.com,
        Nayna Jain <nayna@linux.ibm.com>
Subject: Re: [PATCH v6 1/7] tpm: dynamically allocate the allocated_banks
 array
Message-ID: <20181212183204.GK6333@linux.intel.com>
References: <20181204082138.24600-1-roberto.sassu@huawei.com>
 <20181204082138.24600-2-roberto.sassu@huawei.com>
 <20181204231848.GA1233@linux.intel.com>
 <9193bc05-8222-f0d6-9ad8-a2a7eaf1a34c@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9193bc05-8222-f0d6-9ad8-a2a7eaf1a34c@huawei.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Dec 06, 2018 at 06:56:33PM +0100, Roberto Sassu wrote:
> 2 PCR selections
>     hash TPM_ALG_SHA1
>     TPMS_PCR_SELECTION length 3
>     ff ff ff
>     hash TPM_ALG_SHA256
>     TPMS_PCR_SELECTION length 3
>     00 00 00
> 
> The pcr_select fields - "ff ff ff" and "00 00 00" - are bit masks for
> the enabled PCRs. The SHA1 bank is enabled for all PCRs (0-23), while
> the SHA256 bank is not enabled.

Uh, thanks. Can you add a note to the commit message?

 
> > 
> > /* Check that at least some of the PCRs have been allocated. This is
> >   * required because CAP_PCRS ...
> >   */
> > if (memchr_inv(pcr_selection.pcr_select, 0, pcr_selection.size_of_select))
> > 	nr_allocated_banks++;
> > 
> > [yeah, comment would be awesome about CAP_PCRS. Did not finish up the
> > comment because I don't know the answer]
> > 
> > In addition, it would be consistent to call the local variable also
> > nr_allocated_banks (not nr_alloc_banks).
> 
> Unfortunately, I exceed the limit of characters per line.

Not sure what you mean?

/Jarkko