Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1544603038-9373-1-git-send-email-liaoweixiong@allwinnertech.com>
In-Reply-To: <1544603038-9373-1-git-send-email-liaoweixiong@allwinnertech.com>
From:   Kees Cook <keescook@chromium.org>
Date:   Wed, 12 Dec 2018 10:43:24 -0800
Message-ID: <CAGXu5j+nTVoD=AMvOcn2bvA4C0mw=LKDbVnDWhUkL3c6mJye_g@mail.gmail.com>
Subject: Re: [PATCH] pstore: fix crypto dependencies of 842/zstd compression
To:     liaoweixiong@allwinnertech.com
Cc:     Anton Vorontsov <anton@enomsg.org>,
        Colin Cross <ccross@android.com>,
        Tony Luck <tony.luck@intel.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Dec 12, 2018 at 12:24 AM liaoweixiong
<liaoweixiong@allwinnertech.com> wrote:
>
> Reference to commit 58eb5b670747 ("pstore: fix crypto dependencies"),
> which fixed crypto dependencies of deflate, lzo, lz4 and lz4hc
> compression, but omitted 842 and newer compression zstd from
> commit 1021bcf44d0e ("pstore: add zstd compression support")
>
> Signed-off-by: liaoweixiong <liaoweixiong@allwinnertech.com>

Were you seeing build or config failures without this patch?

-Kees

> ---
>  fs/pstore/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/pstore/Kconfig b/fs/pstore/Kconfig
> index 0d19d19..7068f45 100644
> --- a/fs/pstore/Kconfig
> +++ b/fs/pstore/Kconfig
> @@ -44,14 +44,14 @@ config PSTORE_LZ4HC_COMPRESS
>           This option enables LZ4HC (high compression) mode algorithm.
>
>  config PSTORE_842_COMPRESS
> -       bool "842 compression"
> +       tristate "842 compression"
>         depends on PSTORE
>         select CRYPTO_842
>         help
>           This option enables 842 compression algorithm support.
>
>  config PSTORE_ZSTD_COMPRESS
> -       bool "zstd compression"
> +       tristate "zstd compression"
>         depends on PSTORE
>         select CRYPTO_ZSTD
>         help
> --
> 1.9.1
>


-- 
Kees Cook