Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 12 Dec 2018 11:06:12 -0800
From:   Jakub Kicinski <jakub.kicinski@netronome.com>
To:     Daniel Borkmann <daniel@iogearbox.net>
Cc:     Alice Ferrazzi <alice.ferrazzi@gmail.com>, ast@kernel.org,
        shuah@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] selftest/bpf: fix E501 line too long
Message-ID: <20181212110612.58c013fe@cakuba.netronome.com>
In-Reply-To: <62f6127d-edf6-2d41-cd7d-1c1c20607b38@iogearbox.net>
References: <20181211115607.13774-1-alice.ferrazzi@gmail.com>
        <20181211115607.13774-8-alice.ferrazzi@gmail.com>
        <62f6127d-edf6-2d41-cd7d-1c1c20607b38@iogearbox.net>
Organization: Netronome Systems, Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 12 Dec 2018 11:24:02 +0100, Daniel Borkmann wrote:
> > -        raise Exception("Time out waiting for program counts to stabilize want %d/%d, have %d bound, %d loaded" % (
> > +        raise Exception("Time out waiting for program counts to \
> > +stabilize want %d/%d, have %d bound, %d loaded" % (
> >              bound, total, nbound, nprogs))  
> 
> I'll leave the test_offload.py ones up to Jakub, but to me it seems
> this particular change here would actually make the code look worse
> and harder to grep for error messages, so my preference would be to
> at least leave the error messages as-is. Also seems it's not a 'must'
> in pep8 [0].
> 
>   [0] https://www.python.org/dev/peps/pep-0008/#maximum-line-length

Thanks, agreed, this has been run through checkpatch, so the line
lengths should be fine (and we don't want error messages split).