Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v6 5/5] ACPICA: Remove PCI bits from ACPICA when
 CONFIG_PCI is unset
To:     "Schmauss, Erik" <erik.schmauss@intel.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>
Cc:     ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        "Moore, Robert" <robert.moore@intel.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
        Len Brown <lenb@kernel.org>,
        "devel@acpica.org" <devel@acpica.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20181212171941.7437-1-okaya@kernel.org>
 <20181212171941.7437-6-okaya@kernel.org>
 <CF6A88132359CE47947DB4C6E1709ED53C556B2C@ORSMSX122.amr.corp.intel.com>
 <39dc076f-1b3d-ad0c-c4bb-056ac589f361@kernel.org>
 <CAJZ5v0iN+OkN0+wy=jGA33Uz+wQT7=zxF-TX3e-TrHDnr4=YRA@mail.gmail.com>
 <CF6A88132359CE47947DB4C6E1709ED53C556C0D@ORSMSX122.amr.corp.intel.com>
From:   Sinan Kaya <okaya@kernel.org>
Message-ID: <1cf7a2ce-0e1b-c329-a891-0cc9ae030f1b@kernel.org>
Date:   Wed, 12 Dec 2018 16:31:01 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.3
MIME-Version: 1.0
In-Reply-To: <CF6A88132359CE47947DB4C6E1709ED53C556C0D@ORSMSX122.amr.corp.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 12/12/2018 4:16 PM, Schmauss, Erik wrote:
> 
> 
>> -----Original Message-----
>> From: Rafael J. Wysocki [mailto:rafael@kernel.org]
>> Sent: Wednesday, December 12, 2018 1:07 PM
>> To: okaya@kernel.org; Schmauss, Erik <erik.schmauss@intel.com>
>> Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>; Moore, Robert
>> <robert.moore@intel.com>; Wysocki, Rafael J <rafael.j.wysocki@intel.com>;
>> Len Brown <lenb@kernel.org>; devel@acpica.org; Linux Kernel Mailing List
>> <linux-kernel@vger.kernel.org>
>> Subject: Re: [PATCH v6 5/5] ACPICA: Remove PCI bits from ACPICA when
>> CONFIG_PCI is unset
>>
>> On Wed, Dec 12, 2018 at 8:34 PM Sinan Kaya <okaya@kernel.org> wrote:
>>>
>>> On 12/12/2018 2:02 PM, Schmauss, Erik wrote:
>>>>> ++ b/drivers/acpi/acpica/achware.h
>>>>> @@ -109,8 +109,17 @@ acpi_hw_enable_runtime_gpe_block(struct
>>>>> acpi_gpe_xrupt_info *gpe_xrupt_info,
>>>> CONFIG_PCI is a Linux-ism. We should stay with the OS-independent
>>>> nature of ACPICA. Please use ACPI_PCI_CONFIGURED and put it above
>> the comment like so:
>>>>
>>>> #ifdef ACPI_PCI_CONFIGURED
>>>
>>> Thanks for the feedback. My search for ACPI_PCI_CONFIGURED returned
>> nothing.
>>>
>>> git grep ACPI_PCI_CONFIGURED
>>>
>>> @Rafael,
>>>
>>> How do you want to handle this?
>>
>> I think what Eric suggested is effectively to introduce a new ACPICA symbol.
>> Erik?
> 
> Yes, that's correct and you can add something like
> 
> #ifdef CONFIG_PCI
> #define ACPI_PCI_CONFIGURED
> #endif
> 
> in include/linux/platform/aclinux.h to enable it.
> 

OK. Let me rework this and test.