Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp258263imu; Wed, 12 Dec 2018 16:18:54 -0800 (PST) X-Google-Smtp-Source: AFSGD/XFgi2X2ZzKaTv/rj/WUfXoEda9lvI3NS5NExe65cgiUwqH00KmPxSNwyd2u7fDLGvwzz1W X-Received: by 2002:a62:d148:: with SMTP id t8mr22672390pfl.52.1544660334027; Wed, 12 Dec 2018 16:18:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544660333; cv=none; d=google.com; s=arc-20160816; b=lwPfdNJkc9QxddT1BHz1mZCTxqBYoKVJn42BLvVbcitk2J3sNvdhDwC2zxIgWOacr7 XQWUqR3D4CWfVhMsfBi8Z+H5XY2m8TkO1yqZhCcOerT1H98BzHw3Fg7WGb3Yz7tKfCva NeP/B4eYtjkjmeswKFgMFPLIhREVbg/cT5tCgAtC7r4SSJIL1pxu02iu13206co/+czw n7VSMVjrWPxKowpnVjvZQH0p76GW02FI0jPggMF2WwnsYwum8kpHkMl0ciOYYnGEHBbm VeMGtKlYoZm2zSSKu2s1B3W/jZGskvZLzWGUNTQZyANQVmYa51sCd2uqTYZkBlK0UwjB hTTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:mime-version:date:in-reply-to :subject:cc:to:from:user-agent:references; bh=O1CcctcXgZR0m9TnibYsEV1waWOBja9D3ZQOIm+qE2Y=; b=j+FFlUd+9ITEUfl0bPN/I8iXHO2fBymwtlLX+n8p/8yi/sDUAmMk6OQhUt9yl/tQ5a ae+YzwiyOLneXLSrqPZaW8QDppGp4iccL32ckui5pNLLuh2DGp18dqMvtNdzXImULQPL gytwp+GPiw7Ig/U2Y2lRo/0fz1Cw0C5Rrc9Uqr0Bqw38HtxRh3LevLmNt9sjnAVUHFXb +YI7kd+I5xVRFON/87r3V3zDKHdZ0GxArgimkJmEn5dFcDOFYOW/mLLsn8jUeks2Wf1G VpJKyJrIB1be5c2mXfpU+sddPI5F8BtpXQzclR75Eh4ca/TQT6EBNFXF0LwDiExfiWD1 HMoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d189si223233pfa.70.2018.12.12.16.18.16; Wed, 12 Dec 2018 16:18:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728575AbeLMARX (ORCPT + 99 others); Wed, 12 Dec 2018 19:17:23 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:43160 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728527AbeLMARX (ORCPT ); Wed, 12 Dec 2018 19:17:23 -0500 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id wBD0EFRD011990 for ; Wed, 12 Dec 2018 19:17:21 -0500 Received: from e15.ny.us.ibm.com (e15.ny.us.ibm.com [129.33.205.205]) by mx0b-001b2d01.pphosted.com with ESMTP id 2pb8ku2unm-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 12 Dec 2018 19:17:21 -0500 Received: from localhost by e15.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 13 Dec 2018 00:17:20 -0000 Received: from b01cxnp23032.gho.pok.ibm.com (9.57.198.27) by e15.ny.us.ibm.com (146.89.104.202) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 13 Dec 2018 00:17:17 -0000 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id wBD0HGQ122085648 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 13 Dec 2018 00:17:16 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 75E22AE060; Thu, 13 Dec 2018 00:17:16 +0000 (GMT) Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 37534AE05C; Thu, 13 Dec 2018 00:17:13 +0000 (GMT) Received: from morokweng.localdomain (unknown [9.80.227.60]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTPS; Thu, 13 Dec 2018 00:17:13 +0000 (GMT) References: <20181208202705.18673-1-nayna@linux.ibm.com> <20181208202705.18673-3-nayna@linux.ibm.com> User-agent: mu4e 1.0; emacs 26.1 From: Thiago Jung Bauermann To: Nayna Jain Cc: linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, zohar@linux.ibm.com, dhowells@redhat.com, jforbes@redhat.com, seth.forshee@canonical.com, kexec@lists.infradead.org, keyrings@vger.kernel.org, vgoyal@redhat.com, ebiederm@xmission.com, mpe@ellerman.id.au Subject: Re: [PATCH v2 2/7] integrity: Load certs to the platform keyring In-reply-to: <20181208202705.18673-3-nayna@linux.ibm.com> Date: Wed, 12 Dec 2018 22:17:08 -0200 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 18121300-0068-0000-0000-00000370C125 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010216; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000270; SDB=6.01130913; UDB=6.00587691; IPR=6.00911046; MB=3.00024673; MTD=3.00000008; XFM=3.00000015; UTC=2018-12-13 00:17:20 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18121300-0069-0000-0000-000046BEEB0E Message-Id: <87zhtae0vv.fsf@morokweng.localdomain> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-12-12_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=887 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812130000 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nayna Jain writes: > The patch refactors integrity_load_x509(), making it a wrapper for a new > function named integrity_add_key(). This patch also defines a new > function named integrity_load_cert() for loading the platform keys. > > Signed-off-by: Nayna Jain > Reviewed-by: Mimi Zohar > Acked-by: Serge Hallyn > --- > security/integrity/digsig.c | 71 ++++++++++++++-------- > security/integrity/integrity.h | 20 ++++++ > .../integrity/platform_certs/platform_keyring.c | 23 +++++++ > 3 files changed, 90 insertions(+), 24 deletions(-) Reviewed-by: Thiago Jung Bauermann -- Thiago Jung Bauermann IBM Linux Technology Center