Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <642dd9ea144c03041ad74b14777553fe652acd1a.camel@perches.com>
Subject: Re: [PATCH 1/2] scripts/spdxcheck.py: Always open files in binary
 mode
From:   Joe Perches <joe@perches.com>
To:     Jeremy Cline <jcline@redhat.com>,
        Thierry Reding <thierry.reding@gmail.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jonathan Corbet <corbet@lwn.net>,
        Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>, linux-kernel@vger.kernel.org
Date:   Wed, 12 Dec 2018 18:51:19 -0800
In-Reply-To: <20181212181410.GC2352@laptop.jcline.org>
References: <20181212131210.28024-1-thierry.reding@gmail.com>
         <20181212181410.GC2352@laptop.jcline.org>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.30.1-1build1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2018-12-12 at 13:14 -0500, Jeremy Cline wrote:
> It might be worth noting this fixes commit 6f4d29df66ac
> ("scripts/spdxcheck.py: make python3 compliant")

umm, how does it do that?

> and also Cc this for
> stable since 6f4d29df66ac got backported to v4.19. While that commit
> did indeed make the script work with Python 3 for piping data, it broke
> Python 2 and made its way to stable.

I think attempting to use spdxcheck on binary files
is not useful in the first place.