Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp377132imu; Wed, 12 Dec 2018 19:11:37 -0800 (PST) X-Google-Smtp-Source: AFSGD/XWcpmJV1KJ7n32cxnIiGbuTdPA/Ilj5RzOSeoH9u0Npp7QW6MgXAMju5PVBL1dwdjL3hnJ X-Received: by 2002:a63:6c48:: with SMTP id h69mr19510618pgc.139.1544670697295; Wed, 12 Dec 2018 19:11:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544670697; cv=none; d=google.com; s=arc-20160816; b=IgTF5TBSmrhByElR9Njh3zZt0mFjZiA9g+h8MzoFvD3J/7mAeCBru7wFdjlG3gypze 1PYAvUnmPKQD0SRp1ErbDntHqwTAO9toL8v+akGRMmGlJQGl7I024mmekX6REfn52d4u Ih6VT1FIx0z2YyyUvSxydoDpNxWicgQjCzZTmGl6GK5eG9L36J/1KRp+LkmJfX9esjZX 0yPjQpOv8GpsvrY56eNZNJ6l72pOufNecQSpU56p7ipfLd8qkxJia0fJZ19WZfXNI3tg IecsjQL7a4OAT51kAQYGY3SgB3MKLr6ofcK1FsgEZlGykDDty33V7K0SYqmZjos5M2qt g7Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=gQYrq9UuTap4YJqzhHKNnqc5GVwNODweK9n1wMX+Vpk=; b=kAZb6tCK0HsxvYl5ttj7tpP/aOBG9raDbkXeWbvLuH7NjcfXhDWPQ+JZdvXqr3G8i1 h/RCBDLo7zDNAfrGktI0KZUa558QrtQXOlhHO1LCFngac742o2XXbhrR0zFh7Nxw1/lC KxFayhyyQNZZ0jd5GJjajB9w+G+fahvJ03cXaZa9icLlS7zo9YmlSrWze9i8892p0E8q nHOqmWnDcQYAMVDblFSalJslsraCNCs66LUjp0vhSThhSm/J2YWHf1rG1AGeTcZKUjCM XdJQZG7EV5qU3QhUlPfX+b21nPPd5lDzEJ1jipnhktf5QFff0fv0/eMyxXxrkjzfrMmY JfZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l10si562255pls.162.2018.12.12.19.11.19; Wed, 12 Dec 2018 19:11:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726774AbeLMDJr (ORCPT + 99 others); Wed, 12 Dec 2018 22:09:47 -0500 Received: from ozlabs.org ([203.11.71.1]:51981 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726396AbeLMDJr (ORCPT ); Wed, 12 Dec 2018 22:09:47 -0500 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 43FdvX3CbZz9s3l; Thu, 13 Dec 2018 14:09:44 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: Christophe Leroy , Andrew Morton , Colin Ian King , Kees Cook Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] lib: fix build failure in CONFIG_DEBUG_VIRTUAL test In-Reply-To: <40d63adb6058b1fbb4082ca6f15225cb6e76bd62.1544429175.git.christophe.leroy@c-s.fr> References: <40d63adb6058b1fbb4082ca6f15225cb6e76bd62.1544429175.git.christophe.leroy@c-s.fr> Date: Thu, 13 Dec 2018 14:09:45 +1100 Message-ID: <874lbiw29y.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christophe Leroy writes: > On several arches, virt_to_phys() is in io.h > > Build fails without it: > > CC lib/test_debug_virtual.o > lib/test_debug_virtual.c: In function 'test_debug_virtual_init': > lib/test_debug_virtual.c:26:7: error: implicit declaration of function 'virt_to_phys' [-Werror=implicit-function-declaration] > pa = virt_to_phys(va); > ^ > > Fixes: e4dace361552 ("lib: add test module for CONFIG_DEBUG_VIRTUAL") > CC: stable@vger.kernel.org > Signed-off-by: Christophe Leroy > --- > lib/test_debug_virtual.c | 1 + > 1 file changed, 1 insertion(+) I'm going to take this via the powerpc tree, because otherwise Christophe's patch to implement CONFIG_DEBUG_VIRTUAL for powerpc will break the build for us. Hopefully no one minds :) cheers