Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp424029imu; Wed, 12 Dec 2018 20:31:24 -0800 (PST) X-Google-Smtp-Source: AFSGD/XIFH7iZcdPYihx96jGOpTpr0pcDLXuAFbK93VrJUljKNMGW/j7N3r7/hC/q6npoWlGVpSM X-Received: by 2002:a62:4e83:: with SMTP id c125mr22961529pfb.101.1544675484614; Wed, 12 Dec 2018 20:31:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544675484; cv=none; d=google.com; s=arc-20160816; b=KPVX6v1mpf8wLchojEBg8whtgxW2w5gNfxKn2wBxsFj0Hk8gZX1q4hUgiLamkqLQK7 Jo++d2pXib7i6fisU1MwX+oJ2grIIZXQ6EplNG6FJjjtJoAkmYgv1zdP1YtbVHDidLkE 2qWofeCnMDZEpuX20V7FuQHIr53JbwYjTRTFhN7wDaTGUhjVRLqT1W7sQ2Hn4xKoIHHR 6gCGaDMLoEBmr8zbRPs45Ka3u7BuF5t+zHWGG31dVbBsN4kCKgdZVAyLbinvroXyvI5G 6dufV/0tRfoVfNWn1FQgqO77WDyMYc6Qnpdd1eo/DwyfuwMpI79aAmlMVbLppcw/LS+J oIdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2MHJuX00llVbnUTXW6vadK8hg7kEmSYdi+Qa9n13eGM=; b=Ufa0UlEo2o6W2F2TSJ4AZVuqTPUGF2M4p+p7P31hHPS4ldQ5hmhc1N2pq8NkfZNUPC rJbkdVXHxZQPX5FyUJ1uxpMAiu20dVsvBxN47pZJiJluDcnAiBvzfU2o2EsliFQj1ja9 I2hmRJptF41MXFPfUcx+9RsFh8X3xu0fNz0RR4+I6nU5+z95pg/cGEsSTeW+95l1/AF3 weIKTdyJQTITeI59/+MkEHwIqzycJApXdSgsPkFfrOwqBuoidcXVE1qQXjv8ni+IAPBg usP3JvPrMiuuVVgjInpGf7LGHCp++/7JDIQvtuTDJF0nbeItD+uPSvBWNMlb9ByozNyK yI5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qQ1rRzBI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w185si629318pgd.518.2018.12.12.20.31.10; Wed, 12 Dec 2018 20:31:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qQ1rRzBI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727856AbeLME3t (ORCPT + 99 others); Wed, 12 Dec 2018 23:29:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:42720 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727834AbeLME3q (ORCPT ); Wed, 12 Dec 2018 23:29:46 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9AABE20873; Thu, 13 Dec 2018 04:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544675385; bh=6TMEWmplXObtlXPfssWE6izb849ZoCBkmvEwN2jAZUQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qQ1rRzBI8yAftk8dTquSPegADBOpX0d9lF7Vkft2Qqu7YXw7ucrsm5x6ZEoPZOqzH iGDi0Ngr0kcaqlXYKIWlygtF0o8MZnDXKYG4v/QgaSifCp8rDCVgIxA4ebjB1HSZAn KRwi5265YvkfpmrkwGhYvryDReTOBKcilE6hPM1E= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wen Yang , Rob Clark , David Airlie , Julia Lawall , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Sean Paul , Sasha Levin Subject: [PATCH AUTOSEL 4.19 35/73] drm/msm: Fix error return checking Date: Wed, 12 Dec 2018 23:28:00 -0500 Message-Id: <20181213042838.75160-35-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181213042838.75160-1-sashal@kernel.org> References: <20181213042838.75160-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wen Yang [ Upstream commit 098336deb946f37a70afc0979af388b615c378bf ] The error checks on ret for a negative error return always fails because the return value of iommu_map_sg() is unsigned and can never be negative. Detected with Coccinelle: drivers/gpu/drm/msm/msm_iommu.c:69:9-12: WARNING: Unsigned expression compared with zero: ret < 0 Signed-off-by: Wen Yang CC: Rob Clark CC: David Airlie CC: Julia Lawall CC: linux-arm-msm@vger.kernel.org CC: dri-devel@lists.freedesktop.org CC: freedreno@lists.freedesktop.org CC: linux-kernel@vger.kernel.org Signed-off-by: Sean Paul Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/msm_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_iommu.c b/drivers/gpu/drm/msm/msm_iommu.c index b23d33622f37..2a90aa4caec0 100644 --- a/drivers/gpu/drm/msm/msm_iommu.c +++ b/drivers/gpu/drm/msm/msm_iommu.c @@ -66,7 +66,7 @@ static int msm_iommu_map(struct msm_mmu *mmu, uint64_t iova, // pm_runtime_get_sync(mmu->dev); ret = iommu_map_sg(iommu->domain, iova, sgt->sgl, sgt->nents, prot); // pm_runtime_put_sync(mmu->dev); - WARN_ON(ret < 0); + WARN_ON(!ret); return (ret == len) ? 0 : -EINVAL; } -- 2.19.1