Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp424768imu; Wed, 12 Dec 2018 20:32:29 -0800 (PST) X-Google-Smtp-Source: AFSGD/UvttxPbkxpImpNdb/uJ8OLOSL89eZPFuK1v7GLTw+ie34M/VEJFn1zXckui+2TOuF1+vWt X-Received: by 2002:a17:902:680f:: with SMTP id h15mr21860866plk.40.1544675549681; Wed, 12 Dec 2018 20:32:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544675549; cv=none; d=google.com; s=arc-20160816; b=0F4g5XhBcrJvHQOsvJkspkvS9vAoOR35cPcWHhosxKSh8N19Y+1MDLIP8ePWF/T6er nCMerzA22Z8pzjwknsTKcpaJt1EjK90Lbc48/pUApSIpq2mLr4l/YHfnil4XFWLzq3AI cvz6ev51k9t9eLZ3kN6XJAqRprjsTy911Go2U8130p62qmrdKuKBjWifliPbn+MquuEi 4UYocIRK2N8usETbDY0e1Mfjeuv2Zw2X7e2CtC+afvdtrWRg5i3OKf6NiqhIgbspAnhT WNIn1/iThILl8wbVUlTBNl/V/p1xeB9hPcsIylfDb76v/EtxvNPnPxksnL4Z6EGhQQ+4 hKeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=IprwzbFUNbAPKjvzX7fhj1ENWRxlBdqtWknVXJlwJz8=; b=meyY+Qi9c8Rt90nPBk0vyiuDR0KzABCMlzZ8ducLTY4pUQ05MS6/uYTSe+YEZXT95M YlN1zzkrElWySUHr6OlgqDXUl6gkk66D1u1EUc4Tj2Wgaqd97ksccMar4xPK4DnJEv43 43Umj97IrScVtcEY6Ib4wiz/kft7FABeBw5zzRSQk7Pka3TgWIL7tYSSaJHIvwQJuhkQ OA+JRkuxeTCivf30thX8xY9LCb2UJaAYVmIRZQUtVih9+aWWpZh9tj4ttBnrh/W+9Tq4 5mjN2mwQvDQhdajeUnHENtHBRA7HZByVyJLiOIqFag0AFXU73v/66NyMxX8zwbYqaXG7 Dnyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Lsg1FpdH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r14si736632pgk.75.2018.12.12.20.32.15; Wed, 12 Dec 2018 20:32:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Lsg1FpdH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727828AbeLME3p (ORCPT + 99 others); Wed, 12 Dec 2018 23:29:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:42696 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726470AbeLME3o (ORCPT ); Wed, 12 Dec 2018 23:29:44 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3763520879; Thu, 13 Dec 2018 04:29:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544675384; bh=R/vDS0v/GEG93jmo2Fm+5ulH4DFWH0Jo5QZMF00pSuA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Lsg1FpdHraIUX/sYsv0x5YlGVLDsfJglsb30/ZN3slV5oJLJRzeJqYV5nIeWXiHBt 5iTmB7/HqmwKtg/dxhlSsRjEux0qIvyb1FbJxREPjm7l0rBNpSI4j4rnFXktQkutWO qWCDrINT/rsLx5kogz4zakxAZcMRaWI+JgFsyf/Y= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: YueHaibing , Rob Clark , Sean Paul , Sasha Levin , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: [PATCH AUTOSEL 4.19 34/73] drm/msm: dpu: Fix "WARNING: invalid free of devm_ allocated data" Date: Wed, 12 Dec 2018 23:27:59 -0500 Message-Id: <20181213042838.75160-34-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181213042838.75160-1-sashal@kernel.org> References: <20181213042838.75160-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing [ Upstream commit ce25aa3ee6939d83979cccf7adc5737cba9a0cb7 ] 'dpu_enc' is a member of 'drm_enc' And 'drm_enc' got allocated with devm_kzalloc in dpu_encoder_init. This gives this error message: ./drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:459:1-6: WARNING: invalid free of devm_ allocated data Signed-off-by: YueHaibing Signed-off-by: Rob Clark Signed-off-by: Sean Paul Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index 1b4de3486ef9..ec3fd67378c1 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c @@ -503,8 +503,6 @@ static void dpu_encoder_destroy(struct drm_encoder *drm_enc) drm_encoder_cleanup(drm_enc); mutex_destroy(&dpu_enc->enc_lock); - - kfree(dpu_enc); } void dpu_encoder_helper_split_config( -- 2.19.1