Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp424793imu; Wed, 12 Dec 2018 20:32:32 -0800 (PST) X-Google-Smtp-Source: AFSGD/VrWETWQk3U+Exd7AyjRIx5uWhk9J4DWxjEGkTR4dV5dOlr8zfEmK76FL+JgiVIpVYh6aQW X-Received: by 2002:a62:2082:: with SMTP id m2mr22152939pfj.163.1544675552046; Wed, 12 Dec 2018 20:32:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544675552; cv=none; d=google.com; s=arc-20160816; b=ngQI11IjFO7WuUhEWa2kmYW9Gp6k70Ny0n0kqiZr/IrPVeIFfP7V9FJ8R5/OyDBh/x vh1LU+XaNvYz3aHb1kQy5VWjH36FGsqaC0tVGgW5AsNOtaegG7iF0J0NUm4M+U2PJd4D PsJZ3m3MhQIMDLqaf/yYeEZflAMVgx2LZyjPN/rew0PwkVrcf5q6PaLlZxvoOCjPJUY3 fNSZQSeNvqYbG37qIJES6LrQWcnMGAzim6rA9nEx/MjV8sv/jAImXSwFdoehib0pZlWx A4BQg3UgqwIq6Sh2RKecMJqoDJAWNlw3tTbA/LssVhodyNGPVJoFKuxWUhH+7ft5U1hq +vQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=QOyS+DMVUjInrZHagY7TGwQGzjGEhDbYidnfpwGRGfU=; b=v1CHVPpMTYGYuXC6HsJoe4UjmNgFm7sanmSi/Xp9EI08CA7c9FbPgRCC4W6wS/ipPt SuoGnyATaVsFRSPoTBRh/ISFbtI3AGBf46sJQF8VAEqUT6cZnPC7EREy/dRsos7H+yuI NoP3ftNy8NY4kDri6TVVo1LglIcJpATnoQO6MfQtiVaclKhOenehaV72uj4O4Nwsw3RI HwnsOnGEZSx/QtnI8wcS5m3LK5LFIPrTYi8d4MLulv8K2Gi2AicfM8535mFPi7V3vhXv xeKzGrdFSfY+iGRyWZjR2m1oDDkOJoOCFXpL8urV05KuilE0dE9B5adnHYvqeMreHBiJ Rarg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ovArJyZP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33si694213plu.169.2018.12.12.20.32.17; Wed, 12 Dec 2018 20:32:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ovArJyZP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728416AbeLMEap (ORCPT + 99 others); Wed, 12 Dec 2018 23:30:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:43522 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726907AbeLMEaj (ORCPT ); Wed, 12 Dec 2018 23:30:39 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2BBCA20879; Thu, 13 Dec 2018 04:30:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544675438; bh=Z4ZwdEY946Inu2LEbt5cy9Cjm55DmwBRG3Ex2mZbTp0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ovArJyZPKrwwFcNpjQOXSQ1d1Xr8G5h+9kT/S8O9Kcsl8QhNIP3IsjbE/1oyxP4Cg bxg5s61dp1pQV2Rkj30KDyithkXD1tZG2fYtOxEP9kDne0/EBmmoF9vzh0+PmEEyG/ XlqCXbXzgdtU9v7dIrSa5pemBiVAbpC9bAG//jus= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Steve French , Sasha Levin , linux-cifs@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 63/73] cifs: In Kconfig CONFIG_CIFS_POSIX needs depends on legacy (insecure cifs) Date: Wed, 12 Dec 2018 23:28:28 -0500 Message-Id: <20181213042838.75160-63-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181213042838.75160-1-sashal@kernel.org> References: <20181213042838.75160-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Steve French [ Upstream commit 6e785302dad32228819d8066e5376acd15d0e6ba ] Missing a dependency. Shouldn't show cifs posix extensions in Kconfig if CONFIG_CIFS_ALLOW_INSECURE_DIALECTS (ie SMB1 protocol) is disabled. Signed-off-by: Steve French Reviewed-by: Pavel Shilovsky Signed-off-by: Sasha Levin --- fs/cifs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig index abcd78e332fe..85dadb93c992 100644 --- a/fs/cifs/Kconfig +++ b/fs/cifs/Kconfig @@ -133,7 +133,7 @@ config CIFS_XATTR config CIFS_POSIX bool "CIFS POSIX Extensions" - depends on CIFS_XATTR + depends on CIFS && CIFS_ALLOW_INSECURE_LEGACY && CIFS_XATTR help Enabling this option will cause the cifs client to attempt to negotiate a newer dialect with servers, such as Samba 3.0.5 -- 2.19.1