Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp425320imu; Wed, 12 Dec 2018 20:33:14 -0800 (PST) X-Google-Smtp-Source: AFSGD/UE4ZaJpxsfbGW5lkeAGymDZyBZkEbmwXBg/HmSdiA0cL/dU2w/9UCouGpfd2JW70DvSCf9 X-Received: by 2002:a63:86c6:: with SMTP id x189mr635317pgd.250.1544675594723; Wed, 12 Dec 2018 20:33:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544675594; cv=none; d=google.com; s=arc-20160816; b=lvGutE2H6d52OQ+CelfISzc5aBtwNHwEdfDwhb8UItUzwYxGZEmXnF+dg9n9MTbizg ByM3q+lzQbnCBYMs0kH+/bLxS/i3NBRrv6drEHeBztBNOR5QyRxXt7OOzvm6Ln2SlNEo EdqgOwEJ1jx4fbZoqpV4U+bf0vVX2KSQ5k+sbgCkzTNedWJ1wJO3jcxDnYZ51wPL44Xb n9GDl0gt5zEfUge70PeSMcuWpyrO8L/r+dHuGcVt21J+sPIUgs2YaaWzIvTdYwoHCq7F e1KZ6kibBOBIi1+fb3EhFIu5pj1pdiD7SjNMZcmWUt8E+tQ2cJ12igtsabf40Kyyl5FB 040g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2MHJuX00llVbnUTXW6vadK8hg7kEmSYdi+Qa9n13eGM=; b=TfIEbC8/K0+wY0FnCX2EjmenKolZiDDWJFGjR4dIhR5sk0tcblqv1BjwSNEdbLMoDL PNc/JNZKe1qY8CUwvu4IT/8B1IqWoUrjuLkR/ttB2/1i37N3NjD2TOYNry7gQTplFHyt gR11gx0MAb6ibLt1No/F2mHsyJnhxgP+t3kbvjHhRbA/vljwwCmm6gVUeeaUmWAiCeBx R4V9jYd62try4dkOWzItewEfepB29pyAKe207HMe+4Qt+ORQSugEwzwrDzu5zIkkfk1z mxHPrGcyyryP4SS3FGt6bwzGMm7bxRmW4/ZMEewVAQpeK/9kk6trJOZLwM4Tz/Pl5kfV dOzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=z3dK8RGy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a12si685392pll.112.2018.12.12.20.32.59; Wed, 12 Dec 2018 20:33:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=z3dK8RGy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727707AbeLMEbZ (ORCPT + 99 others); Wed, 12 Dec 2018 23:31:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:44162 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728652AbeLMEbV (ORCPT ); Wed, 12 Dec 2018 23:31:21 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C0D8D20873; Thu, 13 Dec 2018 04:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544675480; bh=6TMEWmplXObtlXPfssWE6izb849ZoCBkmvEwN2jAZUQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=z3dK8RGybJVzN6perwk5LIHUgaKjhvskY1vKin3E7kr29S+ljCjheJPKjBj1KCU1r V0d/hkLABW59blSiIEwDp5R5ulGXz5mF/z29hvSbcJeV2HWYWxi8wrPGqeVoiYjyLl jtRvO3Fwvj975jZzb2HOFoy5NcV+g5sIy/rymY7g= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wen Yang , Rob Clark , David Airlie , Julia Lawall , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Sean Paul , Sasha Levin Subject: [PATCH AUTOSEL 4.14 17/41] drm/msm: Fix error return checking Date: Wed, 12 Dec 2018 23:30:30 -0500 Message-Id: <20181213043054.75891-17-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181213043054.75891-1-sashal@kernel.org> References: <20181213043054.75891-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wen Yang [ Upstream commit 098336deb946f37a70afc0979af388b615c378bf ] The error checks on ret for a negative error return always fails because the return value of iommu_map_sg() is unsigned and can never be negative. Detected with Coccinelle: drivers/gpu/drm/msm/msm_iommu.c:69:9-12: WARNING: Unsigned expression compared with zero: ret < 0 Signed-off-by: Wen Yang CC: Rob Clark CC: David Airlie CC: Julia Lawall CC: linux-arm-msm@vger.kernel.org CC: dri-devel@lists.freedesktop.org CC: freedreno@lists.freedesktop.org CC: linux-kernel@vger.kernel.org Signed-off-by: Sean Paul Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/msm_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_iommu.c b/drivers/gpu/drm/msm/msm_iommu.c index b23d33622f37..2a90aa4caec0 100644 --- a/drivers/gpu/drm/msm/msm_iommu.c +++ b/drivers/gpu/drm/msm/msm_iommu.c @@ -66,7 +66,7 @@ static int msm_iommu_map(struct msm_mmu *mmu, uint64_t iova, // pm_runtime_get_sync(mmu->dev); ret = iommu_map_sg(iommu->domain, iova, sgt->sgl, sgt->nents, prot); // pm_runtime_put_sync(mmu->dev); - WARN_ON(ret < 0); + WARN_ON(!ret); return (ret == len) ? 0 : -EINVAL; } -- 2.19.1