Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp426205imu; Wed, 12 Dec 2018 20:34:42 -0800 (PST) X-Google-Smtp-Source: AFSGD/X5SAIfPvdmgt54zW1QVaySrsbAGJUnJt1txJ2bK5TnuIA9m3qoIX6H6s/7rlNqtSbQt8YT X-Received: by 2002:a17:902:8c91:: with SMTP id t17mr21588641plo.119.1544675682767; Wed, 12 Dec 2018 20:34:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544675682; cv=none; d=google.com; s=arc-20160816; b=1IpcVEM46Juli2xYf+N5IqlN7Xe312K/XaNcug8OhYks0X77Z2IQDU0eskaL5Y+NXP LXet2QY7FZS3R36xpVA6JKeC2duPq6qqqe40JKzZrApfYu7bor8kW45Og1Bw/eMhcUcj fRnumB8y753lcfhSLFDy31uiCqXVuvpsD4uSSGeSlNLOrpqACPnBD+LxGH44C9TIyvkA DGuX98ZGEEwB1t7qhDBUVivQ1T9yztLab+kI5yGajU75LeYun7CrOedewoOe+FRQIHzo q9HTbrXaPGXcX0OKQnFzHWGMoIGcKWjelMu+Hd3Siucd3IPQodzvDNb+uuTKsooRuRoP E+Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=C5/ASTIK9ZKfyXzBtlJ3KxydnYd8L8xs1IBlmYBQgvU=; b=tlHFtdGh6Iaqam/+Getd/Iecgvm5dGa2mZgwGxzUk0z9VlkwtXONNG3Jk+uW1JQ0lv rQD3MTokcsOUcwnsWS67OQoq43/j2LlVbaJdMvlHpuD30BJzU+J6X9I5EohifWl1TBlB g/HCmh5tjfccEz+OmRYAY+w66GxcP69g4FgPlwouLHtxi78RHPlL+BMBbYrUMhWwT7Dm WioR9nU7gWzRXy+EXShjhEdTKuyp+LPafaXv/HDYXgrk03s20CKBTO1nOdL1Zg18VwAw B7vUXbItXvjmOeZRrmtD35d+c8TppnAGV7Z2Xk3XsjGV+FHo9q+wnvv5H9VYX609rRlB vu0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=akI1nxPY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g26si653982pfi.184.2018.12.12.20.34.28; Wed, 12 Dec 2018 20:34:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=akI1nxPY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729206AbeLMEc4 (ORCPT + 99 others); Wed, 12 Dec 2018 23:32:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:45694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726465AbeLMEcu (ORCPT ); Wed, 12 Dec 2018 23:32:50 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9205320879; Thu, 13 Dec 2018 04:32:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544675570; bh=P8FJaj+ZbPNh46pQqM3sch+2BOPlHiPNoYHMUQ86CoI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=akI1nxPYV0Jd4n8bGTomZn9L3JM3/Iln6hkz3GKb2WYC+ff0R10skghJ51Rd9O6e9 qnhJsZ4NZBMkKrse4OuAx5rVN5ALBpe3FDEeUtO3KkCqhgfH+HWWprW+hJ13krRP4A +ArLhRVwjspEsJD8mVTDl0vgBltG5T0tR1Xb3/QE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Steve French , Sasha Levin , linux-cifs@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 29/34] cifs: In Kconfig CONFIG_CIFS_POSIX needs depends on legacy (insecure cifs) Date: Wed, 12 Dec 2018 23:31:55 -0500 Message-Id: <20181213043200.76295-29-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181213043200.76295-1-sashal@kernel.org> References: <20181213043200.76295-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Steve French [ Upstream commit 6e785302dad32228819d8066e5376acd15d0e6ba ] Missing a dependency. Shouldn't show cifs posix extensions in Kconfig if CONFIG_CIFS_ALLOW_INSECURE_DIALECTS (ie SMB1 protocol) is disabled. Signed-off-by: Steve French Reviewed-by: Pavel Shilovsky Signed-off-by: Sasha Levin --- fs/cifs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig index e7b478b49985..8bef27b8f85d 100644 --- a/fs/cifs/Kconfig +++ b/fs/cifs/Kconfig @@ -111,7 +111,7 @@ config CIFS_XATTR config CIFS_POSIX bool "CIFS POSIX Extensions" - depends on CIFS_XATTR + depends on CIFS && CIFS_ALLOW_INSECURE_LEGACY && CIFS_XATTR help Enabling this option will cause the cifs client to attempt to negotiate a newer dialect with servers, such as Samba 3.0.5 -- 2.19.1