Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp563886imu; Thu, 13 Dec 2018 00:03:34 -0800 (PST) X-Google-Smtp-Source: AFSGD/V9fJQ+ocBPi9P7J2big6HdmYE5AWVzH0seBHbD6it43yr2dX7a/m6O/CfU0c/Ogx/JzOWh X-Received: by 2002:a63:d40a:: with SMTP id a10mr20654633pgh.394.1544688214292; Thu, 13 Dec 2018 00:03:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544688214; cv=none; d=google.com; s=arc-20160816; b=ZclqnRpkfsQ2xz+OWvwzwaox91CGNNmN3a30QNwLrynxQGC95OQDLGHR7hXI8iXAwi Ie+fTfk9doo7VZtzACVu+6cx/kOTH4u8wl+YARRFbFc4V5tQSYPmhyQrAiiTsA48vGba 1FvjkmaVy+U6dhard3ffLqo0Q9Dj8rXi83MKuX6gLlP1YmMUgznFspXenrW/h+doM8mP nVsAXqL0sMzKVjphDqGNqBUdck8qF0hc0JM9z7YTZQbJg+wL+4EBk+s5bV5gcjl+x8qZ JkJNMBO1XdqBWaH4TexCp367AUEQHFZYwILMrlRhPZBur/8oezgHdYqu0jv672JzuMhp 8CmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:message-id:date:thread-index:thread-topic:subject :cc:to:from:dkim-signature; bh=LJZjyU6ccTOZSxHhgeSPBJR+RPXSb4uuoAnZi2HyBRU=; b=hNjaebb94Uu7iGRlZBbzfZCIGAlFtGH2407/zanNQSd47xzsCKm9/jj/rkgGVPcLBf HjbWlrVIMDI6ErzvEpyBOMuoneEbscsvrZgBQOMoSrXch0lx6VaAf5wntRm2FSDWGyH7 GEnHZqgkWs5QmqQIuc/HCT/6r9d5E/ib77Utkwjq4TcSoCSLsT0exo7QvRy+fu+wvPN+ Uy18yIBAcYd3Tepu+qIDhSkFsF331vmYOl1uvlkfFkVXHU6LaW/DWTZYOCJLITsbNxeX s3Uy2jOSOyhO+IYG9u8K6CeCRh45ajMXDfN42iOztR42+lIO2iG1z6lCUTYPLv1RGGGi M16Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector1 header.b=kN4u46C+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3si984038plv.258.2018.12.13.00.03.08; Thu, 13 Dec 2018 00:03:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector1 header.b=kN4u46C+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726945AbeLMICQ (ORCPT + 99 others); Thu, 13 Dec 2018 03:02:16 -0500 Received: from mail-eopbgr80074.outbound.protection.outlook.com ([40.107.8.74]:2560 "EHLO EUR04-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726500AbeLMICP (ORCPT ); Thu, 13 Dec 2018 03:02:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LJZjyU6ccTOZSxHhgeSPBJR+RPXSb4uuoAnZi2HyBRU=; b=kN4u46C+kaBVZiUNGVuSaQbDIhqEvTT6kaV5Pbqexnx+NZF914dujGsWo8SD+350DpFD4XCThsSuF7yW37k7JtzpE8sPvOt3agP/DcEiStr6L5V5YtC96bN1ow6uDAou6sYj+Bzn82TS9lmOufcdaXXKV2m4hmD4PWZPeO3vg9w= Received: from AM0PR0402MB3570.eurprd04.prod.outlook.com (52.133.46.11) by AM0PR0402MB3890.eurprd04.prod.outlook.com (52.133.39.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1404.23; Thu, 13 Dec 2018 08:02:12 +0000 Received: from AM0PR0402MB3570.eurprd04.prod.outlook.com ([fe80::94f8:5fdd:f384:8af8]) by AM0PR0402MB3570.eurprd04.prod.outlook.com ([fe80::94f8:5fdd:f384:8af8%8]) with mapi id 15.20.1425.016; Thu, 13 Dec 2018 08:02:12 +0000 From: Richard Zhu To: "bhelgaas@google.com" , "lorenzo.pieralisi@arm.com" , "l.stach@pengutronix.de" , "andrew.smirnov@gmail.com" CC: "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Richard Zhu Subject: [v2] PCI: imx: make msi work without pcieportbus Thread-Topic: [v2] PCI: imx: make msi work without pcieportbus Thread-Index: AQHUkron3jfJ309qkk6cQky/juy8wQ== Date: Thu, 13 Dec 2018 08:02:11 +0000 Message-ID: <1544687042-16595-1-git-send-email-hongxing.zhu@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK2PR02CA0133.apcprd02.prod.outlook.com (2603:1096:202:16::17) To AM0PR0402MB3570.eurprd04.prod.outlook.com (2603:10a6:208:1c::11) authentication-results: spf=none (sender IP is ) smtp.mailfrom=hongxing.zhu@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM0PR0402MB3890;6:pNxNXvfZwQTQ4HRVQBdpa1KMy8CxxyuFrUeThBw29Q5E3qtYrONxtlnRbfD26wco1uRLSSmHndK7pvS4B+srK5Ca1qRB0/kQY/YcOSIrmyfw0chTNKkKUi3zDoHSKTpmoteNJbfUUCp7SELkDmmATgheYO3XzVSxXVv66lWK7d08o9FB+IxxI4D8HiRBW5vp8ll3HWQn+fEz7wU+vHVq+MWoUrok6upsk+h9v86HnfhE/06VbsMm7+RFAvCZSzMwddNdKnZ9dsNHRrpNZYwj0Cay+eRh/Qowxs1vXG2Qc03VMGv5M3/bLjK17uhnKAIXPWKad9hFxOhprcztgM58n+90agW39ISaiGRh6Ekgo19qgPn7kGSL6o2fHKYRTjGt4lTRpTxwbIrGQ5kKqQmVQ5fpmf7M16mUk9tB7IXQyj2mZXqU6NjkOJw0+DdTkDGSjxrJosRAeVCaKAUCrJk2wg==;5:iJynBbD4gAwKLNA2EQhmR1qBG5MvY8zJ/7FQXfFccY0/gLNhyaWLJ63W7b6h3rwlPDUXF48K6HXS8Xkz8VShk15Eh/wGKCsN12ZHrTWbAiDfWG7JVIDSPy22EooZ8N4yRtcFFQsnZE5ubkjXnGQPXZ/nLzrH1A6twvEQQcK9OEw=;7:NkdZbHm95OMkTCb+ZoZ8rZpAlCr1Los4tHceOfzFCKwhfwLxMfLAINLOXHzso6GIjv7wLoZVOzgmTAFuMik0sjrMaoI41y5If5r08e71vOavsBJ/edsymlMA971ucdOlHa225QWJCcehWt4CNUN1CQ== x-ms-office365-filtering-correlation-id: 7c635fd1-429c-4ced-d7c2-08d660d14981 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);SRVR:AM0PR0402MB3890; x-ms-traffictypediagnostic: AM0PR0402MB3890: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(3230021)(999002)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231475)(944501520)(52105112)(3002001)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123564045)(201708071742011)(7699051)(76991095);SRVR:AM0PR0402MB3890;BCL:0;PCL:0;RULEID:;SRVR:AM0PR0402MB3890; x-forefront-prvs: 088552DE73 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(136003)(346002)(366004)(376002)(396003)(39860400002)(189003)(199004)(186003)(2201001)(5660300001)(81166006)(386003)(26005)(6436002)(8676002)(6506007)(14454004)(575784001)(50226002)(81156014)(105586002)(86362001)(4326008)(52116002)(8936002)(106356001)(71190400001)(478600001)(6486002)(71200400001)(102836004)(68736007)(99286004)(66066001)(53936002)(6512007)(6116002)(3846002)(36756003)(2501003)(54906003)(256004)(25786009)(486006)(14444005)(7736002)(2616005)(39060400002)(476003)(2906002)(97736004)(316002)(110136005)(305945005);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR0402MB3890;H:AM0PR0402MB3570.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ofTFTgiqRwBm9PwPD8st8UaOG6TVv1Pjw/BIoL6eaJz6uiFlWigrxLIe/fS1XHNA8C6MS8yWujNdKoI5IUZoycajX91G0+JLnu3BjH3URqbpvbDNv1AKsD7mXuCvOaHYhgmay5GYJaxfNFIKvkTbsEuuy3RhfVRWuDk4+h6jYSmbnr1QN45CDw1PvD+eNHtnmruj1tCECpQtHm8IOEr8qSzTpk60OFelVi97eAHaAAjvfVwbSIVucdicSKA6tu+hicaI/1k5+tXd+Ueutv9bskXhVRVWMjYa5vpIhZw7hE72vBY67C+d9dkMe2P0as58 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c635fd1-429c-4ced-d7c2-08d660d14981 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2018 08:02:11.9893 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3890 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org MSI_EN of iMX PCIe RC would be asserted when PCIEPORTBUS driver is selected. Thus, the MSI works fine on iMX PCIe before. Assert it unconditionally when MSI is supported. Otherwise, the MSI wouldn't be triggered although the EP is present and the MSIs are assigned. Signed-off-by: Richard Zhu --- drivers/pci/controller/dwc/pci-imx6.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller= /dwc/pci-imx6.c index 26087b3..d3e4296 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -74,6 +74,7 @@ struct imx6_pcie { #define PHY_PLL_LOCK_WAIT_USLEEP_MAX 200 =20 /* PCIe Root Complex registers (memory-mapped) */ +#define PCI_MSI_CAP 0x50 #define PCIE_RC_LCR 0x7c #define PCIE_RC_LCR_MAX_LINK_SPEEDS_GEN1 0x1 #define PCIE_RC_LCR_MAX_LINK_SPEEDS_GEN2 0x2 @@ -926,6 +927,7 @@ static int imx6_pcie_probe(struct platform_device *pdev= ) struct resource *dbi_base; struct device_node *node =3D dev->of_node; int ret; + u16 val; =20 imx6_pcie =3D devm_kzalloc(dev, sizeof(*imx6_pcie), GFP_KERNEL); if (!imx6_pcie) @@ -1070,6 +1072,11 @@ static int imx6_pcie_probe(struct platform_device *p= dev) ret =3D imx6_add_pcie_port(imx6_pcie, pdev); if (ret < 0) return ret; + if (IS_ENABLED(CONFIG_PCI_MSI)) { + val =3D dw_pcie_readw_dbi(pci, PCI_MSI_CAP + PCI_MSI_FLAGS); + val |=3D PCI_MSI_FLAGS_ENABLE; + dw_pcie_writew_dbi(pci, PCI_MSI_CAP + PCI_MSI_FLAGS, val); + } =20 return 0; } --=20 2.7.4