Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp725210imu; Thu, 13 Dec 2018 03:27:23 -0800 (PST) X-Google-Smtp-Source: AFSGD/VhVLsl77PyfD1p32xV1SWu8mBGS3SMWjWTWxm9HKlwxxgyyOKRR7BECdW7GN7/7cQZ0unp X-Received: by 2002:a62:1d4c:: with SMTP id d73mr23943709pfd.90.1544700443686; Thu, 13 Dec 2018 03:27:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544700443; cv=none; d=google.com; s=arc-20160816; b=zuMRcE/30U2OJSbVu1ELqEWs5FlrR+LLAB732tB+Jz0OhSocmrkHgfMNfIWHea1ZWV nHZ6XRxKo+Dw6p+DF/+E0X488gYnHLgdcUD00Uok9MQIGwddnBupLrUImV2+j0fsoP62 s8i2LDTR72vD0B4KpneJheZ4CpP4YkTbCgTjrdGmqqZe9SwE7QIXL9BXhnOiHwTtFvNf jVJPfF9pzE2KBWkNW4Y3GNBs6LubtyL8jT9CePyAqaL3XxU60TPcVHXVeR1mhId/MAQf sfSgYr9DREMyiixtvG71T+vMaAETd9ANZnXqKAgzU1VdDtY3NpwwPBb9qlWmwWJ05jfk QAKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=0aoQQG2Yb89E3G5uxjGMAMIMC1duM9aMrvEJk7ZKYOw=; b=MbeHROcOiY7WQhSLEhjTlz1cHuHXnvwrhAzk/Td3g44/YbooGoJk4rjF1O+Pq3bM5F iT3HVI4jXMlb/dp9RlQDruMPgGU7IJG3bPGeXytglRuPMyZ6OHI32jBeNKDBZDHLoe0i ztgTS6vXJWuT5vl/c5NxytYercOhOulcszgXIuv/q722TJQ8ZctlqvNNILzB+e4/lxI1 aVi6CkI041ie5f+bHOWG2Al7FB3YgT47xuKLQ+ieVw6DEbh2vt/7MjKRLyesguzyG0ZS 0R3J4LEi+O2iKtepaPNx8lcSbVsoQLs82NrZO6hTUQwXuGRH3srZrGzKj8fgKo4waH5J Yt6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i20si1376799pgm.586.2018.12.13.03.27.08; Thu, 13 Dec 2018 03:27:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728732AbeLMLZM (ORCPT + 99 others); Thu, 13 Dec 2018 06:25:12 -0500 Received: from verein.lst.de ([213.95.11.211]:40318 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727871AbeLMLZM (ORCPT ); Thu, 13 Dec 2018 06:25:12 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id 1881668DD2; Thu, 13 Dec 2018 12:25:11 +0100 (CET) Date: Thu, 13 Dec 2018 12:25:11 +0100 From: Christoph Hellwig To: Christian Zigotzky Cc: Christoph Hellwig , linux-arch@vger.kernel.org, Darren Stevens , linux-kernel@vger.kernel.org, Julian Margetson , linux-mm@kvack.org, iommu@lists.linux-foundation.org, Paul Mackerras , Olof Johansson , linuxppc-dev@lists.ozlabs.org Subject: Re: use generic DMA mapping code in powerpc V4 Message-ID: <20181213112511.GA4574@lst.de> References: <1ecb7692-f3fb-a246-91f9-2db1b9496305@xenosoft.de> <6c997c03-e072-97a9-8ae0-38a4363df919@xenosoft.de> <4cfb3f26-74e1-db01-b014-759f188bb5a6@xenosoft.de> <82879d3f-83de-6438-c1d6-49c571dcb671@xenosoft.de> <20181212141556.GA4801@lst.de> <2242B4B2-6311-492E-BFF9-6740E36EC6D4@xenosoft.de> <84558d7f-5a7f-5219-0c3a-045e6b4c494f@xenosoft.de> <20181213091021.GA2106@lst.de> <835bd119-081e-a5ea-1899-189d439c83d6@xenosoft.de> <76bc684a-b4d2-1d26-f18d-f5c9ba65978c@xenosoft.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <76bc684a-b4d2-1d26-f18d-f5c9ba65978c@xenosoft.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 13, 2018 at 12:19:26PM +0100, Christian Zigotzky wrote: > I tried it again but I get the following error message: > > MODPOST vmlinux.o > arch/powerpc/kernel/dma-iommu.o: In function `.dma_iommu_get_required_mask': > (.text+0x274): undefined reference to `.dma_direct_get_required_mask' > make: *** [vmlinux] Error 1 Sorry, you need this one liner before all the patches posted last time: diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index d8819e3a1eb1..7e78c2798f2f 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -154,6 +154,7 @@ config PPC select CLONE_BACKWARDS select DCACHE_WORD_ACCESS if PPC64 && CPU_LITTLE_ENDIAN select DYNAMIC_FTRACE if FUNCTION_TRACER + select DMA_DIRECT_OPS select EDAC_ATOMIC_SCRUB select EDAC_SUPPORT select GENERIC_ATOMIC64 if PPC32