Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp836034imu; Thu, 13 Dec 2018 05:23:14 -0800 (PST) X-Google-Smtp-Source: AFSGD/ULYzgkxMauTa8mvbD2JA2ixEcb1ulPds9ROgAr1/i7wooWgVhDnDvBCPlYUoJYQInV3dIT X-Received: by 2002:a65:41c2:: with SMTP id b2mr21654335pgq.67.1544707394218; Thu, 13 Dec 2018 05:23:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544707394; cv=none; d=google.com; s=arc-20160816; b=bvI3loHz7J6tXbaHW4V3UvEjwanOxiJjOkrA6kgKMp8d5ppry4llWOc+QUnvYDW0nM eFz17sEqCEXk8fHrVV5cbLinJZeZ4gSxB6fBd5Lx0+AA3gpU9zA0ZUZpSnw2mj+kSpca 7q2xRdeyfkdHK+PFlaEl8OdZFb59OtIdh1BMlobUiyd/+ogdEivChRHnWa53yXtYfszn T6603X0pprwjBLV2QMMFzXjo2HI/hw/wnKZ/lwZPet+KI4BVytzWOJW8VNPZcO4ysZta KsV0TXiFFkuvs+L5iAmcJgMLUKK5rQnIe+TVqsCD0d2H1UtGUfOWStMbDYJcU4sLgYpK D3Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=D/SYV24iLaqgpZ/h3tavYKQaN/FuCRi+YdbFT+PGgqY=; b=O2NPflXl8WtxgMLAAkSa4W9UMLY+FvVHLjvFiMI1p9J4b03nhcseq48s8mglyE8GaH /1PHQuC9vCNblPZADv1n2USS7fZ8HqtTwcrzWc6dLwuWmUeAb1FqGt6bxUgGCiunlVPC NSFTeRBF2gfmiB7B+9CArdM8Utc5uCALU27lGiUWmD1HV5Xq62C62k/vnQH3H5VjrtNq 62Gg3/Vt1FW8E0/Xs8xlE2EdCBOKZRq7uZTDOdJdvCWLzDGJkj2/J65P1jUrwaGY07d0 EPGp2bhyLMvVtk8zd2o6hKZNCOPUXM2V3Xh/c7N5ZoLEDpeuAbw0cwfK7cSmSARdHreq tn4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PbpIrCD4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d8si1475598pgl.386.2018.12.13.05.22.58; Thu, 13 Dec 2018 05:23:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PbpIrCD4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729359AbeLMNVa (ORCPT + 99 others); Thu, 13 Dec 2018 08:21:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:49828 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729265AbeLMNVa (ORCPT ); Thu, 13 Dec 2018 08:21:30 -0500 Received: from quaco.ghostprotocols.net (unknown [190.15.121.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8CB0E2086D; Thu, 13 Dec 2018 13:21:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544707288; bh=h6raYjVwHZoGVpoB6nODs9Vpyy4q63y2vA5/OdC5E2s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PbpIrCD4q3POl5LUWTwhHkO/EJPEYrsO8payjHhVl37ioxeL+qo0q3ykFGq/VGDTp 9j7xKc03OO22+8EKoB/BVzPt0iyAC6SB9qDDo2LPisBaLNG9pV0U0Efub2i/URyzW3 asuk2Al18c7BSG1eKhZk3bGeWeTJaUk40Xj2Xe/0= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 490D141B1D; Thu, 13 Dec 2018 10:21:26 -0300 (-03) Date: Thu, 13 Dec 2018 10:21:26 -0300 From: Arnaldo Carvalho de Melo To: leo.yan@linaro.org Cc: Mathieu Poirier , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Coresight ML , Mike Leach , Robert Walker Subject: Re: [PATCH v3 6/8] perf cs-etm: Treat NO_SYNC element as trace discontinuity Message-ID: <20181213132126.GI21027@kernel.org> References: <1544513908-16805-1-git-send-email-leo.yan@linaro.org> <1544513908-16805-7-git-send-email-leo.yan@linaro.org> <20181213123854.GE21027@kernel.org> <20181213124154.GF21027@kernel.org> <20181213130949.GB17663@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181213130949.GB17663@leoy-ThinkPad-X240s> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Dec 13, 2018 at 09:09:49PM +0800, leo.yan@linaro.org escreveu: > Hi Arnaldo, > > On Thu, Dec 13, 2018 at 09:41:54AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Thu, Dec 13, 2018 at 09:38:54AM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Tue, Dec 11, 2018 at 03:38:26PM +0800, Leo Yan escreveu: > > > > CoreSight tracer driver might insert barrier packet between different > > > > buffers, thus the decoder can spot the boundaries based on the barrier > > > > packet; the decoder is possible to hit a barrier packet and emit a > > > > NO_SYNC element, then the decoder will find a periodic synchronisation > > > > point inside that next trace block that starts trace again but does not > > > > have the TRACE_ON element as indicator - usually because this block of > > > > trace has wrapped the buffer so we have lost the original point that > > > > trace was enabled. > > > > > > > > In upper case, it results in the trace stream only inserts the > > > > OCSD_GEN_TRC_ELEM_NO_SYNC element in the middle of tracing stream, but > > > > we don't handle NO_SYNC element properly and at the end users miss to > > > > see the info for trace discontinuity. > > > > > > > > > "In upper case"? Maybe: > > > > > > In the former case it causes the insertion of a OCSD_GEN_TRC_ELEM_NO_SYNC > > > in the middle of the the tracing stream, but as we were npt handling the > > > NO_SYNC element properly which ends up making users miss the > > > discontinuity indication"? > > > > > > Though OCSD_GEN_TRC_ELEM_NO_SYNC is different from CS_ETM_TRACE_ON when > > > > output from the decoder, but both of them indicate the trace data is > > > > > > can we remove the "but" and "of them" (redundant) above? > > > > > > > discontinuous; this patch treats OCSD_GEN_TRC_ELEM_NO_SYNC as trace > > > a > > > > discontinuity and generates CS_ETM_DISCONTINUITY packet for it, so > > > > cs-etm can handle discontinuity for this case, finally it saves the last > > > it (way too many "discontinuity") > > > > trace data for previous trace block and restart samples for new block. > > > > I've tentatively done those changes (and a few more) in my local branch, > > resulting in the wording below, plese let me know if you are ok with it: > > Very appreciate your helping. Please see some minor typos in below > commit: > > > commit 148068b45fe2e93b19c06cfc1140ea12ca72eb59 > > Author: Leo Yan > > Date: Tue Dec 11 15:38:26 2018 +0800 > > > > perf cs-etm: Treat NO_SYNC element as trace discontinuity > > > > The CoreSight tracer driver might insert a barrier packets between > packet I'll remove the 'a' instead, ok? > > different buffers, thus the decoder can spot the boundaries based on the > > barrier packet; it is possible for the decoder to hit a barrier packet > > and emit a NO_SYNC element, then the decoder will find a periodic > > synchronisation point inside that next trace block that starts the trace > > again but does not have the TRACE_ON element as indicator - usually > > because this trace block has wrapped the buffer so we have lost the > > original point when the trace was enabled. > > > > In the first case it causes the insertion of a OCSD_GEN_TRC_ELEM_NO_SYNC > former > > in the middle of the the tracing stream, but as we were npt handling the > not > > NO_SYNC element properly which ends up making users miss the > > discontinuity indication"? > s/?/. > > Thanks a lot for helping. If you prefer me to resend the patch set, > also let me know. I can fix it, here. > > Though OCSD_GEN_TRC_ELEM_NO_SYNC is different from CS_ETM_TRACE_ON when > > output from the decoder, both indicate that the trace data is > > discontinuous; this patch treats OCSD_GEN_TRC_ELEM_NO_SYNC as a trace > > discontinuity and generates a CS_ETM_DISCONTINUITY packet for it, so > > cs-etm can handle the discontinuity for this case, finally it saves the > > last trace data for the previous trace block and restart samples for the > > new block. > > > > Signed-off-by: Leo Yan > > Reviewed-by: Mathieu Poirier > > Cc: Alexander Shishkin > > Cc: Jiri Olsa > > Cc: Mike Leach > > Cc: Namhyung Kim > > Cc: Robert Walker > > Cc: coresight ml > > Cc: linux-arm-kernel@lists.infradead.org > > Link: http://lkml.kernel.org/r/1544513908-16805-7-git-send-email-leo.yan@linaro.org > > Signed-off-by: Arnaldo Carvalho de Melo > > > > diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > > index 1039f364f4cc..bee026e76a4c 100644 > > --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > > +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > > @@ -410,7 +410,6 @@ static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer( > > case OCSD_GEN_TRC_ELEM_UNKNOWN: > > break; > > case OCSD_GEN_TRC_ELEM_NO_SYNC: > > - break; > > case OCSD_GEN_TRC_ELEM_TRACE_ON: > > resp = cs_etm_decoder__buffer_discontinuity(decoder, > > trace_chan_id); > > > > -- - Arnaldo