Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp916480imu; Thu, 13 Dec 2018 06:36:01 -0800 (PST) X-Google-Smtp-Source: AFSGD/WuxI8Q6ifKeYOubuhbUVdyPzmkyWrU7fp0k71/hi0gFrnRa2y2XHFKxyhgoUDRoIcj9yTr X-Received: by 2002:a63:e21:: with SMTP id d33mr857241pgl.272.1544711761764; Thu, 13 Dec 2018 06:36:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544711761; cv=none; d=google.com; s=arc-20160816; b=XcwPRS6u6BxaN6I/ggUU8X0B2hU6y/u1M8DinB7QNyYmTgzEzhUHxSzko5sKznF6AH MccjetPXiUE/RwedYAm8BR3Vx5FIJm7qHsJ9Xwpx3RxAmlZRI31Pn/R9yNl1+TEjGVFy 2wqBut1qCGkpDTccTnQsOfl4K3NUphh066kNM/T5Gf9xz5Lacd34r5XFSzQGVXVw/jkf 17YZV422yRZX0JD/TDa8Z1N5uCwADp91nVj81zhLPMC2bCcnd5BZ3XOjiW9Lvj/NlwFu hYjWv6dexjBmRbq1rGOWfjtHVxuX3qeUk1bYN3orrYUVv73032mJFAJ1I2OFP1n4Od+V qNhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=roW9lQb/WY2E5rvnA07vQ80BIMkgeozGb87sSR5wheM=; b=ZHcLjpDYmouhTiB8KZkVrQXG93oa14GH/Tt+QY6BDd1J+ElL48JEfNs2rm3OPqVZ92 T/TNYcVzHtPlNGBxTNBTed1J4zhxYSY73Npkqjx/JA1MYuOuyFPo5YgYTjb+yjqMGxId 12ptI/dNey4NGqK+gPAlZw6VxgJ5C3l+7jI0ivGSCvPEv/wX0eiC2xZ0+WWD7sveD3Ln n8WuKUkiA2/hhCPuqVjSiokLQpgy1DXnmW0GD3ibOUA+Bkb5Je5s7ziPkxDQw5VHh/lC Sp6By39pOC4IRHx7ryCNbznbHQ1k1t27hIWGG2wuXiFvVCVGVgn1SHLwh04KxMNpX6i9 1IMA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 9si1640320pgm.112.2018.12.13.06.35.46; Thu, 13 Dec 2018 06:36:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728757AbeLMOdV convert rfc822-to-8bit (ORCPT + 99 others); Thu, 13 Dec 2018 09:33:21 -0500 Received: from mail.bootlin.com ([62.4.15.54]:53752 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727947AbeLMOdV (ORCPT ); Thu, 13 Dec 2018 09:33:21 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 307032079D; Thu, 13 Dec 2018 15:33:18 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.2 Received: from xps13 (unknown [91.224.148.103]) by mail.bootlin.com (Postfix) with ESMTPSA id 4F74D20510; Thu, 13 Dec 2018 15:33:07 +0100 (CET) Date: Thu, 13 Dec 2018 15:33:06 +0100 From: Miquel Raynal To: Gregory Clement , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , Bjorn Helgaas Cc: , Rob Herring , Mark Rutland , Lorenzo Pieralisi , linux-pci@vger.kernel.org, , , Antoine Tenart , Maxime Chevallier , Nadav Haklai Subject: Re: [PATCH v2 10/12] ARM64: dts: marvell: armada-3720-espressobin: declare PCIe reset GPIO Message-ID: <20181213153306.4fc3b511@xps13> In-Reply-To: <20181212102142.16053-11-miquel.raynal@bootlin.com> References: <20181212102142.16053-1-miquel.raynal@bootlin.com> <20181212102142.16053-11-miquel.raynal@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Miquel Raynal wrote on Wed, 12 Dec 2018 11:21:40 +0100: > Add a reset-gpios property to the PCIe node. > > Signed-off-by: Miquel Raynal > --- > arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts > index 094994a9c68e..76a508da80b9 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts > @@ -46,6 +46,9 @@ > /* J9 */ > &pcie0 { > status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pcie_pins>; > + reset-gpios = <&gpiosb 3 GPIO_ACTIVE_HIGH>; > }; > > /* J6 */ While this change may be fine for platforms based on Armada 3700 SoC, it is not for the EspressoBin that has no reset GPIO for PCIe and instead uses this pin to control the Ethenet switch. I will re-send a series without this patch. I think it does not hurt to keep the previous patch adding the pinmux setting in the Armada-37xx.dtsi file even without using it, so I will drop only this patch. Thanks, Miquèl