Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Abel Vesa <abel.vesa@nxp.com>
To:     Lucas Stach <l.stach@pengutronix.de>
CC:     Shawn Guo <shawnguo@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Olof Johansson <olof@lixom.net>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>, Rob Herring <robh@kernel.org>,
        Will Deacon <will.deacon@arm.com>,
        Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH 1/3] arm64: Remove CONFIG_SOC_IMX8MQ and use ARCH_MXC
 instead
Thread-Topic: [PATCH 1/3] arm64: Remove CONFIG_SOC_IMX8MQ and use ARCH_MXC
 instead
Thread-Index: AQHUkuY6nb3Z7jYWIkKip6q0zf3chKV8vGGAgAAEk4A=
Date:   Thu, 13 Dec 2018 14:51:50 +0000
Message-ID: <20181213145149.6hyyhi6hxdzvikl4@fsr-ub1664-175>
References: <1544707047-4417-1-git-send-email-abel.vesa@nxp.com>
 <1544707047-4417-2-git-send-email-abel.vesa@nxp.com>
 <1544711727.3137.32.camel@pengutronix.de>
In-Reply-To: <1544711727.3137.32.camel@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <082F7D1FEA76734388BB953E3B4BA78D@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b53fc92-94c6-468a-c5b9-08d6610a83f3
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2018 14:51:50.9681
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3899
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 18-12-13 15:35:27, Lucas Stach wrote:
> Am Donnerstag, den 13.12.2018, 13:17 +0000 schrieb Abel Vesa:
> > To keep aligned with arm64, remove the unnecessary SOC_IMX8MQ and use
> > ARCH_MXC instead.
> >=20
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > ---
> > =A0arch/arm64/Kconfig.platforms=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0| 8 ---=
-----
> > =A0arch/arm64/boot/dts/freescale/Makefile | 2 +-
> > =A0drivers/clk/imx/Makefile=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0| 3 ++-
> > =A0drivers/phy/freescale/Kconfig=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0| 2 +-
> > =A0drivers/pinctrl/freescale/Kconfig=A0=A0=A0=A0=A0=A0| 2 +-
> > =A0drivers/soc/imx/Kconfig=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0| 2 +-
> > =A06 files changed, 6 insertions(+), 13 deletions(-)
> >=20
> > diff --git a/arch/arm64/Kconfig.platforms
> > b/arch/arm64/Kconfig.platforms
> > index 7e1545a..318dbb9 100644
> > --- a/arch/arm64/Kconfig.platforms
> > +++ b/arch/arm64/Kconfig.platforms
> > @@ -148,14 +148,6 @@ config ARCH_MXC
> > =A0	=A0=A0This enables support for the ARMv8 based SoCs in the
> > =A0	=A0=A0NXP i.MX family.
> > =A0
> > -config SOC_IMX8MQ
> > -	bool "i.MX8MQ support"
> > -	depends on ARCH_MXC
> > -	select ARM64_ERRATUM_843419
> > -	select ARM64_ERRATUM_845719
> > -	help
> > -	=A0=A0This enables support for the i.MX8MQ SoC.
> > -
>=20
> NACK on this one. Having a single place where stuff that is absolutely
> critical for proper SoC operation can be selected is very useful and
> avoids hard to debug issues due to slightly wrong configs in the long
> run.

As mentioned in the cover letter, please ignore this patch set entirely.
The ARCH_MXC is actually used on arm32 too, so it won't work.

I'm working on a patchset that will add the Kconfig into=20
drivers/clk/imx/ and in it will add CLK_IMX8MQ. That will
fix the clock dependency since the CLK_IMX8MQ will depend on
ARCH_MXC and ARM64. I believe the CLK_IMX8QXP will follow
the same pattern.

As for the SOC_IMX8MQ, all the other vendors have one single
config for all the arm64 platforms. TBH, to control every SoC
independently it's a little bit of an overkill.

But maybe I'm the only one who thinks so.

>=20
> Regards,
> Lucas
>=20
> > =A0config ARCH_QCOM
> > =A0	bool "Qualcomm Platforms"
> > =A0	select GPIOLIB
> > diff --git a/arch/arm64/boot/dts/freescale/Makefile
> > b/arch/arm64/boot/dts/freescale/Makefile
> > index 0001361..f9be242 100644
> > --- a/arch/arm64/boot/dts/freescale/Makefile
> > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > @@ -19,4 +19,4 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) +=3D fsl-ls2088a-
> > rdb.dtb
> > =A0dtb-$(CONFIG_ARCH_LAYERSCAPE) +=3D fsl-lx2160a-qds.dtb
> > =A0dtb-$(CONFIG_ARCH_LAYERSCAPE) +=3D fsl-lx2160a-rdb.dtb
> > =A0
> > -dtb-$(CONFIG_SOC_IMX8MQ) +=3D imx8mq-evk.dtb
> > +dtb-$(CONFIG_ARCH_MXC) +=3D imx8mq-evk.dtb
> > diff --git a/drivers/clk/imx/Makefile b/drivers/clk/imx/Makefile
> > index 5c0b11e..62a1882 100644
> > --- a/drivers/clk/imx/Makefile
> > +++ b/drivers/clk/imx/Makefile
> > @@ -34,5 +34,6 @@ obj-$(CONFIG_SOC_IMX6SX) +=3D clk-imx6sx.o
> > =A0obj-$(CONFIG_SOC_IMX6UL) +=3D clk-imx6ul.o
> > =A0obj-$(CONFIG_SOC_IMX7D)=A0=A0+=3D clk-imx7d.o
> > =A0obj-$(CONFIG_SOC_IMX7ULP) +=3D clk-imx7ulp.o
> > -obj-$(CONFIG_SOC_IMX8MQ) +=3D clk-imx8mq.o
> > =A0obj-$(CONFIG_SOC_VF610)=A0=A0+=3D clk-vf610.o
> > +
> > +obj-$(CONFIG_ARCH_MXC) +=3D clk-imx8mq.o
> > diff --git a/drivers/phy/freescale/Kconfig
> > b/drivers/phy/freescale/Kconfig
> > index f050bd4..923c0ef 100644
> > --- a/drivers/phy/freescale/Kconfig
> > +++ b/drivers/phy/freescale/Kconfig
> > @@ -2,4 +2,4 @@ config PHY_FSL_IMX8MQ_USB
> > =A0	tristate "Freescale i.MX8M USB3 PHY"
> > =A0	depends on OF && HAS_IOMEM
> > =A0	select GENERIC_PHY
> > -	default SOC_IMX8MQ
> > +	default ARCH_MXC
> > diff --git a/drivers/pinctrl/freescale/Kconfig
> > b/drivers/pinctrl/freescale/Kconfig
> > index 2d6db43..9874a16 100644
> > --- a/drivers/pinctrl/freescale/Kconfig
> > +++ b/drivers/pinctrl/freescale/Kconfig
> > @@ -123,7 +123,7 @@ config PINCTRL_IMX7ULP
> > =A0
> > =A0config PINCTRL_IMX8MQ
> > =A0	bool "IMX8MQ pinctrl driver"
> > -	depends on SOC_IMX8MQ
> > +	depends on ARCH_MXC
> > =A0	select PINCTRL_IMX
> > =A0	help
> > =A0	=A0=A0Say Y here to enable the imx8mq pinctrl driver
> > diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
> > index 2112d18..7ffbb6b 100644
> > --- a/drivers/soc/imx/Kconfig
> > +++ b/drivers/soc/imx/Kconfig
> > @@ -2,7 +2,7 @@ menu "i.MX SoC drivers"
> > =A0
> > =A0config IMX_GPCV2_PM_DOMAINS
> > =A0	bool "i.MX GPCv2 PM domains"
> > -	depends on SOC_IMX7D || SOC_IMX8MQ || (COMPILE_TEST && OF)
> > +	depends on SOC_IMX7D || ARCH_MXC || (COMPILE_TEST && OF)
> > =A0	depends on PM
> > =A0	select PM_GENERIC_DOMAINS
> > =A0	default y if SOC_IMX7D=