Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp947567imu; Thu, 13 Dec 2018 07:05:14 -0800 (PST) X-Google-Smtp-Source: AFSGD/VeczqK2QGTQyjKAFJKTysk+57ZCXs7kWhpTCelqUVW0sfmp+GGMhJmBbLqoZA+e5QgsPzA X-Received: by 2002:a62:7dcb:: with SMTP id y194mr24589783pfc.113.1544713514552; Thu, 13 Dec 2018 07:05:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544713514; cv=none; d=google.com; s=arc-20160816; b=DDzSHTzTkpLcY0VW5WqBTBZ2eszqwv+p5q1hWqfMB3UtRNT4WpaTj3njawebM+8aww cVx03QS1PGtoORUn19YNKxDGqIC/qtgJ8k+JQvIZlGAKhbJ3flLqLmxgkRtMPD3sdQeD rLLxl0JksC1+gBrhi/yaowaY6ry3W3Am+IgVMc8A5uiXIQeyWMv96xq78ohxQeEyhWXc kyxvXtK2lqmV/EGhZp7oneKeosH93GalwEFWvJXTSDqMH8VAHQRdB2o1fo2/2UOYVmy5 TVmsZd0pKYM/ScRShhIetgNPBOYaWGZ0mcy0Iq2RaKSAcxuf/mj0NgIscgE0fGUJ+HQ+ z6uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=i5Ls1IHmEgKFFwfjaIn0O3iLtjnVm1GVjxCYNzCFapM=; b=H7yLluzazGWICzNHAVbuHekVTs6ykrULZqrofa0x5/nwxjJsJQhFx7dixSTTTTXwRE SPc/NbqJGeB0AOwx2p/S76zNlsbSzFOg+nSUOA3Mnn3tYUN/FzYstL+sBB6mLugKKVxZ FZOY7oAqCVsZOjPlH9d4gE1LZzP4c5EVcOdwGNiCqXcUWoWrfBS2ZqAPwW6u6hPnvVmm Wups5XFX2buuXAjgDXe6U6JGq7o/rF622SMePb0w1gE1kXb+h4m79oySDV5xmdvhAx5L oRPwOU2mT8KZ3NByNM/w9S3X7WCaU8ipybJMLY3vEI9km3xEzuXxgm0H9uTPWLojjhVo aZtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=hykeMyEM; dkim=pass header.i=@codeaurora.org header.s=default header.b=I4HOuMX4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j21si1606814pll.150.2018.12.13.07.04.51; Thu, 13 Dec 2018 07:05:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=hykeMyEM; dkim=pass header.i=@codeaurora.org header.s=default header.b=I4HOuMX4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729372AbeLMPD3 (ORCPT + 99 others); Thu, 13 Dec 2018 10:03:29 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:53496 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727791AbeLMPD2 (ORCPT ); Thu, 13 Dec 2018 10:03:28 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id D14DF60735; Thu, 13 Dec 2018 15:03:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1544713407; bh=1aiwPgfEWXSfAE2Zg7C277hozC8g2Yp9+ekM/vTlpUY=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=hykeMyEM08v4pueOSVgB/lIJwArAmPg3B/cb45hrInctJKSvXqGhR6vPP1mml2IxW US+h9AmTnEt5TidpAUBjVq+5042DMLb/JBjFxZ+eehqS0G56TDHu89/1i+HG1C3mua /7l4t/Yh7GUgvMBstsubw5OX4MBA183FsjO0yR3g= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 574926013C; Thu, 13 Dec 2018 15:03:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1544713407; bh=1aiwPgfEWXSfAE2Zg7C277hozC8g2Yp9+ekM/vTlpUY=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=I4HOuMX4oLyLDZcnyZCmeTqnXUy9zc0jpNAAnCF8AjIH4YeZ8Nj8lJxruLNL2basF mGNb9vLnQkj03YbvAGP2bDExPTeM4pJNylexVmKiYLi5Jq0CUqzi0fynqYwgEdng1S 7NyFYLBjoCly/gbvqzyB0X2W4aeAZSeDbFck12K8= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 574926013C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtl818x: fix potential use after free From: Kalle Valo In-Reply-To: <1543488490-101743-1-git-send-email-bianpan2016@163.com> References: <1543488490-101743-1-git-send-email-bianpan2016@163.com> To: Pan Bian Cc: Herton Ronaldo Krzesinski , Hin-Tak Leung , Larry Finger , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Pan Bian User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20181213150327.D14DF60735@smtp.codeaurora.org> Date: Thu, 13 Dec 2018 15:03:27 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pan Bian wrote: > entry is released via usb_put_urb just after calling usb_submit_urb. > However, entry is used if the submission fails, resulting in a use after > free bug. The patch fixes this. > > Signed-off-by: Pan Bian > ACKed-by: Larry Finger Patch applied to wireless-drivers-next.git, thanks. afbb1947db94 rtl818x: fix potential use after free -- https://patchwork.kernel.org/patch/10704331/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches