Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 13 Dec 2018 17:14:23 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Joe Perches <joe@perches.com>
Cc:     Jeremy Cline <jcline@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jonathan Corbet <corbet@lwn.net>,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] scripts/spdxcheck.py: Always open files in binary
 mode
Message-ID: <20181213161423.GB13531@ulmo>
References: <20181212131210.28024-1-thierry.reding@gmail.com>
 <20181212181410.GC2352@laptop.jcline.org>
 <642dd9ea144c03041ad74b14777553fe652acd1a.camel@perches.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="EuxKj2iCbKjpUGkD"
Content-Disposition: inline
In-Reply-To: <642dd9ea144c03041ad74b14777553fe652acd1a.camel@perches.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--EuxKj2iCbKjpUGkD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 12, 2018 at 06:51:19PM -0800, Joe Perches wrote:
> On Wed, 2018-12-12 at 13:14 -0500, Jeremy Cline wrote:
> > It might be worth noting this fixes commit 6f4d29df66ac
> > ("scripts/spdxcheck.py: make python3 compliant")
>=20
> umm, how does it do that?
>=20
> > and also Cc this for
> > stable since 6f4d29df66ac got backported to v4.19. While that commit
> > did indeed make the script work with Python 3 for piping data, it broke
> > Python 2 and made its way to stable.
>=20
> I think attempting to use spdxcheck on binary files
> is not useful in the first place.

Agreed. However, if run without arguments the tool will walk the entire
tree and inevitably run into binary files. I realize that this is kind
of a lame way of dealing with binary files, but the alternatives would
be much more complicated and involve dealing with mimetypes and such.

Thierry

--EuxKj2iCbKjpUGkD
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlwShV8ACgkQ3SOs138+
s6G2ihAArS30f0Z6GO/6ezyyJ7cMvAmNCSNBudE+d9bIbQ/F+T+tv15ENs8wQ3Kt
yYZQ9DaaKZ7fCEFkw1T+hmwbnD0xmy8vKZvHA1M18SIueGcv+tUEULW80Fp1ZBS2
QUsHfKwJmGNbVsETLtSBTNYhYhJhXqzq2d6i9uHUKrGNOtIPY5ztQRCnNEbhLQC9
QcuKZAoks2dECk1nDy0+xcenzzdVpco+PS5aNezNhVckugvXM19NHx0c7XVkxWwL
bmoUSMy6mrvkaONBvxX1pfgRp2V5hMgHfy2o/j7J9ddmOfj4KBXb1DWM2+sGVIRe
fjBYx7N2PJ32ZUn5xVWALcQY71Ih4x7Pk4+XJz3l9yA/QNehe2Dom78+Fhuut4uq
dQhGbaP+NU6gDlXJAWflzsn3i0M+jt9raXXa9Bs9rGxU7F0ru+EUkxNJBo7mjfbX
wP+8/DIphee13MPNuzBLjOj4+qxAUmBuorsetEhpWShBac8gWjraTofA1O494p3z
YFGMq79AvVtXKnIYkh6NwmnaNJy/H1vx4t3aBCexbXmXQ5uWCYN7BjkDRJFOtWiN
xegxvWqy0vjKLZM+uy+xw9pJFxv/k9wvfRVCdOCkERyWRTtSWtW2Psu/H7y0d+hd
6NUB4O+hBg7Evc2OZNb07lAVJ5/mflCCf9dcnTwp8NjJOiJxmwU=
=0vKG
-----END PGP SIGNATURE-----

--EuxKj2iCbKjpUGkD--