Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1544705183-13288-1-git-send-email-stefan.popa@analog.com> <1544705183-13288-2-git-send-email-stefan.popa@analog.com>
In-Reply-To: <1544705183-13288-2-git-send-email-stefan.popa@analog.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Thu, 13 Dec 2018 09:37:57 -0600
Message-ID: <CAL_JsqLMF=uf5Dcrfz_57KwYK9XDtJamGtf23JiUMDH-F6xa7w@mail.gmail.com>
Subject: Re: [PATCH 01/11] staging: iio: adc: ad7606: Simplify the Kconfing menu
To:     Stefan Popa <stefan.popa@analog.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald <pmeerw@pmeerw.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
        Stefan Popa <stefan.popa@analog.co>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Dec 13, 2018 at 8:18 AM Stefan Popa <stefan.popa@analog.com> wrote:
>
> There is no point in having three menu entries that can be selected
> individually. Instead, the SPI and parallel interfaces should select
> AD7606.
>
> Signed-off-by: Stefan Popa <stefan.popa@analog.com>
> ---
>  drivers/staging/iio/adc/Kconfig | 24 +++++++++---------------
>  1 file changed, 9 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/Kconfig b/drivers/staging/iio/adc/Kconfig
> index fc23059..af1bad8 100644
> --- a/drivers/staging/iio/adc/Kconfig
> +++ b/drivers/staging/iio/adc/Kconfig
> @@ -4,35 +4,29 @@
>  menu "Analog to digital converters"
>
>  config AD7606
> -       tristate "Analog Devices AD7606 ADC driver"
> +       tristate
>         depends on GPIOLIB || COMPILE_TEST
>         depends on HAS_IOMEM
>         select IIO_BUFFER
>         select IIO_TRIGGERED_BUFFER
> -       help
> -         Say yes here to build support for Analog Devices:
> -         ad7605-4, ad7606, ad7606-6, ad7606-4 analog to digital converters (ADC).
> -
> -         To compile this driver as a module, choose M here: the
> -         module will be called ad7606.
>
>  config AD7606_IFACE_PARALLEL
> -       tristate "parallel interface support"
> -       depends on AD7606
> +       tristate "Analog Devices AD7606 ADC driver with parallel interface support"
> +       select AD7606

I don't think this works because the depends on for AD7606 may not be
satisfied. Moving the HAS_IOMEM here would help and either drop
GPIOLIB or move that too.

Rob