Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1364336imu; Thu, 13 Dec 2018 13:53:36 -0800 (PST) X-Google-Smtp-Source: AFSGD/WhdGNXOD0fBONJrXJ5xV5WIJTMjSOMX6dRAsIZyxSZQ+Q5cZIzrHDsG+W7TbiWHjw4nsn2 X-Received: by 2002:a62:cf02:: with SMTP id b2mr433507pfg.183.1544738016616; Thu, 13 Dec 2018 13:53:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544738016; cv=none; d=google.com; s=arc-20160816; b=arnf5CWN0QIKjQvcMK6QEOi28D5+2wGMHApodSHs9Ii1WXlfacCMsaoiRM67LQ64Ze zLTsEojAdAL1Fgor1zBtmyq73L25MfrRvfiw8Pf6VezNG9oqzFKbwjtdanD/PvF8JH20 o6+C2W1qKS6RlZqI6n8f4e7F01u9JMJPVtghb1ZeJ3YPi1GOHXFFBXrGXM6Izoo1JloW suViKll/gak/s/CUhz7Bk7LfyNNODFBLPk11PASUXbPbA99RQSvg4MjLTiCyDQXd2XEu feAiWzq6nP8oG4BW/ZnaR5jilgByWNv0PQ67rCUsFUhubDSAHESiqwdQFbgy+5riLIdi W+CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=SdbLibYTkngm70jUrsHcBOeFj/zNrkQg4kSEvctkGs4=; b=Pc7M7JvjTQjHeTKVkd9cAtURwVx4+IG/FsTu331CmvrlqZLVpE9/5XvgS6MZuL1hr8 Hr2pc47mTVB7TbSdNGVkKQtztivexZFLYxDPQAwibN82P5qzNxeD8wKMi8Rgc75ZHx/S hj7A+MGbm5v0SMkE/I+U0QhlL88jXoFBNS9zx8x+VtHhhJzvAKdE1BUKhxbNeYTXUg14 6Te1LDKZTKsgp/iVY4AjhMAkpZ9yvihnxGY7SZvkCWa7b9uhVToTZ+peBjwRNYR03zBU fr7Lsz1PhO0v53qHTrpRcmioLsE6L2F5yxS60dF2i58AVh6QDIl3SgeFOSI6PhFeXHQF TKiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f90si2476332plb.362.2018.12.13.13.53.20; Thu, 13 Dec 2018 13:53:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727911AbeLMVvO (ORCPT + 99 others); Thu, 13 Dec 2018 16:51:14 -0500 Received: from cloudserver094114.home.pl ([79.96.170.134]:42533 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726457AbeLMVvO (ORCPT ); Thu, 13 Dec 2018 16:51:14 -0500 Received: from 79.184.252.35.ipv4.supernova.orange.pl (79.184.252.35) (HELO aspire.rjw.lan) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.183) id bcac4d62866666fd; Thu, 13 Dec 2018 22:51:11 +0100 From: "Rafael J. Wysocki" To: Miquel Raynal Cc: Lorenzo Pieralisi , Stephen Boyd , sudeep.holla@arm.com, Gregory Clement , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , Bjorn Helgaas , devicetree@vger.kernel.org, Rob Herring , Mark Rutland , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Antoine Tenart , Maxime Chevallier , Nadav Haklai Subject: Re: [PATCH 05/12] PCI: aardvark: add suspend to RAM support Date: Thu, 13 Dec 2018 22:50:51 +0100 Message-ID: <61805564.abKDZ2rVK7@aspire.rjw.lan> In-Reply-To: <20181213153000.245d7d5f@xps13> References: <20181123141831.8214-1-miquel.raynal@bootlin.com> <20181213105302.GA5330@e107981-ln.cambridge.arm.com> <20181213153000.245d7d5f@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, December 13, 2018 3:30:00 PM CET Miquel Raynal wrote: > Hi Lorenzo, > > > > If that's really the case, then I can see how one device and it's > > > children are suspended and the irq for it is disabled but the providing > > > devices (clk, regulator, bus controller, etc.) are still fully active > > > and not suspended but in fact completely usable and able to service > > > interrupts. If that all makes sense, then I would answer the question > > > with a definitive "yes it's all fine" because the clk consumer could be > > > in the NOIRQ phase of its suspend but the clk provider wouldn't have > > > even started suspending yet when clk_disable_unprepare() is called. > > > > That's a very good summary and address my concern, I still question this > > patch correctness (and many others that carry out clk operations in S2R > > NOIRQ phase), they may work but do not tell me they are rock solid given > > your accurate summary above. > > I understand your concern but I don't see any alternative right now > and a deep rework of the PM core to respect such dependency is not > something that can be done in a reasonable amount of time. Maybe you don't need to rework anything. :-) Have you considered using device links? Thanks, Rafael