Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To:     Joe Perches <joe@perches.com>
Cc:     Carmeli Tamir <carmeli.tamir@gmail.com>, jthumshirn@suse.de,
        sergey.senozhatsky@gmail.com, akpm@linux-foundation.org,
        axboe@kernel.dk, martin.petersen@oracle.com, bvanassche@acm.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] fat: New macros to determine the FAT variant (32, 16 or 12)
References: <1544470917-6443-1-git-send-email-carmeli.tamir@gmail.com>
        <1544470917-6443-3-git-send-email-carmeli.tamir@gmail.com>
        <906167f7ca975d437ff9868333d8bf1e86b934a7.camel@perches.com>
Date:   Fri, 14 Dec 2018 12:16:07 +0900
In-Reply-To: <906167f7ca975d437ff9868333d8bf1e86b934a7.camel@perches.com> (Joe
        Perches's message of "Mon, 10 Dec 2018 12:09:31 -0800")
Message-ID: <87sgz0dci0.fsf@mail.parknet.co.jp>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Joe Perches <joe@perches.com> writes:

>>  
>> -#define FAT_FIRST_ENT(s, x)     ((MSDOS_SB(s)->fat_bits == 32 ? 0x0FFFFF00 : \
>> -	MSDOS_SB(s)->fat_bits == 16 ? 0xFF00 : 0xF00) | (x))
>> +#define IS_FAT12(sbi) (sbi->fat_bits == 12)
>> +#define IS_FAT16(sbi) (sbi->fat_bits == 16)
>> +#define IS_FAT32(sbi) (sbi->fat_bits == 32)
>
> sbi should be parenthesized or perhaps better these should be
> static inline bool functions

Right, rather this is the bug (not hit yet though) that should be fixed.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>