Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1866849imu; Fri, 14 Dec 2018 01:50:44 -0800 (PST) X-Google-Smtp-Source: AFSGD/XUMgMSlyhnBxHncLBcRBkp/AruStRZaNOPcP2VrvbW8BTkPF7LtvZ9gGkigLIT0mwVtiqX X-Received: by 2002:a17:902:a411:: with SMTP id p17mr2197680plq.292.1544781044654; Fri, 14 Dec 2018 01:50:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544781044; cv=none; d=google.com; s=arc-20160816; b=0Ji7cwi730dJT98PUCAums9CuHZjLCZjkYNh0D3RQR4yC42zHf51oWj/H9W7nL1+eo +TsoXBftQRGqhki/jshmV+NiMhPI5+Ft/s8gw9BhhVilNYmVOGk2EOfuLu8iTjJ9+78h aJA2rYSf2vyNME5apomKnStLDYoSVu+YYx9Bp4P4ZXTvCwkWDKQ8Lx/q5bwidZS0Omn7 aMYDnHXA0LQuwyICIkYtrgJc150mR/n7fwu1VlDFXp2GEgrC5t4BjqKLUVXx6+3vaZxE 12mi2fKh5zoQLiekajaR1K36RhC809tj6GlVaZXZU/wfU1G6nYCnEFIe770TNO6SaDoJ oYew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from; bh=8XVRDBuSdPPxmUwfVW+REaR8s+KQh3EwlHlHSh1l1gA=; b=l80AvVnv7ap6wWJ9Y7zotc1kxLhh9a4k9Q/F9Zfuv/wpWIPuQrcM3Y4p+WGxYSqIx8 F/hgdx0obplhqNJTeqx8NQXHvnYKO3zVpPyxRf116mhkc5x5Y+E2npMdxh+dspdZfIjv Uood4zT/MX9rM7ZUdU5MApoivpcH4gB97g7FEfrw84pcLa0MJgjf+aBjNSYvzo1ZyT4C zsOC3jLnq9uBkonIpYHEhO6QmG8XeCAO6wtqbbt+X7rQZ2afAj8wM8WGwhkcppFd09Cu iTOx7NliqfRHgUuupYYb+LkUuhISTXefPkcIGAXXPmkiRHhSsiYZiTqwqoEURFhFATwA 5+wA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t13si3487145pga.102.2018.12.14.01.50.29; Fri, 14 Dec 2018 01:50:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728829AbeLNJtd (ORCPT + 99 others); Fri, 14 Dec 2018 04:49:33 -0500 Received: from mail.parknet.co.jp ([210.171.160.6]:42600 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727579AbeLNJtc (ORCPT ); Fri, 14 Dec 2018 04:49:32 -0500 Received: from ibmpc.myhome.or.jp (server.parknet.ne.jp [210.171.168.39]) by mail.parknet.co.jp (Postfix) with ESMTPSA id ABE2B161688; Fri, 14 Dec 2018 18:49:31 +0900 (JST) Received: from devron.myhome.or.jp (foobar@devron.myhome.or.jp [192.168.0.3]) by ibmpc.myhome.or.jp (8.15.2/8.15.2/Debian-12) with ESMTPS id wBE9nUF3025703 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 14 Dec 2018 18:49:31 +0900 Received: from devron.myhome.or.jp (foobar@localhost [127.0.0.1]) by devron.myhome.or.jp (8.15.2/8.15.2/Debian-12) with ESMTPS id wBE9nU3i027752 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 14 Dec 2018 18:49:30 +0900 Received: (from hirofumi@localhost) by devron.myhome.or.jp (8.15.2/8.15.2/Submit) id wBE9nSLM027751; Fri, 14 Dec 2018 18:49:28 +0900 From: OGAWA Hirofumi To: Tamir Carmeli Cc: joe@perches.com, jthumshirn@suse.de, Sergey Senozhatsky , akpm@linux-foundation.org, axboe@kernel.dk, martin.petersen@oracle.com, bvanassche@acm.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] fat: New macros to determine the FAT variant (32, 16 or 12) References: <1544470917-6443-1-git-send-email-carmeli.tamir@gmail.com> <1544470917-6443-3-git-send-email-carmeli.tamir@gmail.com> <906167f7ca975d437ff9868333d8bf1e86b934a7.camel@perches.com> <87sgz0dci0.fsf@mail.parknet.co.jp> Date: Fri, 14 Dec 2018 18:49:28 +0900 In-Reply-To: (Tamir Carmeli's message of "Fri, 14 Dec 2018 10:14:35 +0200") Message-ID: <87efakcuaf.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tamir Carmeli writes: > I just want to make sure, is there a reason why I shouldn't delete > FAT_FIRST_ENT, as Joe Perches commented? FAT_FIRST_ENT() was used to check if fat spec compliance. But in real world, there are too many implementations that didn't follow spec. Well, so, now FAT_FIRST_ENT() is pointed only from comment. The reason is only for this comment. Thanks. -- OGAWA Hirofumi