Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1878497imu; Fri, 14 Dec 2018 02:05:20 -0800 (PST) X-Google-Smtp-Source: AFSGD/UqBVxUCYLaAEHhcwMWgt7shHB1oMrmrHNxFMMLJcWiU4i/b+rv/gkM8GxqaVXrEIqLz1ob X-Received: by 2002:a62:d504:: with SMTP id d4mr2238199pfg.38.1544781920570; Fri, 14 Dec 2018 02:05:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544781920; cv=none; d=google.com; s=arc-20160816; b=0zDIZdj3SOi2zpobj+pZjKvl6DUdJuM5oEt6BPzRoEAGZ9qz5iEJ2bVNKsWFbEy0T5 S4+rUS96x5YUKXdEtP/GcV4q491euNJ8ryY8EyRNgiuvwP0jsccgWPwXcifZyvkX67p+ zYb9vqkhH3y1jQdkAp8GWLv69AujW8JLxGJuTob7Om8P2sspJWiaBw0kBLx+l3d/KStX 3pTWoRAyaRTy5qSSgpm5ImC1vjbWW47P6wC5ySCaKIBIa/rYjpKqdLvVnEgS2kuYriq2 46SQbYUSltJLycjDEXbdRxjfFfQKjteKdMJPgMkxhZ2y/2SjWyJSroBnUfAWHovLO37Q T99A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=IDHKmtVL6/ZvrrxRnynPMSrxAPCPDbchrMAEWLjadG0=; b=ii1iRQTL8sUZD5WGLFB0RcHj6eV8CF5HKdLrEBGF7i/i4uZ2St7dkMBjWOL98zefyS XQQj5dI+vaVI267Zq86IX/9b/jFqwJ/0AAeaJON56r0Rif6N1hzBc1My7EAZ+h4v2wVM IsqVn0MWVnkZnDZ2E6uRT7ttn8C5tb1ptlcBObEfPAzXpULcoFBmIYIGWWEXpVgVhj+C dmVsSI9p3iBzvrNHqHefVVN2UmwMrJLrtcTcdSd72OCMDCEC6brfobWgGKyFV1JvMyCr n32P+H/LzDw62Cpj7ChpDFMgZUQseOilVBfCJ1RLPj1KAjTkyDZ4n3KJjcmX/92K2HAg RAIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="uq29A/nO"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y126si1234327pgb.165.2018.12.14.02.05.03; Fri, 14 Dec 2018 02:05:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="uq29A/nO"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729341AbeLNKCy (ORCPT + 99 others); Fri, 14 Dec 2018 05:02:54 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:45127 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726494AbeLNKCy (ORCPT ); Fri, 14 Dec 2018 05:02:54 -0500 Received: by mail-lf1-f67.google.com with SMTP id b20so3795466lfa.12 for ; Fri, 14 Dec 2018 02:02:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IDHKmtVL6/ZvrrxRnynPMSrxAPCPDbchrMAEWLjadG0=; b=uq29A/nOLmulzfegiXNgJI4pYeHgekOTmAJs3sKnAzSVkg7wHHLTfQqrK71uCZFh/H r3amSllaQFu4hFPfJyXE04UOETytWJat/FGVt4udtqOGpS2ohFgRbvuUy2Hwlsjdxu4m roza/dRgHpTeFTD8oVYHz5K8NRkdzmUEfiP/Amfyh+zau2nu53W7UqKzWYTUeKT+97bX aXdMRnRGUCGJjpjml7bbZdFVQRfERl91NYVQ31dPmSdqdU+MSGP5Di/F2sV69nPJOUss yJNR9ElHK0VaOlvTEpimbwEG1mcaSTdfNJ1f0mxP02J/kYp6INxsKI1VxMCXK4mebjhZ 3eog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IDHKmtVL6/ZvrrxRnynPMSrxAPCPDbchrMAEWLjadG0=; b=ibhmF8Hw5Vp3z8faVkbi4ziFjY38LLuU0rmL40mgF/hSrQa3oF54237nbCA1qpjAnI Uaw7ZUdVrO3Hls3yCmIoveM8tiJmlK/wEX31DSO/eQ7IXpc3ExQPYiT77mGXwMLy+Qkl 6JIlQSIsmv7dLe9ZE03DVMdCAEQgdlxPbc7IiX3SAl1Yrsx/jx/8BKsXPWt08FFYIR5+ BJsBVt9ESZPiTpOApvR+/CYBdNFjhs1ZNSnQeqIQYJMFYUVrfrkmst1TcCslUD9bJwyY qcl7GfM6Fiwfa3i1eSsn0ttSJfW7uyYjj75fEnvKwp4v7DDp4f9vLbElhOZcxdEWgoN1 D0Jg== X-Gm-Message-State: AA+aEWZEc6Wi2llE7ZlRHF+ZH/oPotv86hWtspjRF6i1yBpVIH3q0bMk GqZYKYAaDdEOHn8axACgfZ8pVPYJcXZrRjBzELg= X-Received: by 2002:a19:5782:: with SMTP id l124mr1318653lfb.91.1544781772004; Fri, 14 Dec 2018 02:02:52 -0800 (PST) MIME-Version: 1.0 References: <20181209032715.3466040-1-liuxiaozhou@bytedance.com> In-Reply-To: From: Miguel Ojeda Date: Fri, 14 Dec 2018 11:02:40 +0100 Message-ID: Subject: Re: [PATCH v2] Compiler Attributes: don't pollute userspace with macro definitions To: Nick Desaulniers Cc: liuxiaozhou@bytedance.com, Greg KH , Masahiro Yamada , Luc Van Oostenryck , Paul Burton , Arnd Bergmann , linux-kernel , Linus Torvalds Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 13, 2018 at 11:25 PM Nick Desaulniers wrote: > > Moving the __KERNEL__ guard should not affect the kernel, only what > userspace sees. __gnu_inline only affects which > implementation/definition you get, so even if userspace doesn't know > what the kernel's inline is redefined to, it should not matter as > userspace should only ever care about the function signature, which > does not change between our definitions of inline. Hm... I am unsure what you mean by this. Were you replying to me or to the original patch? Cheers, Miguel