Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Felipe Balbi <balbi@kernel.org>
To:     "Zengtao \(B\)" <prime.zeng@hisilicon.com>
Cc:     liangshengjun <liangshengjun@hisilicon.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Thinh Nguyen <thinhn@synopsys.com>
Subject: RE: [PATCH] usb: dwc3: gadget: fix miss isoc issue introduced by IRQ latency
In-Reply-To: <678F3D1BB717D949B966B68EAEB446ED24E20BE5@dggemm526-mbx.china.huawei.com>
References: <1544805179-2248-1-git-send-email-prime.zeng@hisilicon.com> <87efaklcd1.fsf@linux.intel.com> <678F3D1BB717D949B966B68EAEB446ED24E20BE5@dggemm526-mbx.china.huawei.com>
Date:   Fri, 14 Dec 2018 13:23:52 +0200
Message-ID: <878t0sl5br.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

"Zengtao (B)" <prime.zeng@hisilicon.com> writes:
>>-----Original Message-----
>>From: Felipe Balbi [mailto:balbi@kernel.org]
>>Sent: Friday, December 14, 2018 4:52 PM
>>To: Zengtao (B) <prime.zeng@hisilicon.com>
>>Cc: liangshengjun <liangshengjun@hisilicon.com>; Zengtao (B)
>><prime.zeng@hisilicon.com>; Greg Kroah-Hartman
>><gregkh@linuxfoundation.org>; linux-usb@vger.kernel.org;
>>linux-kernel@vger.kernel.org
>>Subject: Re: [PATCH] usb: dwc3: gadget: fix miss isoc issue introduced by
>>IRQ latency
>>
>>* PGP Signed by an unknown key
>>
>>Zeng Tao <prime.zeng@hisilicon.com> writes:
>>
>>> If it's a busy system, some times when we start an isoc transfer, the
>>> framenumber get from the event buffer may be already elasped, in this
>>> case, we will get all the packets dropped due to miss isoc. And we
>>> turn into transfer nothing, to fix this issue, we need to fix the
>>> framenumber to make sure that it's not out of date.
>>>
>>> Signed-off-by: Liang Shengjun <liangshengjun@hisilicon.com>
>>> Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>
>>
>>There's a patch going upstream already doing this:
>>
>>https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git/commit/?h
>>=3Dnext&id=3Dd53701067f048b8b11635e964b6d3bd9a248c622
>>
>
> Sorry, I think I missed to update to the latest version. But I think my=20
> patch is more efficient. Because I just sync the frame from the HW, it
>  won't fail and there is no need to extra tries.
>
> What do you think about it?

the 14 bits you use for your check is not representative of the actual
micro-frame you're currently in. Thinh explained that in the discussion
we had until we came to the patch I pointed you to above. Please look at
the mailing list archives for details.

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlwTksgACgkQzL64meEa
mQZJng//XfRK6HOJ2tT9+GNmNvtyo8h1BNhMhEZvXkn4WTvU2ecqq3GLOphr9Fts
ux0T2be5pbjJ0xdBCbiMjL9XKDs3BxKTP5kzfjDikGFeZyjwPDqjlOC2HGgiJt40
GXorTFOBfEsGSP9nVNYL1OFPYsTTwZSYypmo5FpRNpq4Ey9izfUvu/NYN1y6l5RA
MH6gOdasaMZL98mETXNP8hK4m3pjz5RbcBUJW9uDlw53XjWlQ3L1lbaFCsT8f0lY
GCDVVUNYoRr4vxrsZ1WkaHa7BcU4ONLnWhK1S5s0CtMv77nXlzzy6nQ2IOEfZJEJ
VQYVBbst02PTQPlACB32Knt367ajrH+Xh0k4vCRvJ6SxgAwMzjwq1QgUGg9hV881
zj9ZNESbNC/+KGIK83w1uKoUZ6S4MELD1tbyD6wTtIOUHJZ5KSUqvk2b0DAqiiqw
RWr+UVj54J5mx+viwICw1MJvQS489oh39uLznB+ODXSXkFBQZDXrt/ZTkd7+XKyp
zzDbJIyFLCJtSnP1xg8FrHTu99dbQtHwi33xLryP0V5OmbRzkvG7Xsl+zLiRQsuJ
gdd2rmy07gAkeN+Qnfa7HE/RSYt1/OD2DBB1OIegBsIgOd2fe34WhfSxov333906
ZfhEjwk7KKchpwIfKvdj66WIJzPF5jhic/jAW4Vr9pKvvFOyeSA=
=Sr1X
-----END PGP SIGNATURE-----
--=-=-=--