Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1982955imu; Fri, 14 Dec 2018 04:04:11 -0800 (PST) X-Google-Smtp-Source: AFSGD/UUYd563bbprBCDqlpdgcXTjTKzBdp+Vcr2YNOsFCM5RfylhXboqso1pAYfpP9hLVXHLkUX X-Received: by 2002:a62:6ec8:: with SMTP id j191mr2572715pfc.198.1544789051044; Fri, 14 Dec 2018 04:04:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544789051; cv=none; d=google.com; s=arc-20160816; b=z9unP/uQWnVgobpTGSTgEXqurnEAONX4ULGknxkuyJ3HkOYyvwYCmB6UOMCqWj9Q41 xJu28NtpEtAkzIxLIFdplyyHePSeSvt/SlM4Q1akHFUle9YIDnmtmVaHWXWh72BjOMFU iFicjUySAvS8SOH++sbe74b65bB2ligl20gMU5LivVRUjL54rJEPoOQ0FhgMbKZLavOy g0pbkJ0ukPm6bpqCEn8RuyffFhLxNifB9SqYTpxWZCpBNgLPb/cWdXpx2LCq2rO5ZlYe ybHxMGxe6ZoIW4u46azFSzZ5cIlEvokv9V7xO/PenDMqcRxk3HULWN9FrGogtmcD+2M4 s2qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=NwtOycx5PtQVBnjidYa+2rY9oSYLb+1zHLtC/eBl1xo=; b=vuIVUeO0v1vxkc44niUqB32MnioigCVz5ohEGMDo1DNF1OcyKm5GCn/8Q2HktqSOmp EGi/V6PP42r3km3RLHtQaupKD6dPtzAZ/Hicb6qsV3n5QwOOwIGidO53MWkmADLL9n7b jvTexphkBymID9BvzE2Zb32i4dO4Mf63g7SNE1sphRGbeAy0gKqEDMieUZGCKQvt2IlN fLgqCFNIul6BSUrvJwYLF7S6QTYVcUxVJAXqmYPx5pXHpimmuMX5BJAMFZGW8MTuqT4b /3ZMwwLzuQudB6nxHMzfKPhWg+xLH3ppIWiBDYi/3gR1YZ0q9LtlRyuBLnAbb36ygtcY SSVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Z2DvdGk2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d23si4023156pgm.559.2018.12.14.04.03.35; Fri, 14 Dec 2018 04:04:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Z2DvdGk2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729895AbeLNMB6 (ORCPT + 99 others); Fri, 14 Dec 2018 07:01:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:44568 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729878AbeLNMBz (ORCPT ); Fri, 14 Dec 2018 07:01:55 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1BBF121473; Fri, 14 Dec 2018 12:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544788914; bh=87O5TKNBxDSUtzqs6IzixB45nIraD5mu9yMETS3QvQo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z2DvdGk2zVCRm9EoIxgLMiE41oHQcV3F4On8q4qQv4ZPwf7UC034sy6CmFxYlSX63 Y82oVHIs0+hiTJAsjG1pH/9ln9T+T2+q+GUTq0AwTtwfbJfK0mvNdluPMeva5i+GJ6 ex5ma6riM+p/dlxLbqiYU/VaE3FgsxLrf7W1VuUc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eran Ben Elisha , Tariq Toukan , "David S. Miller" Subject: [PATCH 4.19 007/142] net/mlx4_en: Change min MTU size to ETH_MIN_MTU Date: Fri, 14 Dec 2018 12:58:12 +0100 Message-Id: <20181214115747.344285186@linuxfoundation.org> X-Mailer: git-send-email 2.20.0 In-Reply-To: <20181214115747.053633987@linuxfoundation.org> References: <20181214115747.053633987@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eran Ben Elisha [ Upstream commit 24be19e47779d604d1492c114459dca9a92acf78 ] NIC driver minimal MTU size shall be set to ETH_MIN_MTU, as defined in the RFC791 and in the network stack. Remove old mlx4_en only define for it, which was set to wrong value. Fixes: b80f71f5816f ("ethernet/mellanox: use core min/max MTU checking") Signed-off-by: Eran Ben Elisha Signed-off-by: Tariq Toukan Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 4 ++-- drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c @@ -3494,8 +3494,8 @@ int mlx4_en_init_netdev(struct mlx4_en_d dev->gso_partial_features = NETIF_F_GSO_UDP_TUNNEL_CSUM; } - /* MTU range: 46 - hw-specific max */ - dev->min_mtu = MLX4_EN_MIN_MTU; + /* MTU range: 68 - hw-specific max */ + dev->min_mtu = ETH_MIN_MTU; dev->max_mtu = priv->max_mtu; mdev->pndev[port] = dev; --- a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h +++ b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h @@ -161,7 +161,6 @@ #define MLX4_SELFTEST_LB_MIN_MTU (MLX4_LOOPBACK_TEST_PAYLOAD + NET_IP_ALIGN + \ ETH_HLEN + PREAMBLE_LEN) -#define MLX4_EN_MIN_MTU 46 /* VLAN_HLEN is added twice,to support skb vlan tagged with multiple * headers. (For example: ETH_P_8021Q and ETH_P_8021AD). */