Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1989860imu; Fri, 14 Dec 2018 04:09:32 -0800 (PST) X-Google-Smtp-Source: AFSGD/UPh/qvP7+f5KsZu7iEqU+WuJzV8hVXZAFbk5fd0O2tv0TKzGTsSHIKVQkfHINpEvyjSB+n X-Received: by 2002:a62:644:: with SMTP id 65mr2569043pfg.161.1544789372514; Fri, 14 Dec 2018 04:09:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544789372; cv=none; d=google.com; s=arc-20160816; b=m4DMH94hPMub45Z7TSGO9S8367iDvGGw8f7qbrz8YsxW5cuTs1C6baxjCHoTxrKCIa 2sDy9DFAkmaqV8xt987DEObEO7FOiODnfPJrFspekRW9yt6veqJ+pTPqsb5HjqG6TNJh DSFn+OG1SWAiu/bDA+De0SdQ4nCCrix4mT5ak6xsz+dm1VWlgDTXupHJRHDv+aHH55S3 ZU2G6tlcKhnErm8p1r4lxKfBWGaAU5gQZMuOzSuskO8o6N73gkTVh2dKljh15e/f5pAc kADvPLfcRsm3+Es10ILxT2/6QUSckLirC9lMM37RDEafcJls8Zr1rG+4OKYAfVlB5yLV 3wHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=PMj+X71+eYo7j5emlrbw8ZzCIfBybByqa6CHpY0ALKg=; b=Z71iZJZ2iN61sura9r2FrrvilnApoEYAgYFQBHhI7KcS5qy7ZDow3Su2xGzfxXKAmj yCQ11bbfVgYv5ygZ4gC4lrFfQFL5HS3EbLr0qAUewGpge7hxNodBzxq8blcc8DyxV635 VMGUaYZtI6MRnPUJ4F4SLEYBxmg6DkfLB95wnf6VzDCweAQaHFkB2W3Cfhi5lpkUFZdU 8eBxl17FMoK/au6xkabUzuCWjW0Wk7g1YVKTL2iD8G5GyRoiYqlnqpoOLIBLQORn9aJX i+XpT3pG4ti4MKbCSXgnws9AQZzFIsRa2OGsM1rJXGl/qlHT1YJEXj6mkh/aV/uxVcYO OoNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wVsaZ3vc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t63si3735843pgd.78.2018.12.14.04.09.14; Fri, 14 Dec 2018 04:09:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wVsaZ3vc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730444AbeLNMGr (ORCPT + 99 others); Fri, 14 Dec 2018 07:06:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:51890 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730977AbeLNMGp (ORCPT ); Fri, 14 Dec 2018 07:06:45 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E1C3621486; Fri, 14 Dec 2018 12:06:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544789204; bh=N0CWDW7V7bhu2+zhcIYgw915OzEQrA/J/7TLfYClBA0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wVsaZ3vch4l/AywxpNfHbgRqdS/kY8qtQQeAKJexZ/ucxRxhs76iJJO1pljyMXbDX lZB5/Qz7qP+U4XddBKVBLKa4nDeqEYJUOQUzHalV7MX7i6goZlh6LIckwfzJSY5VEi Vp9uTv1GOA2mne8R+pikHG92H7uYTpsozw/Oqi2c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Sakamoto , Takashi Iwai Subject: [PATCH 4.19 135/142] ALSA: fireface: fix reference to wrong register for clock configuration Date: Fri, 14 Dec 2018 13:00:20 +0100 Message-Id: <20181214115752.433931882@linuxfoundation.org> X-Mailer: git-send-email 2.20.0 In-Reply-To: <20181214115747.053633987@linuxfoundation.org> References: <20181214115747.053633987@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Takashi Sakamoto commit fa9c98e4b975bb3192ed6af09d9fa282ed3cd8a0 upstream. In an initial commit, 'SYNC_STATUS' register is referred to get clock configuration, however this is wrong, according to my local note at hand for reverse-engineering about packet dump. It should be 'CLOCK_CONFIG' register. Actually, ff400_dump_clock_config() is correctly programmed. This commit fixes the bug. Cc: # v4.12+ Fixes: 76fdb3a9e13a ('ALSA: fireface: add support for Fireface 400') Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/firewire/fireface/ff-protocol-ff400.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/firewire/fireface/ff-protocol-ff400.c +++ b/sound/firewire/fireface/ff-protocol-ff400.c @@ -30,7 +30,7 @@ static int ff400_get_clock(struct snd_ff int err; err = snd_fw_transaction(ff->unit, TCODE_READ_QUADLET_REQUEST, - FF400_SYNC_STATUS, ®, sizeof(reg), 0); + FF400_CLOCK_CONFIG, ®, sizeof(reg), 0); if (err < 0) return err; data = le32_to_cpu(reg);