Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2011300imu; Fri, 14 Dec 2018 04:28:59 -0800 (PST) X-Google-Smtp-Source: AFSGD/W6n2TAXHW4riK95ie4DHmMnMvvB0FxA9FiqskYPkT5Xc7x8SRynfB4PvFvn5i8BRnAoWS6 X-Received: by 2002:a62:4587:: with SMTP id n7mr2657981pfi.118.1544790539125; Fri, 14 Dec 2018 04:28:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544790539; cv=none; d=google.com; s=arc-20160816; b=Tjk17heRfgSPbU6G9LFwiCguwo3K8JBUabacdovBxxOjFb0dnmjdVZCHCsUL00vequ gDRvwZWFOtoZj3Vy+38kvN/trIZk1bzZzUsLo4SYyM1nhl+1jSMsUTiVjiFZwT71D0jn 47agmrS10PHmhZZVivYgH/tzdvNRO3mH4LkRXVkMDtBLZG28YGaZcJMc/+bqhlTbQpmJ +D/sxFH0SruuSgTlXzvNdUl1G77dQkMY6MkXFiVGjzaO1YU3YO1d61F59OwH/P3O/LiV HKoqT/tXrcjvicuk+L1GVUFoGI0cYWkplo9ltPE8tlWCXm5/dWfSfcWHRnyVBKT593Wb mo+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ldefQvgIxiQ5qPQ8A8hN6enFrddkD3DJHByuqXV5A+c=; b=To0QwjiDyeunPua6foXt1KdiQ5TzyvBwwB7OvpsJYSceO3VwesRA3agUAQUT7KDFAC zbgsxKMSTPAHI/YSdspsB3FaVvwB2AlHB0jSG+HzMrM/+iaqrv7ox92eiYwA8DmfNIHr WaDBxo/5GP02BALeDCCUbK1k78MxIys/lx5/rduMeggx4BT1iljCLofp2k/x8uXUk6iU 8jfb+cc7Ku9o83UrVl8nSIxvPwlP2clQnsrX3SOHWeVyMSWDkdqoxr/G1nDE5dsBAtQb xvz/AU3s1Um6qvfcPWMnkcb+CnQZaTAZZg5Z0Tq8CZso48CSZkOkZ4z1Jal0Ed2ASchB khhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HOkj0TqS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s5si3770382plr.211.2018.12.14.04.28.44; Fri, 14 Dec 2018 04:28:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HOkj0TqS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731739AbeLNMLM (ORCPT + 99 others); Fri, 14 Dec 2018 07:11:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:57778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730974AbeLNMLK (ORCPT ); Fri, 14 Dec 2018 07:11:10 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C61D2214C4; Fri, 14 Dec 2018 12:11:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544789469; bh=q9DLrpT1Nm9t8fRELDQFQ1UVq64n4B3vLWXJ4nh+ixs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HOkj0TqSk2FjblJRrFUb3cmqGmKLGmQ00iRgnZ3+XbCOY6Cc1znCt5qwgOjt1nSZT kbVr1QwrRd/OPohcPOUrcpeiKaWIuqHAnjQEIdIGXSNfVu6ua28wQ9aLFL0KRIwd6F kpoaMxRKg+ij7NH8W2Sp85iNxKMCMr4nKlJH3xrk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Sakamoto , Takashi Iwai Subject: [PATCH 4.14 87/89] ALSA: fireface: fix reference to wrong register for clock configuration Date: Fri, 14 Dec 2018 13:00:40 +0100 Message-Id: <20181214115733.989815890@linuxfoundation.org> X-Mailer: git-send-email 2.20.0 In-Reply-To: <20181214115729.658859279@linuxfoundation.org> References: <20181214115729.658859279@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Takashi Sakamoto commit fa9c98e4b975bb3192ed6af09d9fa282ed3cd8a0 upstream. In an initial commit, 'SYNC_STATUS' register is referred to get clock configuration, however this is wrong, according to my local note at hand for reverse-engineering about packet dump. It should be 'CLOCK_CONFIG' register. Actually, ff400_dump_clock_config() is correctly programmed. This commit fixes the bug. Cc: # v4.12+ Fixes: 76fdb3a9e13a ('ALSA: fireface: add support for Fireface 400') Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/firewire/fireface/ff-protocol-ff400.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/firewire/fireface/ff-protocol-ff400.c +++ b/sound/firewire/fireface/ff-protocol-ff400.c @@ -30,7 +30,7 @@ static int ff400_get_clock(struct snd_ff int err; err = snd_fw_transaction(ff->unit, TCODE_READ_QUADLET_REQUEST, - FF400_SYNC_STATUS, ®, sizeof(reg), 0); + FF400_CLOCK_CONFIG, ®, sizeof(reg), 0); if (err < 0) return err; data = le32_to_cpu(reg);