Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2018081imu; Fri, 14 Dec 2018 04:35:01 -0800 (PST) X-Google-Smtp-Source: AFSGD/WyruhYIf7HOAZ26QuEhzDZshWBjJfEt00Z3op9v6BruOwYD5ZHfUiJVTmp8G8WrCiiprmS X-Received: by 2002:a17:902:b40d:: with SMTP id x13mr2750409plr.237.1544790901610; Fri, 14 Dec 2018 04:35:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544790901; cv=none; d=google.com; s=arc-20160816; b=aVA1+cAYkaR+uR4JazLa2DFVHOPfA3drG1NRSB8ceiIvnS/uoMRb9N32GujmNdLgvK rXA0pv6SY7nduMm1K8HuqTguK0Q1MTQ+8fhbmpD20pLnXevEhzgbXqRSfbOSqabY73/R CyjMxM9eRXx+/bUNJlDxvNrk2oMH9aI0vg9+jCYHqFwLgvB9qkL0DdKt1TOoFsjAOT7f 9zs7NEFDnLiQyXmyU/i/r4qWsmgEw01Z7lboIo0xopoWocsOXgv8c18Gc0mwPNwGIiqO f2raF9CJIBgwo6MT+uydps8qYBVBKDDynTdiJu/nGx1kC6XB8KCXN35UsYLApZcI+sND 5eyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+8r0lbxNdmup4PbtnJw+Z9Q/8RVkXWxURwuk//1lrlg=; b=jzV8Ny/o1egf2CHp2209bo9e0Fvy0bZaUxBrQVyP/GXdiuxyFrDqGRoHb3nXmKLUVF piTHFPEfmWEMwicue1LAsMpyTTIIYxxl5b0kK5nNcgX/DSnEuujBuw5oTHA8ehM+7s/1 slZ1HHvDFD7r4IbJqtTGByNWaBesoLfsWnUCSmBZs1RAKoZJV+AItSEdEJjRgZZVwDnE estxsYY4d688LRYdOPEOYgi9kSwtLFf7umV6I4+n0wmRqeAx2/i7f+ZS4b588Lo7osd1 1B5Gln4itT6trhh2y2a40No6P0sgFlj2XEWEoXKjUPipW58Qt/YO8Xvcpi063r2hRSx3 Ljrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zh180wAJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g11si4019775pgn.32.2018.12.14.04.34.44; Fri, 14 Dec 2018 04:35:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zh180wAJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731417AbeLNMJP (ORCPT + 99 others); Fri, 14 Dec 2018 07:09:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:54866 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731406AbeLNMJM (ORCPT ); Fri, 14 Dec 2018 07:09:12 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0BA62214DB; Fri, 14 Dec 2018 12:09:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544789351; bh=6Ynuk/ccUYp6zB2S3VBa3c/eE5mcj+9a+0VM6OvXMFo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zh180wAJ9PvHp3CTDJe9P1Shl4/LFLbgw+USozWyHJTSJX7M98psECMuY+jsvL49S DsE84CMzwBrShLAQ1B0DjmQaxO65FUY5lRhu47nMg48vP/+LVSsevKTy1xU2DSlZW6 UHPKzrTsRfttqg7+7aT61RigQ0UdAIdpBhwy0FoQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Aaro Koskinen , Felipe Balbi , Sasha Levin Subject: [PATCH 4.14 49/89] USB: omap_udc: fix omap_udc_start() on 15xx machines Date: Fri, 14 Dec 2018 13:00:02 +0100 Message-Id: <20181214115732.086206553@linuxfoundation.org> X-Mailer: git-send-email 2.20.0 In-Reply-To: <20181214115729.658859279@linuxfoundation.org> References: <20181214115729.658859279@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 6ca6695f576b8453fe68865e84d25946d63b10ad ] On OMAP 15xx machines there are no transceivers, and omap_udc_start() always fails as it forgot to adjust the default return value. Signed-off-by: Aaro Koskinen Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/omap_udc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/omap_udc.c b/drivers/usb/gadget/udc/omap_udc.c index d45dc14ef0a2..9060b3af27ff 100644 --- a/drivers/usb/gadget/udc/omap_udc.c +++ b/drivers/usb/gadget/udc/omap_udc.c @@ -2045,7 +2045,7 @@ static inline int machine_without_vbus_sense(void) static int omap_udc_start(struct usb_gadget *g, struct usb_gadget_driver *driver) { - int status = -ENODEV; + int status; struct omap_ep *ep; unsigned long flags; @@ -2083,6 +2083,7 @@ static int omap_udc_start(struct usb_gadget *g, goto done; } } else { + status = 0; if (can_pullup(udc)) pullup_enable(udc); else -- 2.19.1