Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2018892imu; Fri, 14 Dec 2018 04:35:49 -0800 (PST) X-Google-Smtp-Source: AFSGD/VKdbMn+m9U7Bah+9L42QiP9Frc/wEzK4/xPbUidcb1zKlBAscbKy5aCenJzhe2K2Mnq/q2 X-Received: by 2002:a62:4255:: with SMTP id p82mr2657281pfa.13.1544790949715; Fri, 14 Dec 2018 04:35:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544790949; cv=none; d=google.com; s=arc-20160816; b=mgIR9iq5acLYexJBEZixrWGQI6Lxz0P8MYEW91xplFlJtCx0KVb8B2y5bLd9hsv/qe xrM+8SZla/mnFMrcCcwD5VCIY+4c6wsfnAj0AGSDtlm4FOFn35w2ZY18j5KEvQhCqVbb 2m8tX+fpXXDgWd5dM4A6u+fQ962+29gngGDfhC0/r3VsrafYaHPzrzdUq206aydfDmzu zune+RvLyFuL3xvMto4WpEz2NjZjhQNOSW/NRQ+AGAOBhEAB9XIPpPESQ3ZIlPCu/Fn3 1KPYpy+pp1uLjw1vTBl2ePSbeOlJScNGxd7PTwphmfyLSAqYwtBdJ0iK36NhpMHu8tLQ CRcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=bIZtp4ZsL1jlV5hLleaHcnyQZ9yWyd1KLdL4oe6X1Ds=; b=Prek7iSwT1Z/PqbIIn7YIGFty3z11vHn4GgeUs2OvIYpoVoFUL++jsorraQ2e127G7 FMYv7laDOXh2fKe7U8xpb25GvSuim62pWAIoHeSIWRZy5ldMUhxf5buJQoWj58zQFogg EDyecZll4ep/1gDefY/oZryR2qTVb2E8vUpgH49qYWRUATCI16aFuP94fB6JdkRZxc7J jgRb7tcBAp5WqT2rPmhpwSBrBMmF79IH+aKSDHuFtLKltnX69PRPXyCFr6nqkVf15Za6 uWb2dLvnMi3ayzEQtkkDfCxOOYTTHXi1rfuqT24Vcw2mmI+iztZmf7uQmo10OXck7JGk H8qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="H/08UGXK"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a18si3964394pgj.77.2018.12.14.04.35.32; Fri, 14 Dec 2018 04:35:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="H/08UGXK"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731217AbeLNMe2 (ORCPT + 99 others); Fri, 14 Dec 2018 07:34:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:53320 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730637AbeLNMH4 (ORCPT ); Fri, 14 Dec 2018 07:07:56 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 80E02214C4; Fri, 14 Dec 2018 12:07:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544789276; bh=PKXt4YZ3RVQ6krAXwrmN3WK1ps/Fk9PxaXRWG/UTtn4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H/08UGXKzxI/HPzwe7WxJd6xsHrEGsKFk5AYH+MaasaxAPZrhkaO7oK7scfsy8SML zSaz2al0DOiLgO1jsxvauvSGlh0LvvnK/8r2EHwvuCPhU53ubGcv8P1WjHyZvF/mQ5 too1vIgvXecslW2ZPuNYbeHWEiISkc0wfqNMgFcc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eran Ben Elisha , Tariq Toukan , "David S. Miller" Subject: [PATCH 4.14 07/89] net/mlx4_en: Change min MTU size to ETH_MIN_MTU Date: Fri, 14 Dec 2018 12:59:20 +0100 Message-Id: <20181214115730.027966839@linuxfoundation.org> X-Mailer: git-send-email 2.20.0 In-Reply-To: <20181214115729.658859279@linuxfoundation.org> References: <20181214115729.658859279@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eran Ben Elisha [ Upstream commit 24be19e47779d604d1492c114459dca9a92acf78 ] NIC driver minimal MTU size shall be set to ETH_MIN_MTU, as defined in the RFC791 and in the network stack. Remove old mlx4_en only define for it, which was set to wrong value. Fixes: b80f71f5816f ("ethernet/mellanox: use core min/max MTU checking") Signed-off-by: Eran Ben Elisha Signed-off-by: Tariq Toukan Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 4 ++-- drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c @@ -3505,8 +3505,8 @@ int mlx4_en_init_netdev(struct mlx4_en_d dev->gso_partial_features = NETIF_F_GSO_UDP_TUNNEL_CSUM; } - /* MTU range: 46 - hw-specific max */ - dev->min_mtu = MLX4_EN_MIN_MTU; + /* MTU range: 68 - hw-specific max */ + dev->min_mtu = ETH_MIN_MTU; dev->max_mtu = priv->max_mtu; mdev->pndev[port] = dev; --- a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h +++ b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h @@ -157,7 +157,6 @@ #define HEADER_COPY_SIZE (128 - NET_IP_ALIGN) #define MLX4_LOOPBACK_TEST_PAYLOAD (HEADER_COPY_SIZE - ETH_HLEN) -#define MLX4_EN_MIN_MTU 46 /* VLAN_HLEN is added twice,to support skb vlan tagged with multiple * headers. (For example: ETH_P_8021Q and ETH_P_8021AD). */