Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2088877imu; Fri, 14 Dec 2018 05:41:26 -0800 (PST) X-Google-Smtp-Source: AFSGD/XKwQ28WEABzx26TgaE2YN2amnsQVwLmDPSa+QR9Cjsh1KVNJaBVEqN2XPpIvKhxiftifFb X-Received: by 2002:a63:a41:: with SMTP id z1mr2747441pgk.117.1544794886384; Fri, 14 Dec 2018 05:41:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544794886; cv=none; d=google.com; s=arc-20160816; b=lyIl+Km7ctfHEVaq51FzaW/Z+HeWvp2KsGx0JYJLRKponaoWhFYOK02qwE8AOI4tDh qjJnRb/V1i+QvQSv8NwuUbTgz0w/AquakV3Z4F2kX9NP86lKq5Ea9NZWPRjINLrkld3J LXOCrAQVWS5r9UjQgErzNz6m85Vs3cOObcRzLrWwM6cP2Dktrj7CW+wkkMGOxOcTb4ug d8NUS9u3/MSVHJJ5gSVUEDwzqnHcbxz9fGRbYQ7Id2MD8kvTCww5otiRCIGLoWRieguV k1/Mras5U0A7rUEjRwBsj9OO28aJWbil/s3pbe5h0AZ2N5ONwOAqhN8+1Zlu4hgYi5li zsHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=n1Au1nfTmrURaxHBQX/4bgJNOxlggNstIllnKhQuXGs=; b=W6INZIpzMgKBpmSHjDd3qxBw5F2ObDn1RvmtJnwknwGgaQtuAv527YeFXiAWU1ChHU kGeozQJRh3lyAvaZzCbf1vV19Z6VueUZr+WL288Jyf0155jyohqXdCxBN8RY73dK8mV8 0eLYVaB4IF34ghtBhC2SWg8SNUz42fdw+5MeAURGYB79Di+lVYq6XgXs8PHskKHe4iWQ DBbG98NhmZcGW6tQlkdZEbBI+da/o7rA5/NjXokvHQ2Zh4OPDP95/jpscD4samI17qe2 eAaIWdNz+fLxMuMEoVQ3FDEUo34FwmPukHZYqBaCm3eZZaJWVZ/tbGcZbq3Q5KIZ3cul m0Aw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p186si4085153pgp.37.2018.12.14.05.41.10; Fri, 14 Dec 2018 05:41:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729851AbeLNNjV (ORCPT + 99 others); Fri, 14 Dec 2018 08:39:21 -0500 Received: from smtp2207-205.mail.aliyun.com ([121.197.207.205]:50316 "EHLO smtp2207-205.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728415AbeLNNjV (ORCPT ); Fri, 14 Dec 2018 08:39:21 -0500 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.07703226|-1;CH=green;FP=17861118287567185914|1|1|5|0|-1|-1|-1;HT=e01e01542;MF=liaoweixiong@allwinnertech.com;NM=1;PH=DS;RN=6;RT=6;SR=0;TI=SMTPD_---.DXQyAtf_1544794713; Received: from PC-liaoweixiong.allwinnertech.com(mailfrom:liaoweixiong@allwinnertech.com fp:SMTPD_---.DXQyAtf_1544794713) by smtp.aliyun-inc.com(10.147.42.198); Fri, 14 Dec 2018 21:38:38 +0800 From: liaoweixiong To: Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck Cc: linux-kernel@vger.kernel.org, liaoweixiong Subject: [PATCH v2] pstore: turn compression options back to 'bool' Date: Fri, 14 Dec 2018 21:38:31 +0800 Message-Id: <1544794711-30015-1-git-send-email-liaoweixiong@allwinnertech.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On commit 58eb5b670747 ("pstore: fix crypto dependencies"), dependency bug was fixed by selecting the crypto core rather than turned compression sub-options to 'tristate'. In addition, these options are used to enable/disable compression. They are not modules, and mean nothing when set to 'M'. So, this patch is going to turn them back to 'bool'. Fixes: 58eb5b670747 ("pstore: fix crypto dependencies") Acked-by: Kees Cook Signed-off-by: liaoweixiong --- fs/pstore/Kconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/pstore/Kconfig b/fs/pstore/Kconfig index 0d19d19..8b3ba27 100644 --- a/fs/pstore/Kconfig +++ b/fs/pstore/Kconfig @@ -14,7 +14,7 @@ config PSTORE say N. config PSTORE_DEFLATE_COMPRESS - tristate "DEFLATE (ZLIB) compression" + bool "DEFLATE (ZLIB) compression" default y depends on PSTORE select CRYPTO_DEFLATE @@ -23,21 +23,21 @@ config PSTORE_DEFLATE_COMPRESS algorithm support. config PSTORE_LZO_COMPRESS - tristate "LZO compression" + bool "LZO compression" depends on PSTORE select CRYPTO_LZO help This option enables LZO compression algorithm support. config PSTORE_LZ4_COMPRESS - tristate "LZ4 compression" + bool "LZ4 compression" depends on PSTORE select CRYPTO_LZ4 help This option enables LZ4 compression algorithm support. config PSTORE_LZ4HC_COMPRESS - tristate "LZ4HC compression" + bool "LZ4HC compression" depends on PSTORE select CRYPTO_LZ4HC help -- 1.9.1